Patch Set 1:
The above build failure seems dubious.
The build is complaining about a missing header file (osmocom/bsd/acc_ramp.h)
which is a file added by my commit. Have I done something wrong or is this a
bug in the jenkins build?
--
To view, visit https://gerrit.osmocom.org/6324
To unsubsc
Patch Set 1:
> The above build failure seems dubious.
> The build is complaining about a missing header file
> (osmocom/bsd/acc_ramp.h) which is a file added by my commit. Have I
> done something wrong or is this a bug in the jenkins build?
The problem appears only during the 'make distcheck'
Patch Set 1:
(3 comments)
https://gerrit.osmocom.org/#/c/6324/1/include/osmocom/bsc/acc_ramp.h
File include/osmocom/bsc/acc_ramp.h:
Line 20: #ifndef _ACC_RAMP_H_
Do we still use this way of the include guard?
Why now '#pragma once'?
https://gerrit.osmocom.org/#/c/6324/1/src/libbsc/chan_alloc.
Patch Set 1:
(3 comments)
> > The above build failure seems dubious.
> > The build is complaining about a missing header file
> > (osmocom/bsd/acc_ramp.h) which is a file added by my commit. Have
> I
> > done something wrong or is this a bug in the jenkins build?
>
> The problem appears o
Patch Set 2: Code-Review-1
(11 comments)
https://gerrit.osmocom.org/#/c/6324/2/include/osmocom/bsc/acc_ramp.h
File include/osmocom/bsc/acc_ramp.h:
Line 1: /* (C) 2018 Stefan Sperling
(C) sysmocom / Author: Stefan Sperling, please look at other examples, thanks.
Line 41:struct gsm_bts
Patch Set 2:
(9 comments)
https://gerrit.osmocom.org/#/c/6324/2/include/osmocom/bsc/acc_ramp.h
File include/osmocom/bsc/acc_ramp.h:
Line 1: /* (C) 2018 Stefan Sperling
> (C) sysmocom / Author: Stefan Sperling, please look at other examples, than
Fine, fixed in next patch set.
Line 41:
Patch Set 7:
(6 comments)
looks great, aside from some cosmetic issues. The uint16_t is an optional idea
(isn't it simpler?) as is enabled-in-struct-acc_ramp, but all other comments I
would like to see adressed. thanks.
https://gerrit.osmocom.org/#/c/6324/7//COMMIT_MSG
Commit Message:
Line 1
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6324
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0a5ac3a08f992f326435944f17e0a9171911afb0
Gerrit-PatchSet: 8
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Review at https://gerrit.osmocom.org/6324
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increasing number of MS. This avoids overload at
startup time in cases where a lot of MS would discover the new
cell and try
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#2).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increasing number of
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#3).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#4).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#5).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#6).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#7).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6324
to look at the new patch set (#8).
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make the cell
available to an increas
Harald Welte has submitted this change and it was merged.
Change subject: Add support for Access Control Class ramping.
..
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make
17 matches
Mail list logo
