Patch Set 1:
> Would it make sense to try to port this to master?
No idea, but probably unrelated to the fix/patch. If the answer is yes, then
somebody can create an issue in redmine about it.
--
To view, visit https://gerrit.osmocom.org/6449
To unsubscribe, visit https://gerrit.osmocom.org/s
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/6406/3/bsc/BSC_Tests.ttcn
File bsc/BSC_Tests.ttcn:
Line 1244: testcase TC_rsl_unknown_unit_id() runs on test_CT {
> I think it makes sense t owrap those two into one function and call that fu
Yes, I was just being lazy and copy/pasted :)
Review at https://gerrit.osmocom.org/6452
fsm: allow graceful exit on FSM termination
The function _osmo_fsm_inst_term() terminates all child FSMs befor
it calls fi->fsm_cleanup(). This prevents the cleanup callback to
perform last actions on the child FSMs (e.g.
osmo_fsm_inst_unlink_parent()).
Patch Set 1:
I think we can introduce this. However, I'm not happy with the naming. First,
"grace" is different from "grace period" or "graceful" (think of "holy grace",
...). Second, I think it's not very indicative/explanatory of what is actually
happening. Withouht thinking too much abo
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5424/4/src/libmsc/a_iface_bssap.c
File src/libmsc/a_iface_bssap.c:
Line 313: memcpy(msg->l3h, TLVP_VAL(tp, GSM0808_IE_LAYER_3_INFORMATION),
msgb_l3len(msg));
I still don't get why we would want to copy the payload here
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6448
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6451
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d1951f4a5daf200e85c76fea14a35e952491d27
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6450
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I941cd7f4e9eec3e4f2786100a0e64770d5aee4a7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: libmsc: bssap: Fix typo in log message
..
libmsc: bssap: Fix typo in log message
Change-Id: I941cd7f4e9eec3e4f2786100a0e64770d5aee4a7
---
M src/libmsc/a_
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6449
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c81155c84fc35cff1704734fd8d2732235c5a4
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: jolly/testi
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22ebb76742e9c5ab9dd608ac089a5c558aceeb36
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6428
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f48924f484e4e4b98be4ca8bee253e6ea9c0576
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib524e49ec211662e0dfde8161495a72aa8ad76cf
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6431
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6e4e0e1eed3328fa25b3b90be376d532ad0e56b
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6432
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I344a3d07e146999e154824837ed95db2b9879356
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6433
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c9c8540419876696e65a690717144d497d60fb2
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6434
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie247bc492efb331871d970c56700595ad3f7e201
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6435
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6178061fa30c7e1a4c22c29d3c8f508b1033569f
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6437
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30e4b5dab9c6d761d20a3a0e5b9ec2d65e64ebc5
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6438
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8968787a5f0b078619264f0cb42349a9bc7943af
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6439
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6440
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie411c2ce8008accee54782a442d6361e50777a54
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6445
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6441
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f3a596f31762b48afed39a85a343c400826300f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6442
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3233f03580aa8c0ab178dfd33e68ecab5b9f042
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6443
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6444
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: eliminate talloc_ctx.c
..
libcommon: eliminate talloc_ctx.c
Interestingly enough, talloc_ctx_init() actually had not a single caller.
While d
Harald Welte has submitted this change and it was merged.
Change subject: ipaccess-proxy: don't redefine tall_bsc_ctx
..
ipaccess-proxy: don't redefine tall_bsc_ctx
Curiously, ipaccess-proxy.c is able to define its own tall_bsc
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: eliminate debug.c
..
libcommon: eliminate debug.c
Provide concise log categories for each main scope.
Move the complete log categories 1:1 to
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: eliminate socket.c
..
libcommon: eliminate socket.c
Replace calls to make_sock() with osmo_sock_init_ofd().
Shame on me for not testing every
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: eliminate bsc_version.c
..
libcommon: eliminate bsc_version.c
Move the copyright string into osmo_bsc_main.c. No other users of it exist.
Cha
Harald Welte has submitted this change and it was merged.
Change subject: drop libcommon completely, move remaining files to libbsc
..
drop libcommon completely, move remaining files to libbsc
Move gsm_data.c and handover_cfg.c
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: join gsm_data_shared.* into gsm_data.*
..
libcommon: join gsm_data_shared.* into gsm_data.*
The separation of gsm_data_shared.* from gsm_data.
Harald Welte has submitted this change and it was merged.
Change subject: libcommon: eliminate common_vty.c
..
libcommon: eliminate common_vty.c
Move bsc_vty_go_parent() to osmo_bsc_main.c and bsc_nat.c, and drop those nodes
th
Review at https://gerrit.osmocom.org/6453
Make osmo-pcu wait for BTS to become available at start-up time.
After the PCU socket becomes available, the BTS might send an
INFO_IND message with the 'ACTIVE' flag cleared. If this happens,
do not exit immediately, but keep retrying until an INFO_IND
Review at https://gerrit.osmocom.org/6454
re-organize configuration files; add tcpdump integration
Let's make sure we share common configuration between the test
suites and split the config file into a "default" part which is
used (but not copied) in the Docker images, and a "local" part
which
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6454
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3db452e24e5238aa05254d903739c64d202e61db
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: re-organize configuration files; add tcpdump integration
..
re-organize configuration files; add tcpdump integration
Let's make sure we share common conf
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6455
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a43b3e381405f3af30b3ffe04bc50e64ec66f57
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Review at https://gerrit.osmocom.org/6455
BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come active
We don't have a good way to make the BSSMAP code wait for the lower
SIGTRAN layers to be up and running. To avoid the RESET being
sent before the lower layers are up, introduce a sleep o
Harald Welte has submitted this change and it was merged.
Change subject: BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come
active
..
BSSMAP_Emulation: Sleep 1s to wait for M3UA/AS/ASP to come active
We don't have a g
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6453
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic42a5601a43b81d260721fef5d9fa52447f9d309
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: Make osmo-pcu wait for BTS to become available at start-up time.
..
Make osmo-pcu wait for BTS to become available at start-up time.
After the PCU socket
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6453/1/src/osmobts_sock.cpp
File src/osmobts_sock.cpp:
Line 288: osmo_timer_schedule(&state->timer, 5, 0);
Do we actually need to wait 5 seconds now that we can reeschedule it in case it
fails? we could this way speedup.
-
Review at https://gerrit.osmocom.org/6456
ggsn: Switch over to new shared/common configuration file layout
Change-Id: I491819c8bad8efa45cee161ea6f47c3f97941a17
---
M ggsn_tests/GGSN_Tests.cfg
A ggsn_tests/GGSN_Tests.default
2 files changed, 24 insertions(+), 29 deletions(-)
git pull ssh://g
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6456
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I491819c8bad8efa45cee161ea6f47c3f97941a17
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: maste
Harald Welte has submitted this change and it was merged.
Change subject: ggsn: Switch over to new shared/common configuration file layout
..
ggsn: Switch over to new shared/common configuration file layout
Change-Id: I491819c8
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-abis/Debian_9.0/aarch64
Package network:osmocom:nightly/libosmo-abis failed to build in
Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmo-abis
Last lines o
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcap/Debian_9.0/aarch64
Package network:osmocom:nightly/osmo-pcap failed to build in Debian_9.0/aarch64
Check out the package for editing:
osc checkout network:osmocom:nightly osmo-pcap
Last lines of build lo
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6438
to look at the new patch set (#4).
libcommon-cs: move gsm_network_init() into bsc_network_init()
Some part of the network init was common between libbsc and libmsc in the
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6439
to look at the new patch set (#4).
gsm_network: drop unused trans_list
Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360
---
M include/osmocom/bsc/gsm_data.h
M src/libb
Neels Hofmeyr has submitted this change and it was merged.
Change subject: gsm_network: drop unused subscr_epxire_timer
..
gsm_network: drop unused subscr_epxire_timer
Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9
---
M
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6442
to look at the new patch set (#4).
common_cs.h: mv gsm_encr to gsm_data.h
This leaves common_cs.h practically empty. Leave its removal to the next patch,
which removes lib
Neels Hofmeyr has submitted this change and it was merged.
Change subject: libcommon_cs: move gsm48 bits to libbsc
..
libcommon_cs: move gsm48 bits to libbsc
These functions were originally shared between libmsc and libbsc in t
Neels Hofmeyr has submitted this change and it was merged.
Change subject: gsm_network: drop unused trans_list
..
gsm_network: drop unused trans_list
Change-Id: I7910ce8098d5431e41409bf09429ae4221efb360
---
M include/osmocom/bs
Neels Hofmeyr has submitted this change and it was merged.
Change subject: common_cs.h: mv gsm_encr to gsm_data.h
..
common_cs.h: mv gsm_encr to gsm_data.h
This leaves common_cs.h practically empty. Leave its removal to the nex
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6437
to look at the new patch set (#4).
libcommon-cs: move a_reset.c into libbsc
a_reset.c was originally used by both libmsc and libbsc in the old openbsc.git
repository. Now
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6440
to look at the new patch set (#4).
libcommon_cs: move gsm48 bits to libbsc
These functions were originally shared between libmsc and libbsc in the old
openbsc.git; now osm
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6441
to look at the new patch set (#4).
libcommon-cs: move vty bits to libbsc/bsc_vty.c
The gsm_network VTY was partly shared between libmsc and libbsc in the old
openbsc.git;
Neels Hofmeyr has submitted this change and it was merged.
Change subject: libcommon-cs: move gsm_network_init() into bsc_network_init()
..
libcommon-cs: move gsm_network_init() into bsc_network_init()
Some part of the network
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6445
to look at the new patch set (#4).
gsm_network: drop unused subscr_epxire_timer
Change-Id: I2e34ffb35e244472f8bfc993facc8d6e130f10d9
---
M include/osmocom/bsc/gsm_data.h
1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: libcommon-cs: move vty bits to libbsc/bsc_vty.c
..
libcommon-cs: move vty bits to libbsc/bsc_vty.c
The gsm_network VTY was partly shared between libmsc
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6444
to look at the new patch set (#4).
drop unused common.h
Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f
---
M include/osmocom/bsc/Makefile.am
D include/osmocom/bsc/co
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6443
to look at the new patch set (#4).
drop libcommon-cs completely
Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9
---
M configure.ac
M include/osmocom/bsc/Makefile.am
M
Neels Hofmeyr has submitted this change and it was merged.
Change subject: drop unused common.h
..
drop unused common.h
Change-Id: I7cf4076d7e36ae71d88e70a86d5c2d0640c1146f
---
M include/osmocom/bsc/Makefile.am
D include/osmoco
Neels Hofmeyr has submitted this change and it was merged.
Change subject: drop libcommon-cs completely
..
drop libcommon-cs completely
Change-Id: I07d4a48af3154ee4d904686f230a51b8b8a94ff9
---
M configure.ac
M include/osmocom/b
Neels Hofmeyr has submitted this change and it was merged.
Change subject: libcommon-cs: move a_reset.c into libbsc
..
libcommon-cs: move a_reset.c into libbsc
a_reset.c was originally used by both libmsc and libbsc in the old
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6416
to look at the new patch set (#4).
remove unused "authorized-regexp" VTY command
This is another left-over VTY command from the OsmoNITB days.
If such functionality is desired, it must
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6417
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I825e659da529257e5edec94d9d59f0e10c1b4c63
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6416
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0897c47388e49ba7886b55acc728a6f7d213fe
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6423
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit
Harald Welte has submitted this change and it was merged.
Change subject: remove unused "auth policy" VTY command
..
remove unused "auth policy" VTY command
This is yet another unsused bit from the OsmoNITB legacy.
Related: OS
Harald Welte has submitted this change and it was merged.
Change subject: remove dead code (gsm_parse_reg)
..
remove dead code (gsm_parse_reg)
Change-Id: I47b0260561a9c2bad65c50c8164873e4c23d61b7
---
M include/osmocom/msc/gsm_d
Harald Welte has submitted this change and it was merged.
Change subject: remove unused "authorized-regexp" VTY command
..
remove unused "authorized-regexp" VTY command
This is another left-over VTY command from the OsmoNITB da
Neels Hofmeyr has abandoned this change.
Change subject: temp dev: make osmo-bsc_nat compile
..
Abandoned
this one shouldn't have been submitted
--
To view, visit https://gerrit.osmocom.org/6427
To unsubscribe, visit https://
Neels Hofmeyr has abandoned this change.
Change subject: HO: Implement load based handover, as handover_decision_2.c
..
Abandoned
being split in smaller patches, soon to be resubmitted
--
To view, visit https://gerrit.osmocom
Neels Hofmeyr has abandoned this change.
Change subject: HO: intra-cell assignment: always use Handover Command, not
Assignment
..
Abandoned
the new version of ho2 patches will refrain from modifying this in the first
place
Patch Set 1: Verified+1
--
To view, visit https://gerrit.osmocom.org/6384
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5
Gerrit-PatchSet: 1
Gerrit-Project: gapk
Gerrit-Branch: master
Gerrit-Owner:
Max has submitted this change and it was merged.
Change subject: Add basic CI integration
..
Add basic CI integration
Change-Id: Ib4b36df8f010cd7e035fe5a8b846632541b655f5
---
A contrib/jenkins.sh
1 file changed, 42 insertions(+
Review at https://gerrit.osmocom.org/6447
templates: osmo-msc: Remove unused option auth policy
Commit osmo-msc 098aa71e83a86200a18088927b4753909f5ed518 removes this
option from default configuration as it is really not used in osmo-msc,
it comes from osmo-nitb times.
Change-Id: I928379ebabfc7
Review at https://gerrit.osmocom.org/6446
templates: osmo-msc: Remove unused option reject cause
Commit osmo-msc 27b40c601c41fde70446ad553629494234c07662 removes this
option from default configuration as it is really not used in osmo-msc,
it comes from osmo-nitb times.
Change-Id: Iac1948113514
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6428
to look at the new patch set (#3).
libcommon: eliminate bsc_version.c
Move the copyright string into osmo_bsc_main.c. No other users of it exist.
Change-Id: I7f48924f484e4e4b98be4ca8be
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6447
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I928379ebabfc776f33b9f345d92a7a4a533fe25f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: templates: osmo-msc: Remove unused option auth policy
..
templates: osmo-msc: Remove unused option auth policy
Commit osmo-msc 098aa71e83a86200a18088
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6446
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac1948113514414e7573f3bbfb3ce82e6c49adb6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: templates: osmo-msc: Remove unused option reject cause
..
templates: osmo-msc: Remove unused option reject cause
Commit osmo-msc 27b40c601c41fde70446
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6429
to look at the new patch set (#3).
libcommon: eliminate common_vty.c
Move bsc_vty_go_parent() to osmo_bsc_main.c and bsc_nat.c, and drop those nodes
that aren't used in the respective m
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6440
to look at the new patch set (#3).
libcommon_cs: move gsm48 bits to libbsc
These functions were originally shared between libmsc and libbsc in the old
openbsc.git; now osmo-bsc.git has
Review at https://gerrit.osmocom.org/6448
libmsc: bssap: Catch TLV parse failures
Change-Id: I6aef9a94fa5b2e0b62a9c1744b8e18e5985f788f
---
M src/libmsc/a_iface_bssap.c
1 file changed, 49 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/48/6448/1
d
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6436
to look at the new patch set (#4).
drop libcommon completely
Change-Id: Ifa3486f04cdd5fda1e92630dfc1a5f670773bc14
---
M configure.ac
M src/Makefile.am
M src/ipaccess/Makefile.am
D src/l
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6435
to look at the new patch set (#4).
libcommon: move remaining files to libbsc
Move gsm_data.c and handover_cfg.c to libbsc, where they belong.
This leaves libcommon utterly empty, and i
Patch Set 1:
> Patch Set 1: Code-Review+2
Harald? This change isn't ready I think.
--
To view, visit https://gerrit.osmocom.org/6383
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8
Gerrit-PatchSe
Patch Set 1:
> Must be leftover from earlier compilation.
Shouldn't be here now.
--
To view, visit https://gerrit.osmocom.org/6383
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8
Gerrit-PatchSet:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6435
to look at the new patch set (#5).
drop libcommon completely, move remaining files to libbsc
Move gsm_data.c and handover_cfg.c to libbsc, where they belong.
This leaves libcommon utte
Neels Hofmeyr has abandoned this change.
Change subject: drop libcommon completely
..
Abandoned
merged with previous patch ("libcommon: move remaining files to libbsc") as an
easy way out of the hundredth build failure which I
Hello Vadim Yanitskiy, Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6383
to look at the new patch set (#2).
Ignore build products
Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8
---
M .gitignore
1 file changed, 1 insertion(+), 0 deletions(
Hello Vadim Yanitskiy, Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6383
to look at the new patch set (#3).
Ignore build products
Change-Id: I24be6fdbd17c7877d7a9a87081107dc5a3cd2fe8
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions
Patch Set 1: Code-Review-1
(1 comment)
Sorry, I think it's ugly to have the same code copy+pasted everywhere. Can't
we simply do the TLV parsing at a common/shared point and hand the
already-parsed tlv_parsed into the indiividual functions? This way there's
reduction of code duplication and
Review at https://gerrit.osmocom.org/6449
transceiver: Fix RSP SETSLOT format
According to osmo-trx README:
SETSLOT sets the format of the uplink timeslots in the ARFCN.
The indicates the timeslot of interest.
The indicates the type of channel that occupies the timeslot.
A chantype of zero in
1 - 100 of 112 matches
Mail list logo
