Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-01 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/ --- Review request for giraph. Summary --- * Changed Vertex.java to HashMapVert

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/#review4168 --- Had a quick look over your changes and everything looked good. I think

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Avery Ching
> On 2012-01-02 11:04:25, Sebastian Schelter wrote: > > Had a quick look over your changes and everything looked good. I think it's > > right to assume that most implementations will use static graphs and to > > offer EdgeListVertex as the default extension point for this. The only > > thing I

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Sebastian Schelter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/#review4170 --- Ship it! Ok, I understood this wrong. I'm fine with the changes then.

Re: Review Request: Make EdgeListVertex the default vertex implementation, fix bugs related to EdgeListVertex.

2012-01-02 Thread Avery Ching
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3349/ --- (Updated 2012-01-02 18:51:05.007864) Review request for giraph. Changes --