Re: [RFC] Add basic syntax check on shell scripts

2012-12-05 Thread Sebastian Schuberth
On 2012/12/04 20:39 , Junio C Hamano wrote: A few more things in addition to what Torsten's script attempts to catch that we would want to catch are: [...] > * Do not write ERE with backslashes and expect "grep" to grok them; > that's GNUism. e.g. > >grep "^\(author\|committer\) "

Exploiting SHA1's "XOR weakness" allows for faster hash calculation

2012-12-05 Thread Sebastian Schuberth
Hi, to say it in advance: I do not want to trigger any bogus security discussion here. Instead, I believe the findings from [1] allow for an up to 20% faster SHA1 calculation, if my brief reading of the presentation is correct. Any opinions on integration this optimization into Git? [1] htt

Re: Exploiting SHA1's "XOR weakness" allows for faster hash calculation

2012-12-05 Thread Marko Kreen
On Wed, Dec 5, 2012 at 11:19 AM, Sebastian Schuberth wrote: > to say it in advance: I do not want to trigger any bogus security discussion > here. Instead, I believe the findings from [1] allow for an up to 20% faster > SHA1 calculation, if my brief reading of the presentation is correct. Any > op

[PATCH v3 1/4] git-svn: Document branches with at-sign(@).

2012-12-05 Thread Sebastian Leske
git svn sometimes creates branches with an at-sign in the name (branchname@revision). These branches confuse many users and it is a FAQ why they are created. Document when git svn creates them. Signed-off-by: Sebastian Leske --- Documentation/git-svn.txt | 47 ++

[PATCH v3 0/4] git-svn: More docs for branch handling

2012-12-05 Thread Sebastian Leske
Updated version of my documentation patch for git-svn. Thanks to Junio C Hamano for pointing out improvements. Sebastian Leske (4): git-svn: Document branches with at-sign(@). git-svn: Recommend use of structure options. git-svn: Expand documentation for --follow-parent git-svn: Note about

[PATCH v3 2/4] git-svn: Recommend use of structure options.

2012-12-05 Thread Sebastian Leske
Document that when using git svn, one should usually either use the directory structure options to import branches as branches, or only import one subdirectory. The default behaviour of cloning all branches and tags as subdirectories in the working copy is usually not what the user wants. Signed-o

[PATCH v3 3/4] git-svn: Expand documentation for --follow-parent

2012-12-05 Thread Sebastian Leske
Describe what the option --follow-parent does, and what happens if it is set or unset. Signed-off-by: Sebastian Leske --- Documentation/git-svn.txt | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt index d

[PATCH v3 4/4] git-svn: Note about tags.

2012-12-05 Thread Sebastian Leske
Document that 'git svn' will import SVN tags as branches. Signed-off-by: Sebastian Leske --- Documentation/git-svn.txt |6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt index 021fb0e..445b033 100644 --- a/Documentation/git-svn.txt

Re: [RFC/PATCH 1/2] reset: learn to reset to tree

2012-12-05 Thread Martin von Zweigbergk
On Tue, Dec 4, 2012 at 9:46 PM, Junio C Hamano wrote: > Martin von Zweigbergk writes: > >> More importantly, when is it desirable not to delete deleted entries? > > When I am trying to check out contents of Documentation/ directory > as of an older edition because we made mistakes updating the fi

Re: remote-testsvn: Hangs at revision

2012-12-05 Thread David Michael Barr
On Wednesday, 5 December 2012 at 5:20 PM, Ramkumar Ramachandra wrote: > Hi, > > I tried out the testsvn remote helper on a simple Subversion > repository, but it seems to hang at Revision 8 indefinitely without > any indication of progress. I'm currently digging in to see what went > wrong. The re

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Erik Faye-Lund
Sorry for a late reply. On Tue, Dec 4, 2012 at 5:35 PM, Johannes Schindelin wrote: > Hi kusma, > > On Tue, 4 Dec 2012, Erik Faye-Lund wrote: > >> in ab1a11be ("mingw_rmdir: set errno=ENOTEMPTY when appropriate"), >> a check was added to prevent us from retrying to delete a directory >> that is bo

Re: [PATCH v2] gitk: read and write a repository specific configuration file

2012-12-05 Thread Marc Branchaud
On 12-12-04 07:49 PM, Łukasz Stelmach wrote: > Enable gitk read and write repository specific configuration > file: ".git/k" if the file exists. To make gitk use the local > file simply create one, e.g. with the touch(1) command. > > This is very useful if one uses different views for different >

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Johannes Schindelin
Hi kusma, On Wed, 5 Dec 2012, Erik Faye-Lund wrote: > Sorry for a late reply. Yeah, sorry, my replies tend to be delayed a lot. For the record: your reply was not at all late. > On Tue, Dec 4, 2012 at 5:35 PM, Johannes Schindelin > wrote: > > > > On Tue, 4 Dec 2012, Erik Faye-Lund wrote: > > >

Re: [RFC] Add basic syntax check on shell scripts

2012-12-05 Thread Junio C Hamano
Jeff King writes: > You would want a "check shell script portability" script, and you would > probably want to run it: > > - on the regular built scripts; possibly during build time (I have done > this before with "perl -c" for perl scripts and it is reasonably > successful). Or in a te

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Erik Faye-Lund
On Wed, Dec 5, 2012 at 5:02 PM, Johannes Schindelin wrote: > Hi kusma, > > On Wed, 5 Dec 2012, Erik Faye-Lund wrote: > >> Sorry for a late reply. > > Yeah, sorry, my replies tend to be delayed a lot. For the record: your > reply was not at all late. > >> On Tue, Dec 4, 2012 at 5:35 PM, Johannes Sc

Re: git-svn with non-standard repository layout

2012-12-05 Thread Piotr Krukowiecki
On Tue, Dec 4, 2012 at 10:19 PM, Carsten Fuchs wrote: > Hi Piotr, > > Am 2012-12-04 18:29, schrieb Piotr Krukowiecki: > >> Is there a way to handle svn repository with following layout? >> >> repo/trunk >> repo/branches/branch1 >> repo/branches/branch2 >> repo/branches/work/developer1/branch3 >> r

Re: git-svn with non-standard repository layout

2012-12-05 Thread Stephen Bash
- Original Message - > From: "Piotr Krukowiecki" > Sent: Wednesday, December 5, 2012 11:26:54 AM > Subject: Re: git-svn with non-standard repository layout > > On Tue, Dec 4, 2012 at 10:19 PM, Carsten Fuchs > wrote: > > Hi Piotr, > > > > Am 2012-12-04 18:29, schrieb Piotr Krukowiecki: >

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Junio C Hamano
Erik Faye-Lund writes: > On Wed, Dec 5, 2012 at 5:02 PM, Johannes Schindelin > wrote: > ... > Since we're justifying the approaches, I'd like to explain why I > preferred the return approach: it performs less tests. While this > might sound like premature optimizations, performance is not why I

Re: Exploiting SHA1's "XOR weakness" allows for faster hash calculation

2012-12-05 Thread Theodore Ts'o
On Wed, Dec 05, 2012 at 10:19:43AM +0100, Sebastian Schuberth wrote: > > to say it in advance: I do not want to trigger any bogus security > discussion here. Instead, I believe the findings from [1] allow for > an up to 20% faster SHA1 calculation, if my brief reading of the > presentation is corr

Re: [ANNOUNCE] Git v1.8.1-rc0

2012-12-05 Thread Ramsay Jones
Junio C Hamano wrote: > A release candidate preview, Git v1.8.1-rc0, is now available for > testing at the usual places. > > This cycle has been a bit slow (perhaps because it had a major US > holiday to slow people down) but we seem to have managed to apply > reasonably large number of usability

Re: [ANNOUNCE] Git v1.8.1-rc0

2012-12-05 Thread Junio C Hamano
Ramsay Jones writes: > I fetch git from 'git://git.kernel.org/pub/scm/git/git.git' which has > commit ee26a6e2 ("Git 1.8.1-rc0", 03-12-2012), but is missing the v1.8.1-rc0 > tag. Is this just an oversight ... Thanks for letting me know; forgot to push out the tag. -- To unsubscribe from this l

Re: [PATCH v3 1/4] git-svn: Document branches with at-sign(@).

2012-12-05 Thread Junio C Hamano
Sebastian Leske writes: > git svn sometimes creates branches with an at-sign in the name > (branchname@revision). These branches confuse many users and it is a FAQ > why they are created. Document when git svn creates them. > > Signed-off-by: Sebastian Leske > --- > Documentation/git-svn.txt |

[PATCH] Perform minimal stat comparison when some stat fields are not set

2012-12-05 Thread Robin Rosenberg
At least JGit does sets uid, gid, ctime, ino and dev fields to zero on update. To Git this looks like the stat data does not match and a full file compare will be forced even it size and mtime match. This is in practice unnecessary. Sense JGit's presence by checking if ino and dev is zero. Signed-

Re: [PATCH v3 1/4] git-svn: Document branches with at-sign(@).

2012-12-05 Thread Eric Wong
Junio C Hamano wrote: > Sebastian Leske writes: > > --- > > Documentation/git-svn.txt | 47 > > + > > 1 file changed, 47 insertions(+) > > Thanks. Your hunk header says that there should be 53 lines in the > postimage, but there actually are only

[PATCH] Add directory pattern matching to attributes

2012-12-05 Thread Jean-Noël AVILA
The manpage of gitattributes says: "The rules how the pattern matches paths are the same as in .gitignore files" and the gitignore pattern rules has a pattern ending with / for directory matching. This rule is specifically relevant for the 'export-ignore' rule used for git archive. Signed-off-by:

[PATCH] Add directory pattern matching to attributes

2012-12-05 Thread Jean-Noël AVILA
The manpage of gitattributes says: "The rules how the pattern matches paths are the same as in .gitignore files" and the gitignore pattern rules has a pattern ending with / for directory matching. This rule is specifically relevant for the 'export-ignore' rule used for git archive. Signed-off-by:

Re: git-svn with non-standard repository layout

2012-12-05 Thread Piotr Krukowiecki
On Wed, Dec 5, 2012 at 5:44 PM, Stephen Bash wrote: > - Original Message - >> From: "Piotr Krukowiecki" >> Sent: Wednesday, December 5, 2012 11:26:54 AM >> Subject: Re: git-svn with non-standard repository layout >> >> On Tue, Dec 4, 2012 at 10:19 PM, Carsten Fuchs >> wrote: >> > Hi Piot

[PATCH] RFC Optionally handle symbolic links as copies

2012-12-05 Thread Robin Rosenberg
If core.symlinks is set to copy then symbolic links in a git repository will be checked out as copies of the file it points to. This allows repos containing symbolic links to not only be checked out, but also that the linked content may be used on OS:es and filesystems that do not support symbolic

Re: [PATCH] Add directory pattern matching to attributes

2012-12-05 Thread Junio C Hamano
"Jean-Noël AVILA" writes: > -static void prepare_attr_stack(const char *path) > +static void prepare_attr_stack(const char *path, unsigned mode) > { > struct attr_stack *elem, *info; > int dirlen, len; > @@ -645,28 +645,43 @@ static void prepare_attr_stack(const char *path) > } Why

Re: [PATCH] Perform minimal stat comparison when some stat fields are not set

2012-12-05 Thread Junio C Hamano
Robin Rosenberg writes: > At least JGit does sets uid, gid, ctime, ino and dev fields to zero > on update. To Git this looks like the stat data does not match and > a full file compare will be forced even it size and mtime match. This > is in practice unnecessary. Sense JGit's presence by checkin

Re: Millisecond precision in timestamps?

2012-12-05 Thread Robin Rosenberg
- Ursprungligt meddelande - > On Tue, Nov 27, 2012 at 11:58 PM, Eric S. Raymond > wrote: > > Junio C Hamano : > >> Roundtrip conversions may benefit from sub-second timestamps, but > >> personally I think negative timestamps are more interesting and of > >> practical use. > > > > You mea

Re: [PATCH] RFC Optionally handle symbolic links as copies

2012-12-05 Thread Junio C Hamano
Robin Rosenberg writes: > If core.symlinks is set to copy then symbolic links in a git repository > will be checked out as copies of the file it points to. That all sounds nice on surface when the primary thing you care about is to fetch and check out other people's code and extract it to the wo

Re: git-svn with non-standard repository layout

2012-12-05 Thread Stephen Bash
- Original Message - > From: "Piotr Krukowiecki" > Sent: Wednesday, December 5, 2012 5:19:44 PM > Subject: Re: git-svn with non-standard repository layout > > Do you mean something like > >branches = branches/work/*/*:refs/remotes/work/* >branches = branches/{branch1,branch2}:ref

Re: Stitching histories of several repositories

2012-12-05 Thread Robin Rosenberg
- Ursprungligt meddelande - > Hi, > > I've written a tool to stitch the first-parent histories of several > git repositories. To illustrate, consider that we have a toplevel > git > repository inside which the other repositories reside. > [...] > > I'd like to know whether the tool wo

Thioth gnu phone log

2012-12-05 Thread Robin Rochelle Smith Chiodo
Data calls texts from 901-948-3388 sent to 901-270-6223 screen shots Sent from my iPhone Robin Chiodo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Perform minimal stat comparison when some stat fields are not set

2012-12-05 Thread Robin Rosenberg
- Ursprungligt meddelande - > Robin Rosenberg writes: > > > At least JGit does sets uid, gid, ctime, ino and dev fields to zero > > on update. To Git this looks like the stat data does not match and > > a full file compare will be forced even it size and mtime match. > > This > > is in

Re: [PATCH] RFC Optionally handle symbolic links as copies

2012-12-05 Thread Robin Rosenberg
- Ursprungligt meddelande - > Robin Rosenberg writes: > > > If core.symlinks is set to copy then symbolic links in a git > > repository > > will be checked out as copies of the file it points to. > > That all sounds nice on surface when the primary thing you care > about is to fetch an

Please pull l10n updates for 1.8.1 round 2

2012-12-05 Thread Jiang Xin
Hi, Junio The following changes since commit f94c3251e1400c3cf349f7f84fea4db66b540113: Update draft release notes to 1.8.1 (2012-11-29 13:57:09 -0800) are available in the git repository at: git://github.com/git-l10n/git-po master for you to fetch changes up to 77cc392d6d60c5d22930174904ad

Re: [PATCH] RFC Optionally handle symbolic links as copies

2012-12-05 Thread Johannes Sixt
Am 12/5/2012 23:46, schrieb Robin Rosenberg: > - git status - when do we report a diff. > - After checkout we should probably not Are you saying that it should be ignored that the index records a symbolic link, but the worktree contains a regular file and that the regular file does not even

Re: [PATCH] Perform minimal stat comparison when some stat fields are not set

2012-12-05 Thread Johannes Sixt
Am 12/6/2012 2:09, schrieb Robin Rosenberg: >> Robin Rosenberg writes: >>> At least JGit does sets uid, gid, ctime, ino and dev fields to zero >>> on update. To Git this looks like the stat data does not match and >>> a full file compare will be forced even it size and mtime match. >>> This >>> is