Re: [PATCH] add: Use struct argv_array in run_add_interactive()

On Sun, Mar 16, 2014 at 7:42 AM, Thomas Rast wrote: > Fabian Ruch writes: > >> run_add_interactive() in builtin/add.c manually computes array bounds >> and allocates a static args array to build the add--interactive command >> line, which is error-prone. Use the argv-array helper functions instea

Re: [PATCH] gitweb: Fix the author initials in blame for non-ASCII names

Dear all, I have a git-project which source code use gbk encoding. When use gitweb blame view, it will report an error then stop parse: >Malformed UTF-8 character (fatal) at /usr/share/gitweb/gitweb.cgi line > 1595, <$fd> line 45. After apply this patch, blame view of gbk source file will ba

Re: [PATCH] Rewrite the diff-no-index.c

Thanks for the resubmission. Comments below... On Sun, Mar 16, 2014 at 8:44 AM, wrote: > From: 沈承恩 > Subject: [PATCH] Rewrite the diff-no-index.c This is your second version of the patch, so you should say [PATCH v2]. Most patches rewrite something, so "rewrite" in the subject does not convey

Re: [PATCH] branch.c: simplify chain of if statements

Thanks for the submission. Comments below to give you a taste of the Git review process... On Sun, Mar 16, 2014 at 5:22 PM, Dragos Foianu wrote: > This patch uses a table-driven approach in order to make the code > cleaner. In fact, this change is not table-driven (emphasis on *driven*). It mere

Re: [PATCH] branch.c: simplify chain of if statements

On Mon, Mar 17, 2014 at 3:23 AM, Matthieu Moy wrote: > Dragos Foianu writes: > >> + const char *verbose_prints[4] = { >> + "Branch %s set up to track remote branch %s from %s%s", >> + "Branch %s set up to track local branch %s%s", >> + "Branch %s set up to

Re: [PATCH/GSoC_v3] branch.c: turn nested if-else logic to table-driven

On Sun, Mar 16, 2014 at 2:08 AM, Yao Zhao wrote: > Signed-off-by: Yao Zhao > --- > branch.c | 53 + > 1 file changed, 29 insertions(+), 24 deletions(-) > Hello Eric, > > Thank you and Junio for reviewing my code. It is really helpful to improve

[PATCH] fixup! Documentation/git-am: Document supported --patch-format options

--- On 17/03/14 20:35, Chris Packham wrote:> On 17/03/14 19:39, Junio C Hamano wrote: >> Chris Packham writes: >> >>> Ping? >> >> Hasn't it been already cooking in 'next' for a few days? >> > > Indeed I think I missed a "What's cooking". Do you want me to submit a > fixup for the spelling mistak

Re: [PATCH] Documentation/git-am: Document supported --patch-format options

On 17/03/14 19:39, Junio C Hamano wrote: > Chris Packham writes: > >> Ping? > > Hasn't it been already cooking in 'next' for a few days? > Indeed I think I missed a "What's cooking". Do you want me to submit a fixup for the spelling mistake? -- To unsubscribe from this list: send the line "uns

Re: [PATCH] GSoC Change multiple if-else statements to be table-driven

Eric Sunshine writes: > Perhaps it is time to mark this microproject as "taken" on the GSoC > page [2], along a fews others for which we have received multiple > submissions. > > [2]: > https://github.com/git/git.github.io/blob/master/SoC-2014-Microprojects.md I actually have been of multiple m

Re: [PATCH] branch.c: simplify chain of if statements

Dragos Foianu writes: > + const char *verbose_prints[4] = { > + "Branch %s set up to track remote branch %s from %s%s", > + "Branch %s set up to track local branch %s%s", > + "Branch %s set up to track remote ref %s%s", > + "Branch %s set up to

<    1   2