Re: t5570 trap use in start/stop_git_daemon

2015-02-13 Thread Joachim Schmitz
Jeff King peff.net> writes: > > On Fri, Feb 13, 2015 at 02:44:03AM -0500, Jeff King wrote: > > > On Thu, Feb 12, 2015 at 03:31:12PM -0500, Randall S. Becker wrote: > > > Hmm, today I learned something new about ksh. Apparently when you use > the "function" keyword to define a function like:

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-11 Thread Joachim Schmitz
Sorry to be a pain, but i think this sententence neede mending + * to override this, if the definition of SSIZE_MAX platform is broken. Bye, Jojo

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-11 Thread Joachim Schmitz
Joachim Schmitz schmitz-digital.de> writes: > > Junio C Hamano pobox.com> writes: > > > > OK, then let's do this. > > Except for the type "taht" -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a mess

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-11 Thread Joachim Schmitz
Junio C Hamano pobox.com> writes: > OK, then let's do this. > Yep, that'd do, thanks. bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-08 Thread Joachim Schmitz
Junio C Hamano pobox.com> writes: > > > > something like this: > > > > /* allow overwriting from e.g. Makefile */ > > #if !defined(MAX_IO_SIZE) > > # define MAX_IO_SIZE (8*1024*1024) > > #endif > > /* for plattforms that have SSIZE and have it smaller */ > > #if defined(SSIZE_MAX && (SSIZE_MAX <

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Junio C Hamano pobox.com> writes: > > On Sat, Feb 7, 2015 at 12:32 PM, Torsten Bögershausen web.de> wrote: > > I don't know every platform of the planet well enough to be helpful here, > > especially the ones which don't follow all the specifications. > > > > In other words: As long as we can

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Joachim Schmitz schmitz-digital.de> writes: > and as a (rather strange) > consequence mmap() (from compat/mmap.c) fails with EACCESS (why EACCESS?), > because xpread() returns something > 0. Seems mmap() should either set errno to EINVAL or not set it at all an just &#x

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Randall S. Becker nexbridge.com> writes: > > On 2015-02-07 13:07PM Randall S. Becker wrote: > >On 2015-02-07 12:30PM Torsten Bögershausen wrote: > >>On 2015-02-07 17.45, Joachim Schmitz wrote: > Although I do agree with Jojo, that MAX_IO_SIZE seems to be a platfo

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Joachim Schmitz schmitz-digital.de> writes: > > Torsten Bögershausen web.de> writes: > > > > > On 2015-02-07 17.45, Joachim Schmitz wrote: > b) never ever should read() be asked to read more than SSIZE_MAX, this > should be true for every platform on th

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Torsten Bögershausen web.de> writes: > > On 2015-02-07 17.45, Joachim Schmitz wrote: > > How about changing wrapper.c like this: > > #ifndef MAX_IO_SIZE > #define MAX_IO_SIZE (8*1024*1024) > #endif > - > and to change config.mak.unam

Re: read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Joachim Schmitz schmitz-digital.de> writes: > because xpread() returns something > 0. something < 0 of course (presumably -1)... bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More m

read() MAX_IO_SIZE bytes, more than SSIZE_MAX?

2015-02-07 Thread Joachim Schmitz
Hi there While investigating the problem with hung git-upload-pack we think to have found a bug in wrapper.c: #define MAX_IO_SIZE (8*1024*1024) This is then used in xread() to split read()s into suitable chunks. So far so good, but read() is only guaranteed to read as much as SSIZE_MAX bytes a

hang in git-upload-pack

2015-02-07 Thread Joachim Schmitz
Hi there In HP-Nonstop we're experiencing hangs in git-upload-pack, which seems to be the result of reads from / writes to pipes don't ever finish or don't get interrupted properly (SIGPIPE, SIGCHLD?) Any idea why that might be and how to fix it? bye, Jojo -- To unsubscribe from this list:

RE: [PATCH 1/2] sequencer: trivial fix

2013-05-29 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Wednesday, May 29, 2013 1:30 PM > To: 'Felipe Contreras' > Cc: 'git@vger.kernel.org' > Subject: RE: [PATCH 1/2] sequencer: trivial fix > > And for the record: I agree with you that these 2 t

RE: [PATCH 1/2] sequencer: trivial fix

2013-05-29 Thread Joachim Schmitz
> From: Felipe Contreras [mailto:felipe.contre...@gmail.com] > Sent: Wednesday, May 29, 2013 1:24 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH 1/2] sequencer: trivial fix > > On Wed, May 29, 2013 at 6:13 AM, Joachim Schmitz > wrote: >

RE: [PATCH 1/2] sequencer: trivial fix

2013-05-29 Thread Joachim Schmitz
> From: Felipe Contreras [mailto:felipe.contre...@gmail.com] > Sent: Wednesday, May 29, 2013 12:52 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH 1/2] sequencer: trivial fix > > On Wed, May 29, 2013 at 4:58 AM, Joachim Schmitz > wrote: &g

Re: [PATCH 1/2] sequencer: trivial fix

2013-05-29 Thread Joachim Schmitz
Felipe Contreras wrote: Junio C Hamano wrote: Neil Horman writes: On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote: We should free objects before leaving. Signed-off-by: Felipe Contreras --- sequencer.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --g

Re: [PATCH 2/2] cherry-pick: add --skip-commits option

2013-05-28 Thread Joachim Schmitz
Felipe Contreras wrote: Pretty much what it says on the tin. Only that it add --skip-empty and not --skip-commit ?!? Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.

2013-05-28 Thread Joachim Schmitz
Stefano Lattarini wrote: On 05/26/2013 10:05 PM, Stefan Beller wrote: Reported by cppcheck. Signed-off-by: Stefan Beller --- fast-import.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fast-import.c b/fast-import.c index 5f539d7..0142e3a 100644 --- a/fast-import.c +++ b/

Re: [PATCH v2 11/13] remote-hg: force remote push

2013-04-04 Thread Joachim Schmitz
Jed Brown wrote: Felipe Contreras writes: On Thu, Apr 4, 2013 at 2:48 PM, Jed Brown wrote: ... We have to assume that every Git (remote-hg) User is dealing with Hg Team No, we don't. Really? If there is no Hg Team, why bother with an Hg upstream? Huh? the counterpart of "every user"

Re: [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings

2013-03-21 Thread Joachim Schmitz
Joachim Schmitz wrote: Johannes Sixt wrote: Am 3/21/2013 12:03, schrieb Jeff King: I was fooling around with clang and noticed that it complains about the "int x = x" construct under -Wall. That is IMHO a deficiency in clang, since the idiom has a well-defined use in silencing -Wuni

Re: [PATCH 0/4] drop some "int x = x" hacks to silence gcc warnings

2013-03-21 Thread Joachim Schmitz
Johannes Sixt wrote: Am 3/21/2013 12:03, schrieb Jeff King: I was fooling around with clang and noticed that it complains about the "int x = x" construct under -Wall. That is IMHO a deficiency in clang, since the idiom has a well-defined use in silencing -Wuninitialized warnings. IMO, that's a

Re: how to check pending commits to be pushed?

2013-02-28 Thread Joachim Schmitz
Patricia Bittencourt Egeland wrote: Hi, Does someone know how to identify pending commits to be pushed in a local super repository (with quite some submodules), with git-1.6.5-1 ? git status ? Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a

Re: [PATCH v2 0/4] Auto-generate mergetool lists

2013-01-29 Thread Joachim Schmitz
John Keeping wrote: On Mon, Jan 28, 2013 at 01:50:19PM -0800, Junio C Hamano wrote: What are the situations where a valid user-defined tools is unavailable, by the way? The same as a built-in tool: the command isn't available. Currently I'm extracting the command word using: cmd=$(eval --

Re: [PATCH] l10n: de.po: translate 11 new messages

2013-01-28 Thread Joachim Schmitz
Ralf Thielow wrote: Translate 11 new messages came from git.pot update in 46bc403 (l10n: Update git.pot (11 new, 7 removed messages)). Signed-off-by: Ralf Thielow --- po/de.po | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/po/de.po b

Re: [PATCHv2] l10n: de.po: fix some minor issues

2013-01-22 Thread Joachim Schmitz
Ralf Thielow wrote: This fixes some minor issues and improves the German translation a bit. The following things were changed: - use complete sentences in option related messages - translate "use" consistently as "verwendet" - don't translate "make sense" as "macht Sinn" While your translations

Re: [PATCH v3 0/2] Make git-svn work with gitdir links

2013-01-21 Thread Joachim Schmitz
Junio C Hamano wrote: Barry Wardell writes: These patches fix a bug which prevented git-svn from working with repositories which use gitdir links. Changes since v2: - Rebased onto latest master. - Added test case which verifies that the problem has been fixed. - Fixed problems with git svn

Re: [PATCH 1/2] Change old system name 'GIT' to 'Git'

2013-01-20 Thread Joachim Schmitz
Junio C Hamano wrote: David Aguilar writes: On Sat, Jan 19, 2013 at 1:59 AM, Thomas Ackermann wrote: @@ -55,7 +55,7 @@ History Viewers - *gitweb* (shipped with git-core) - GITweb provides full-fledged web interface for GIT repositories. + GITweb provides full-fledged web interface

Re: erratic behavior commit --allow-empty

2013-01-16 Thread Joachim Schmitz
Jan Engelhardt wrote: On Tuesday 2012-10-02 10:26, Johannes Sixt wrote: Note that git commit -m A --allow-empty *DID* create a commit. Only, that it received the same name (SHA1) as the commit you created before it because it had the exact same contents (files, parents, author, committer, and t

Re: [PATCH] archive-tar: fix sanity check in config parsing

2013-01-14 Thread Joachim Schmitz
Jeff King wrote: On Sun, Jan 13, 2013 at 06:42:01PM +0100, René Scharfe wrote: When parsing these config variable names, we currently check that the second dot is found nine characters into the name, disallowing filter names with a length of five characters. Additionally, git archive crashes w

Re: Test failures with python versions when building git 1.8.1

2013-01-02 Thread Joachim Schmitz
Jeff King wrote: On Tue, Jan 01, 2013 at 11:18:46PM -0800, Junio C Hamano wrote: Jeff King writes: [1] This symlink is doubly wrong, because any use of symbolic links in the test scripts needs to depend on the SYMLINKS prereq, and this does not. Yeah, I think we have discussed this

RE: Python version auditing followup

2012-12-21 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Friday, December 21, 2012 7:28 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: Python version auditing followup > > "Joachim Schmitz" writes: > > >> > We have a workin

RE: Python version auditing followup

2012-12-20 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Thursday, December 20, 2012 10:39 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: Python version auditing followup > > "Joachim Schmitz" writes: > > > Junio C Hamano wrote: >

Re: Python version auditing followup

2012-12-20 Thread Joachim Schmitz
Junio C Hamano wrote: e...@thyrsus.com (Eric S. Raymond) writes: That was the first of three patches I have promised. In order to do the next one, which will be a development guidelines recommend compatibility back to some specific version X, I need a policy decision. How do we set X? I don'

Re: [PATCH] mergetools/p4merge: Honor $TMPDIR for the /dev/null placeholder

2012-12-20 Thread Joachim Schmitz
Junio C Hamano wrote: David Aguilar writes: Use mktemp to create the /dev/null placeholder for p4merge. This keeps it out of the current directory. Reported-by: Jeremy Morton Signed-off-by: David Aguilar --- I consider this a final finishing touch on a new 1.8.1 feature, so hopefully we can

Re: What's cooking in git.git (Dec 2012, #04; Sun, 16)

2012-12-18 Thread Joachim Schmitz
Matt Kraai wrote: Junio C Hamano wrote: It could turn out that we may be able to get rid of sys/param.h altogether, but one step at a time. Inputs from people on minority platforms are very much appreciated---does your platform build fine when the inclusion of the file is removed from git-compa

Re: [PATCH 2/2] Port to QNX

2012-12-16 Thread Joachim Schmitz
Matt Kraai wrote: From: Matt Kraai Signed-off-by: Matt Kraai --- Makefile | 19 +++ git-compat-util.h | 8 ++-- 2 files changed, 25 insertions(+), 2 deletions(-) snip diff --git a/git-compat-util.h b/git-compat-util.h index 2e79b8a..6c588ca 100644 --- a/git-com

RE: [PATCH 4/4] Declare that HP NonStop systems require strings.h

2012-12-15 Thread Joachim Schmitz
> From: Johannes Sixt [mailto:j...@kdbg.org] > Sent: Saturday, December 15, 2012 12:17 AM > To: Joachim Schmitz > Cc: gits...@pobox.com; fedora@gmail.com; Git Mailing List > Subject: Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h > > Am 14.12.2012 2

Re: [PATCH 4/4] Declare that HP NonStop systems require strings.h

2012-12-14 Thread Joachim Schmitz
Johannes Sixt wrote: Am 14.12.2012 20:57, schrieb David Michael: This platform previously included strings.h automatically. However, the build system now requires an explicit option to do so. Signed-off-by: David Michael --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefi

Re: Build fixes for another obscure Unix

2012-12-13 Thread Joachim Schmitz
-NonStop patch (as you can see by my comment in git-compat-util.h I was thinking along the same line) https://github.com/dm0-/git/commit/933d72a5cfdc63fa9c3c68afa2f4899d9c3f791e together with its prerequisit https://github.com/dm0-/git/commit/301032c6488aeabb94ccc81bfb6d65ff2c23b924 ACKed

Re: [PATCH] Fix sizeof usage in get_permutations

2012-12-13 Thread Joachim Schmitz
Matthew Daley wrote: Currently it gets the size of an otherwise unrelated, unused variable instead of the expected struct size. Signed-off-by: Matthew Daley --- builtin/pack-redundant.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/pack-redundant.c b/builti

RE: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
> From: Sascha Cunz [mailto:sascha...@babbelbox.org] > Sent: Friday, November 23, 2012 1:26 PM > To: Joachim Schmitz > Cc: 'Marc Khouzam'; git@vger.kernel.org; sze...@ira.uka.de; > felipe.contre...@gmail.com > Subject: Re: [PATCH] Completion must sort before using

RE: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
Re-adding git@vger... > From: Marc Khouzam [mailto:marc.khou...@gmail.com] > Sent: Friday, November 23, 2012 11:51 AM > To: Joachim Schmitz > Cc: sze...@ira.uka.de; felipe.contre...@gmail.com > Subject: Re: [PATCH] Completion must sort before using uniq > > On Fri, No

Re: [PATCH 0/8] fix git-config with duplicate variable entries

2012-11-23 Thread Joachim Schmitz
Junio C Hamano wrote: Jeff King writes: ... Not exactly. There are three classes of people: - wrote scripts using --get; found out that --get barfs if you feed two or more of the same, and have long learned to accept it as a limitation and adjusted their configuration files to avoid it

Re: [PATCH] Completion must sort before using uniq

2012-11-23 Thread Joachim Schmitz
Marc Khouzam wrote: The uniq program only works with sorted input. The man page states "uniq prints the unique lines in a sorted file". ... --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -321,7 +321,7 @@ __git_refs ()

RE: [PATCH v2] fix 'make test' for HP NonStop

2012-10-30 Thread Joachim Schmitz
> From: Jeff King [mailto:p...@peff.net] > Sent: Monday, October 29, 2012 8:07 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH v2] fix 'make test' for HP NonStop > > On Thu, Oct 25, 2012 at 12:57:10PM +0200, Joachim Schmitz wrote: > &g

RE: [PATCH] fix 'make test' for HP NonStop

2012-10-25 Thread Joachim Schmitz
> From: Jeff King [mailto:p...@peff.net] > Sent: Thursday, October 25, 2012 12:53 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] fix 'make test' for HP NonStop > > On Thu, Oct 25, 2012 at 12:51:59PM +0200, Joachim Schmitz wrote: >

RE: [PATCH v2] fix 'make test' for HP NonStop

2012-10-25 Thread Joachim Schmitz
This fixes the vast majority of test failures on HP NonStop. Signed-off-by: Joachim Schmitz --- v2: hardcode /usr/local rather than using ${prefix} Makefile | 9 + 1 file changed, 9 insertions(+) diff --git a/Makefile b/Makefile index f69979e..35380dd 100644 --- a/Makefile +++ b

RE: [PATCH] fix 'make test' for HP NonStop

2012-10-25 Thread Joachim Schmitz
> From: Jeff King [mailto:p...@peff.net] > Sent: Thursday, October 25, 2012 12:49 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] fix 'make test' for HP NonStop > > On Thu, Oct 25, 2012 at 12:21:44PM +0200, Joachim Schmitz wrote: >

RE: [PATCH] fix 'make test' for HP NonStop

2012-10-25 Thread Joachim Schmitz
> From: Jeff King [mailto:p...@peff.net] > Sent: Thursday, October 25, 2012 11:58 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH] fix 'make test' for HP NonStop > > On Mon, Oct 22, 2012 at 04:30:17PM +0200, Joachim Schmitz wro

git daemon test fails

2012-10-22 Thread Joachim Schmitz
Here's one test failing (on HP NonStop, git-1.8.0), which needs to get enable first. /home/jojo/git/git/t $ PATH=/usr/local/bin:$PATH GIT_TEST_GIT_DAEMON=true bash ./t5570-git-daemon.sh ok 1 - setup repository ok 2 - create git-accessible bare repository ok 3 - clone git repository [946798748] C

[PATCH] fix 'make test' for HP NonStop

2012-10-22 Thread Joachim Schmitz
This fixes the vast majority of test failures on HP NonStop. Signed-off-by: Joachim Schmitz --- A few more still insist on /usr/local/bin being 1st in PATH and having done that we're down to one single failing test, t0301 #12 "helper (cache --timeout=1) times out" Makefile | 9 +

Re: make test

2012-10-22 Thread Joachim Schmitz
"Joachim Schmitz" schrieb im Newsbeitrag news:... > Hi folks > > I'm trying to understand why certain tests in 'make test' fail. Here's the > first one > > $ ../git --version > git version 1.8.0.rc2.5.g6b89306 > $ GIT_TEST_CMP_USE_C

RE: make test

2012-10-17 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Monday, October 15, 2012 3:18 PM > To: 'Andreas Schwab'; 'Johannes Sixt' > Cc: 'git@vger.kernel.org' > Subject: RE: make test > > > From: Andreas Schwab [mailto:sch...@linu

RE: [RFC/PATCH 3/4] test-lib: provide lazy TIME_COMMAND prereq

2012-10-16 Thread Joachim Schmitz
> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net] > Sent: Tuesday, October 16, 2012 5:07 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Junio C Hamano' > Subject: Re: [RFC/PATCH 3/4] test-lib: provide lazy TIME_COMMAND prereq > > Joachim Schmitz ve

RE: [RFC/PATCH 3/4] test-lib: provide lazy TIME_COMMAND prereq

2012-10-16 Thread Joachim Schmitz
> From: Michael J Gruber [mailto:g...@drmicha.warpmail.net] > Sent: Tuesday, October 16, 2012 1:40 PM > To: git@vger.kernel.org > Cc: Joachim Schmitz; Junio C Hamano > Subject: [RFC/PATCH 3/4] test-lib: provide lazy TIME_COMMAND prereq > > Some test want to use the time c

RE: make test

2012-10-15 Thread Joachim Schmitz
> From: Andreas Schwab [mailto:sch...@linux-m68k.org] > Sent: Monday, October 15, 2012 2:35 PM > To: Johannes Sixt > Cc: Joachim Schmitz; git@vger.kernel.org > Subject: Re: make test > > Johannes Sixt writes: > > > Am 10/15/2012 13:58, schrieb Joachim Schmitz:

RE: make test

2012-10-15 Thread Joachim Schmitz
> From: Johannes Sixt [mailto:j.s...@viscovery.net] > Sent: Monday, October 15, 2012 2:10 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: make test > > Am 10/15/2012 13:58, schrieb Joachim Schmitz: > > ++ mkdir failing-cleanup > > ++ cd failing-c

RE: make test

2012-10-15 Thread Joachim Schmitz
> -Original Message- > From: Johannes Sixt [mailto:j.s...@viscovery.net] > Sent: Monday, October 15, 2012 1:53 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: make test > > Am 10/15/2012 13:37, schrieb Joachim Schmitz: > > ... > > +

RE: make test

2012-10-15 Thread Joachim Schmitz
> From: Johannes Sixt [mailto:j.s...@viscovery.net] > Sent: Monday, October 15, 2012 1:18 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: make test > > Am 10/15/2012 13:00, schrieb Joachim Schmitz: > >> From: Johannes Sixt [mailto:j.s...@viscovery.

RE: make test

2012-10-15 Thread Joachim Schmitz
> From: Johannes Sixt [mailto:j.s...@viscovery.net] > Sent: Monday, October 15, 2012 12:53 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: make test > > Am 10/15/2012 12:36, schrieb Joachim Schmitz: > > not ok 4 - pretend we have a known bre

t3302-notes-index-expensive.sh and t3419-rebase-patch-id.sh need time in /usr/bin

2012-10-15 Thread Joachim Schmitz
Hi folks t3302-notes-index-expensive.sh and t3419-rebase-patch-id.sh need "time " to be in "/usr/bin", however on my system it is in "/bin". Can't this be checked for? Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.ke

make test

2012-10-15 Thread Joachim Schmitz
Hi folks I'm trying to understand why certain tests in 'make test' fail. Here's the first one $ ../git --version git version 1.8.0.rc2.5.g6b89306 $ GIT_TEST_CMP_USE_COPIED_CONTEXT=true ./t-basic.sh # our diff doesn't understand -u ok 1 - .git/objects should be empty after git init in an

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-09 Thread Joachim Schmitz
Junio C Hamano wrote: Junio C Hamano writes: Ben Walton writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton --- Thanks, but is "-p" essential for this test to pass, or can we get away with just "-R"? Besides, when you spot a

Re: [PATCH 08/10] Integrate wildmatch to git

2012-10-06 Thread Joachim Schmitz
Thiago Farina wrote: On Fri, Oct 5, 2012 at 1:41 AM, Nguyễn Thái Ngọc Duy wrote: This makes wildmatch.c part of libgit.a and builds test-wildmatch; the dependency on libpopt in the original has been replaced with the use of our parse-options. Global variables in test-wildmatch are marked static

Re: [PATCH] more meaningful error message in gitk when git binary is not available

2012-10-01 Thread Joachim Schmitz
Josef Assad wrote: Hi. I ran across what is a decidedly trivial little issue in gitk. The TCL/Tk looked simple enough so I am giving you a patch anyhow in case you want to fix it. When for whatever reason the git binary is unavailable, gitk would complain about missing git repository instead, so

Re: Test failure: Test #3 in t1304-default-acl

2012-10-01 Thread Joachim Schmitz
Ramkumar Ramachandra wrote: Hi Junio, Junio C Hamano wrote: Matthieu Moy writes: Junio C Hamano writes: I haven't been paying attention, but does that mean on that system, a total stranger kseygold can write, modify, and remove whatever Ram owns? I am hoping that is not the case. I can

RE: Can git pull from a mercurial repository?

2012-09-25 Thread Joachim Schmitz
> From: Max Horn [mailto:post...@quendi.de] > Sent: Tuesday, September 25, 2012 4:15 PM > To: Joachim Schmitz > Cc: 'Andreas Ericsson'; git@vger.kernel.org > Subject: Re: Can git pull from a mercurial repository? > > Hi there, > > > On 18.09.2012, at 14

Re: Can git pull from a mercurial repository?

2012-09-25 Thread Joachim Schmitz
Gelonida N wrote: On 09/18/2012 02:40 PM, Joachim Schmitz wrote: From: Andreas Ericsson [mailto:a...@op5.se] Sent: Tuesday, September 18, 2012 1:46 PM To: Joachim Schmitz Cc: git@vger.kernel.org Subject: Re: Can git pull from a mercurial repository? On 09/18/2012 01:22 PM, Joachim Schmitz

RE: [PATCH] Port to HP NonStop

2012-09-19 Thread Joachim Schmitz
> From: Jan Engelhardt [mailto:jeng...@inai.de] > Sent: Wednesday, September 19, 2012 10:34 PM > To: Joachim Schmitz > Cc: 'Junio C Hamano'; git@vger.kernel.org > Subject: RE: [PATCH] Port to HP NonStop > > On Wednesday 2012-09-19 19:54, Joachim Schmitz wrot

RE: [PATCH] Port to HP NonStop

2012-09-19 Thread Joachim Schmitz
> From: Jan Engelhardt [mailto:jeng...@inai.de] > Sent: Wednesday, September 19, 2012 7:48 PM > To: Joachim Schmitz > Cc: 'Junio C Hamano'; git@vger.kernel.org > Subject: Re: [PATCH] Port to HP NonStop > > > On Wednesday 2012-09-19 12:03, Joachim Sch

[PATCH] Port to HP NonStop

2012-09-19 Thread Joachim Schmitz
Includes the addition of some new defines and their description for others to use. Signed-off-by: Joachim Schmitz --- This needs my 4 compat-poll patches posted earlier, which are in pu currently Makefile | 67 +++ git-compat-util.h

RE: [RFC] Support for HP NonStop

2012-09-19 Thread Joachim Schmitz
> From: Jan Engelhardt [mailto:jeng...@inai.de] > Sent: Wednesday, September 19, 2012 9:24 AM > To: Joachim Schmitz > Cc: 'Junio C Hamano'; git@vger.kernel.org > Subject: RE: [RFC] Support for HP NonStop > > > On Friday 2012-08-24 22:43, Joachim Schmitz wrote:

RE: [PATCH/RFC] Port to HP NonStop

2012-09-18 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 18, 2012 7:03 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH/RFC] Port to HP NonStop > > "Joachim Schmitz" writes: > > >> From: Junio C Hamano [m

RE: Can git pull from a mercurial repository?

2012-09-18 Thread Joachim Schmitz
> From: Andreas Ericsson [mailto:a...@op5.se] > Sent: Tuesday, September 18, 2012 1:46 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: Can git pull from a mercurial repository? > > On 09/18/2012 01:22 PM, Joachim Schmitz wrote: > > Is there an easy w

RE: Can git pull from a mercurial repository?

2012-09-18 Thread Joachim Schmitz
> From: Andreas Schwab [mailto:sch...@linux-m68k.org] > Sent: Tuesday, September 18, 2012 2:34 PM > To: Joachim Schmitz > Cc: 'Georgi Chorbadzhiyski'; git@vger.kernel.org > Subject: Re: Can git pull from a mercurial repository? > > "Joachim Schmitz"

RE: Can git pull from a mercurial repository?

2012-09-18 Thread Joachim Schmitz
> From: Georgi Chorbadzhiyski [mailto:g...@unixsol.org] > Sent: Tuesday, September 18, 2012 2:06 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: Can git pull from a mercurial repository? > > Around 09/18/2012 02:22 PM, Joachim Schmitz scribbled: > >

Can git pull from a mercurial repository?

2012-09-18 Thread Joachim Schmitz
Is there an easy way to get git to clone/pull from a Mercurial repository? Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH/RFC] Port to HP NonStop

2012-09-18 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 18, 2012 9:57 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH/RFC] Port to HP NonStop > > "Joachim Schmitz" writes: > > > Needs a different link or

RE: [PATCH v7 1/4] make poll available for other platforms lacking it

2012-09-18 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 18, 2012 8:55 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH v7 1/4] make poll available for other platforms lacking it > > "Joachim Schmitz" writes: > &

RE: [PATCH/RFC] Port to HP NonStop

2012-09-17 Thread Joachim Schmitz
Signed-off-by: Joachim Schmitz --- This needs the 4 compat-poll patches posted earlier. Needs a different link order in Makefile: libintl before libiconv. This may affect other platforms, so needs some checking. Also I'm not really sure how to best #ifdef the #include and the typed

RE: [PATCH v7 1/4] make poll available for other platforms lacking it

2012-09-17 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 18, 2012 12:42 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH v7 1/4] make poll available for other platforms lacking it > > "Joachim Schmitz" writes: > >

RE: [PATCH v7 0/4] Support non-WIN32 systems lacking poll()

2012-09-17 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 18, 2012 12:39 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH v7 0/4] Support non-WIN32 systems lacking poll() > > "Joachim Schmitz" writes: > > > Post

Re: [PATCH v7 0/4] Support non-WIN32 systems lacking poll()

2012-09-17 Thread Joachim Schmitz
Joachim Schmitz wrote: Here's now my updated series of patches to make the win32 implementation of poll() available to other platforms: 1 - make poll available for other platforms lacking it by moving it into a separate directory and adjusting Makefile 2 - fix some win32 specific depende

[PATCH v7 4/4] make poll() work on platforms that can't recv() on a non-socket

2012-09-17 Thread Joachim Schmitz
This way it just got added to gnulib too the other day. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 5 + 1 file changed, 5 insertions(+) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index e4b8319..10a204e 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c

[PATCH v7 3/4] poll() exits too early with EFAULT if 1st arg is NULL

2012-09-17 Thread Joachim Schmitz
the same manner the other day. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/poll/poll.c b/compat/win32/poll.c index 403eaa7..9e7a25c 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -357,7 +357,7

[PATCH v7 2/4] fix some win32 specific dependencies in poll.c

2012-09-17 Thread Joachim Schmitz
In order for non-win32 platforms to be able to use poll.c, #ifdef the inclusion of two header files properly Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index 9e7a25c

[PATCH v7 1/4] make poll available for other platforms lacking it

2012-09-17 Thread Joachim Schmitz
move poll.[ch] out of compat/win32/ into compat/poll/ and adjust Makefile with the changed paths. Adding comments to Makefile about how/when to enable it and add logic for this Signed-off-by: Joachim Schmitz --- Makefile | 20 +++- compat/{win32 => p

Re: [PATCH v7 0/4] Support non-WIN32 systems lacking poll()

2012-09-17 Thread Joachim Schmitz
Here's now my updated series of patches to make the win32 implementation of poll() available to other platforms: 1 - make poll available for other platforms lacking it by moving it into a separate directory and adjusting Makefile 2 - fix some win32 specific dependencies in poll.c by #ifdef the in

Re: Test failure: Test #3 in t1304-default-acl

2012-09-17 Thread Joachim Schmitz
Matthieu Moy wrote: Junio C Hamano writes: I haven't been paying attention, but does that mean on that system, a total stranger kseygold can write, modify, and remove whatever Ram owns? I am hoping that is not the case. I can see two reasons for having the same UID for two login names: 1)

RE: What's cooking in git.git (Sep 2012, #05; Fri, 14)

2012-09-17 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Saturday, September 15, 2012 7:15 PM > To: 'Junio C Hamano' > Cc: 'git@vger.kernel.org' > Subject: RE: What's cooking in git.git (Sep 2012, #05; Fri, 14) > > > From: Junio C Ham

[PATCH v6 3/4] poll() exits too early with EFAULT if 1st arg is NULL

2012-09-17 Thread Joachim Schmitz
in the same manner the other day. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/poll/poll.c b/compat/win32/poll.c index 403eaa7..9e7a25c 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -349,7 +349,7

[PATCH v6 4/4] make poll() work on platforms that can't recv() on a non-socket

2012-09-17 Thread Joachim Schmitz
This way it just got added to gnulib too the other day. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 5 + 1 file changed, 4 insertions(+) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index e4b8319..10a204e 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -306,6

[PATCH v6 2/4] fix some win32 specific dependencies in poll.c

2012-09-17 Thread Joachim Schmitz
In order for non-win32 platforms to be able to use poll.c, #ifdef the inclusion of two header files in the same manner as it's done elsewhere in git. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/compat

[PATCH v6 1/4] make poll available for other platforms lacking it

2012-09-16 Thread Joachim Schmitz
move poll.[ch] out of compat/win32/ into compat/poll/ and adjust Makefile with the changed paths. Adding comments to Makefile about how/when to enable it and add logic for this Signed-off-by: Joachim Schmitz --- Makefile | 20 +++- compat/{win32 => p

[PATCH v6 0/4] Support non-WIN32 systems lacking poll()

2012-09-16 Thread Joachim Schmitz
Here's now my updated series of patches to make the win32 implementation of poll() available to other platforms: 1 - make poll available for other platforms lacking it by moving it into a separate directory and adjusting Makefile 2 - fix some win32 specific dependencies in poll.c by #ifdef the

RE: What's cooking in git.git (Sep 2012, #05; Fri, 14)

2012-09-15 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Saturday, September 15, 2012 7:01 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: What's cooking in git.git (Sep 2012, #05; Fri, 14) > > "Joachim Schmitz" writes: > > > Ju

Re: What's cooking in git.git (Sep 2012, #05; Fri, 14)

2012-09-15 Thread Joachim Schmitz
Junio C Hamano wrote: I think we can start thinking about feature freeze once the topics in 'next' that are scheduled to graduate to 'master' already are fully cooked. For any late-coming topic, there always is the next cycle ;-) I've not hear anything about my poll patches and I'd really like

Re: [PATCH v3 1/4] poll() exits too early with EFAULT if 1st arg is NULL

2012-09-13 Thread Joachim Schmitz
Joachim Schmitz wrote: Joachim Schmitz wrote: If poll() is used as a milli-second sleep, like in help.c, by passing a NULL in the 1st and a 0 in the 2nd arg, it exits with EFAULT. As per Paolo Bonzini, the original author, this is a bug and to be fixed like in this commit, which is not to exit

RE: [PATCH v5 4/4] make poll() work on platforms that can't recv() on a non-socket

2012-09-13 Thread Joachim Schmitz
This way it just got added to gnulib too. Signed-off-by: Joachim Schmitz --- compat/poll/poll.c | 5 + 1 file changed, 4 insertions(+) diff --git a/compat/poll/poll.c b/compat/poll/poll.c index e4b8319..10a204e 100644 --- a/compat/poll/poll.c +++ b/compat/poll/poll.c @@ -306,6 +306,10

  1   2   3   >