Jeff King writes:
>> To make it bullet-proof, I think we'd have to actually parse the graph
>> structure, finding a "*" line and then accepting only an indent that
>> matched it.
>
> Wow. Nerd snipe successful. This turned out to be quite tricky, but also
> kind of interesting.
The last patch lo
On Tue, Mar 20, 2018 at 11:58:14AM -0400, Jeff King wrote:
> The issue bisects to 7e4ffb4c17 (diff-highlight: add support for --graph
> output, 2016-08-29). I think the problem is the "\s+" at the end of the
> $GRAPH regex, which soaks up the space for the context, and accidentally
> treats the "-
On Tue, Mar 20, 2018 at 09:58:14AM +, Phillip Wood wrote:
> > Are you using any exotic filters for your pager? If you use "git
> > --no-pager" does the problem persist?
>
> Hi Peff, thanks for taking the time to check this, I had forgotten about
> the pager. I'm using diff-highlight and it se
On 20/03/18 06:09, Jeff King wrote:
> On Mon, Mar 19, 2018 at 10:21:56AM +, Phillip Wood wrote:
>
>> I've just been reviewing some patches with 'git log --graph --patch' and
>> came across what looked like a bug:
>>
>> | @@ -272,6 +272,9 @@ do
>> | --keep-empty)
>> | keep_e
On Mon, Mar 19, 2018 at 10:21:56AM +, Phillip Wood wrote:
> I've just been reviewing some patches with 'git log --graph --patch' and
> came across what looked like a bug:
>
> | @@ -272,6 +272,9 @@ do
> | --keep-empty)
> | keep_empty=yes
> | ;;
> | --all
I've just been reviewing some patches with 'git log --graph --patch' and
came across what looked like a bug:
| @@ -272,6 +272,9 @@ do
| --keep-empty)
| keep_empty=yes
| ;;
| --allow-empty-message)
| + --no-keep-empty)
| + keep_empty=
| +
6 matches
Mail list logo