I agree with what you're saying, just I thought this might be ultra-minor for
API-breakage. To me, 0 doesn't necessarily mean "I didn't segfault".
I lot of tools use ret-values to give information back. And that way it's much
easier to just `||` the command to something else instead of `[[ -z ]]`
On 12/11/2017 8:44 AM, George Papanikolaou wrote:
`git tag --points-at` can simply return if the given rev does not have
any tags pointing to it. It's not a failure but it shouldn't return
with 0 value.
I disagree. I think the 0 return means "I completed successfully" and
the empty output
`git tag --points-at` can simply return if the given rev does not have
any tags pointing to it. It's not a failure but it shouldn't return
with 0 value.
---
builtin/tag.c | 4
1 file changed, 4 insertions(+)
diff --git a/builtin/tag.c b/builtin/tag.c
index b38329b59..68b84db2a 100644
---
3 matches
Mail list logo