Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-03 Thread Jonathan Nieder
Junio C Hamano wrote: > Karsten Blees writes: >> If we don't want to support this, though, I think it would be more >> approrpiate to issue a warning if GIT_DIR points to a worktree >> location. > > But how do tell what is and isn't a "worktree location"? Having the > path in the index would be

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-03 Thread Karsten Blees
Am 03.12.2013 19:32, schrieb Junio C Hamano: > Karsten Blees writes: > >> So I figure that GIT_DIR is not meant to _rename_ the ".git" dir, >> but to point somewhere _outside_ the worktree (or somewhere within >> the .git dir). > > Correct. > >> If we don't want to support this, though, I think

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-03 Thread Junio C Hamano
Karsten Blees writes: >So I figure that GIT_DIR is not meant to _rename_ the ".git" dir, >but to point somewhere _outside_ the worktree (or somewhere within >the .git dir). Correct. > If we don't want to support this, though, I think it would be more > approrpiate to issue a warning if GIT_DIR

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-03 Thread Karsten Blees
Am 01.12.2013 20:04, schrieb Dennis Kaarsemaker: > We always ignore anything named .git, but we should also ignore the git > directory if the user overrides it by setting $GIT_DIR > > Reported-By: Ingy döt Net > Signed-off-by: Dennis Kaarsemaker > --- > dir.c | 2 +- > t/t7508-statu

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-02 Thread Duy Nguyen
On Mon, Dec 2, 2013 at 6:40 PM, Dennis Kaarsemaker wrote: >> ~/w/git $ cd t >> ~/w/git/t $ GIT_TRACE_SETUP=1 ../git --git-dir=../.git --work-tree=.. >> --no-pager status >> setup: git_dir: /home/pclouds/w/git/.git >> setup: worktree: /home/pclouds/w/git >> setup: cwd: /home/pclouds/w/git >> setup:

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-02 Thread Dennis Kaarsemaker
On ma, 2013-12-02 at 16:35 +0700, Duy Nguyen wrote: > On Mon, Dec 2, 2013 at 3:01 PM, Dennis Kaarsemaker > wrote: > > On ma, 2013-12-02 at 07:38 +0700, Duy Nguyen wrote: > >> On Mon, Dec 2, 2013 at 6:38 AM, Dennis Kaarsemaker > >> wrote: > >> > On ma, 2013-12-02 at 00:08 +0100, Thomas Rast wrote:

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-02 Thread Duy Nguyen
On Mon, Dec 2, 2013 at 3:01 PM, Dennis Kaarsemaker wrote: > On ma, 2013-12-02 at 07:38 +0700, Duy Nguyen wrote: >> On Mon, Dec 2, 2013 at 6:38 AM, Dennis Kaarsemaker >> wrote: >> > On ma, 2013-12-02 at 00:08 +0100, Thomas Rast wrote: >> >> Duy Nguyen writes: >> >> >> >> > On Mon, Dec 2, 2013 at

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-02 Thread Dennis Kaarsemaker
On ma, 2013-12-02 at 07:38 +0700, Duy Nguyen wrote: > On Mon, Dec 2, 2013 at 6:38 AM, Dennis Kaarsemaker > wrote: > > On ma, 2013-12-02 at 00:08 +0100, Thomas Rast wrote: > >> Duy Nguyen writes: > >> > >> > On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker > >> > wrote: > >> >> We always ignore

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Eric Sunshine
On Sun, Dec 1, 2013 at 2:04 PM, Dennis Kaarsemaker wrote: > diff --git a/t/t7508-status.sh b/t/t7508-status.sh > index c987b5e..2bd7ef1 100755 > --- a/t/t7508-status.sh > +++ b/t/t7508-status.sh > @@ -198,6 +198,13 @@ test_expect_success 'status -s' ' > > ' > > +test_expect_success 'status -s wit

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Duy Nguyen
On Mon, Dec 2, 2013 at 6:38 AM, Dennis Kaarsemaker wrote: > On ma, 2013-12-02 at 00:08 +0100, Thomas Rast wrote: >> Duy Nguyen writes: >> >> > On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker >> > wrote: >> >> We always ignore anything named .git, but we should also ignore the git >> >> direct

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Dennis Kaarsemaker
On ma, 2013-12-02 at 00:08 +0100, Thomas Rast wrote: > Duy Nguyen writes: > > > On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker > > wrote: > >> We always ignore anything named .git, but we should also ignore the git > >> directory if the user overrides it by setting $GIT_DIR > [...] > >> +

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Thomas Rast
Duy Nguyen writes: > On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker > wrote: >> We always ignore anything named .git, but we should also ignore the git >> directory if the user overrides it by setting $GIT_DIR [...] >> + if (simplify_away(path->buf, path->len, simplify) || >> is_git_d

Re: [PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Duy Nguyen
On Mon, Dec 2, 2013 at 2:04 AM, Dennis Kaarsemaker wrote: > We always ignore anything named .git, but we should also ignore the git > directory if the user overrides it by setting $GIT_DIR > > Reported-By: Ingy döt Net > Signed-off-by: Dennis Kaarsemaker > --- > dir.c | 2 +- > t/t7

[PATCH] path_treatment: also ignore $GIT_DIR if it's not .git

2013-12-01 Thread Dennis Kaarsemaker
We always ignore anything named .git, but we should also ignore the git directory if the user overrides it by setting $GIT_DIR Reported-By: Ingy döt Net Signed-off-by: Dennis Kaarsemaker --- dir.c | 2 +- t/t7508-status.sh | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-)