Re: [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch

2015-07-31 Thread Paul Tan
On Fri, Jul 31, 2015 at 4:40 AM, Matthieu Moy wrote: > The previous code broke for example > > git pull --upload-pack 'echo --foo' > > Reported-by: Joey Hess > Fix-suggested-by: Junio C Hamano > Signed-off-by: Matthieu Moy Thanks for cleaning up my mess! >< Regards, Paul -- To unsubscribe f

Re: [PATCH] pull.sh: quote $upload_pack when passing it to git-fetch

2015-07-30 Thread Junio C Hamano
Matthieu Moy writes: > The previous code broke for example > > git pull --upload-pack 'echo --foo' > > Reported-by: Joey Hess > Fix-suggested-by: Junio C Hamano > Signed-off-by: Matthieu Moy > --- > Junio wrote: >> ${upload_pack+"$upload_pack"} or something. > > Indeed, we need to pass nothi

[PATCH] pull.sh: quote $upload_pack when passing it to git-fetch

2015-07-30 Thread Matthieu Moy
The previous code broke for example git pull --upload-pack 'echo --foo' Reported-by: Joey Hess Fix-suggested-by: Junio C Hamano Signed-off-by: Matthieu Moy --- Junio wrote: > ${upload_pack+"$upload_pack"} or something. Indeed, we need to pass nothing, not the empty string if $upload_pack is