Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-28 Thread Bhushan Lodha
I plan to work on this in few weeks. If anybody has more suggestion or want to discuss the implementation let me know On Fri, Apr 4, 2014 at 2:46 PM, Junio C Hamano wrote: > Jakub Narębski writes: > >> W dniu 2014-04-03 23:44, Junio C Hamano pisze: >>> René Scharfe writes: >>> With that ap

Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-04 Thread Junio C Hamano
Jakub Narębski writes: > W dniu 2014-04-03 23:44, Junio C Hamano pisze: >> René Scharfe writes: >> >>> With that approach you depend on the hunk header and apparently need >>> to add XDL_EMIT_MOREFUNCNAMES and XDL_EMIT_MOREHUNKHEADS to improve >>> the results. This approach feels fragile. >>> >

Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-04 Thread Jakub Narębski
W dniu 2014-04-03 23:44, Junio C Hamano pisze: René Scharfe writes: With that approach you depend on the hunk header and apparently need to add XDL_EMIT_MOREFUNCNAMES and XDL_EMIT_MOREHUNKHEADS to improve the results. This approach feels fragile. Would it perhaps be more robust to not base t

Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-03 Thread Junio C Hamano
René Scharfe writes: > With that approach you depend on the hunk header and apparently need > to add XDL_EMIT_MOREFUNCNAMES and XDL_EMIT_MOREHUNKHEADS to improve > the results. This approach feels fragile. > > Would it perhaps be more robust to not base the implementation on diff > and instead t

Re: [PATCH 06/10] log: --function-name pickaxe

2014-04-03 Thread René Scharfe
Am 27.03.2014 19:50, schrieb David A. Dalrymple (and Bhushan G. Lodha): From: "Bhushan G. Lodha & David A. Dalrymple" This is similar to the pickaxe grep option (-G), but applies the provided regex only to diff hunk headers, thereby showing only those commits which affect a "function" with a de

[PATCH 06/10] log: --function-name pickaxe

2014-03-27 Thread David A. Dalrymple (and Bhushan G. Lodha)
From: "Bhushan G. Lodha & David A. Dalrymple" This is similar to the pickaxe grep option (-G), but applies the provided regex only to diff hunk headers, thereby showing only those commits which affect a "function" with a definition line matching the pattern. These are "functions" in the same sens