Re: [PATCH 1/3] Make test "using invalid commit with -C" more strict

2013-08-24 Thread Jonathan Nieder
Junio C Hamano wrote: >> Kacper Kornet wrote: >>> In the test 'using invalid commit with -C' git-commit would have failed >>> even if the -C option had been given the correct commit, as there was >>> nothing to commit. [...] > Also it would be much simpler to say "git commit --allow-empty". Soun

Re: [PATCH 1/3] Make test "using invalid commit with -C" more strict

2013-08-24 Thread Junio C Hamano
Jonathan Nieder writes: > Kacper Kornet wrote: > >> In the test 'using invalid commit with -C' git-commit would have failed >> even if the -C option had been given the correct commit, as there was >> nothing to commit. > > Good catch. > > [...] >> --- a/t/t7501-commit.sh >> +++ b/t/t7501-commit.

Re: [PATCH 1/3] Make test "using invalid commit with -C" more strict

2013-08-24 Thread Jonathan Nieder
Kacper Kornet wrote: > In the test 'using invalid commit with -C' git-commit would have failed > even if the -C option had been given the correct commit, as there was > nothing to commit. Good catch. [...] > --- a/t/t7501-commit.sh > +++ b/t/t7501-commit.sh > @@ -53,7 +53,10 @@ test_expect_succ

[PATCH 1/3] Make test "using invalid commit with -C" more strict

2013-08-23 Thread Kacper Kornet
In the test 'using invalid commit with -C' git-commit would have failed even if the -C option had been given the correct commit, as there was nothing to commit. Fix it by making sure there is always something to commit and git-commit fails because of the invalid commit provided to it. Signed-off-

[PATCH 1/3] Make test "using invalid commit with -C" more strict

2013-08-23 Thread Kacper Kornet
In the test 'using invalid commit with -C' git-commit would have failed even if the -C option had been given the correct commit, as there was nothing to commit. Fix it by making sure there is always something to commit and git-commit fails because of the invalid commit provided to it. Signed-off-