Re: [PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-18 Thread James Nylen
On Mon, Feb 18, 2013 at 1:39 PM, wrote: > James Nylen writes: >> - add "fancylib" as a subtree of "myprog" >> - commit to "myprog" repo: "fancylib: don't crash as much" >> - split these commits back out to "fancylib" main repo, and remove >> the "fancylib: " prefix > Should this really be a

Re: [PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-18 Thread greened
James Nylen writes: > I don't agree that removing `--annotate` obviates the need for `--unannotate`. > > I responded on 1/17 with what I think is a typical and normal use case > for that option: Sorry, I must have missed that reply. > - add "fancylib" as a subtree of "myprog" > - commit to "m

Re: [PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-05 Thread James Nylen
On Tue, Feb 5, 2013 at 6:44 AM, wrote: > Junio C Hamano writes: > >>> Remove --annotate. This obviates the need for an --unannotate >>> command. We really want a more generalized commit message rewrite >>> mechanism. >> >> That may be a good goal as the end result, but wouldn't it be a bit >>

[PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-05 Thread David A. Greene
From: "David A. Greene" Remove --annotate. This obviates the need for an --unannotate command. We really want a more generalized commit message rewrite mechanism. Signed-off-by: David A. Greene --- contrib/subtree/git-subtree.sh |6 + contrib/subtree/t/t7900-subtree.sh | 50 +++

Re: [PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-04 Thread Junio C Hamano
"David A. Greene" writes: > From: "David A. Greene" > > Remove --annotate. This obviates the need for an --unannotate > command. We really want a more generalized commit message rewrite > mechanism. That may be a good goal as the end result, but wouldn't it be a bit unhelpful to remove these

[PATCH 13/13] contrib/subtree: Remove --annotate

2013-02-04 Thread David A. Greene
From: "David A. Greene" Remove --annotate. This obviates the need for an --unannotate command. We really want a more generalized commit message rewrite mechanism. Signed-off-by: David A. Greene --- contrib/subtree/git-subtree.sh |6 + contrib/subtree/t/t7900-subtree.sh | 50 +++