Re: [PATCH 16/20] revision: trivial style fixes

2013-10-12 Thread Felipe Contreras
Stefan Beller wrote: > While talking about trivia, what is the projects stance on > such constructs here? > while (foo) > bar(); > foobar(); > > I've seen an empty line between the bar(); and the foobar(); often, which > suits readability. > What's the stance on such an

Re: [PATCH 16/20] revision: trivial style fixes

2013-10-12 Thread Stefan Beller
On 10/12/2013 09:07 AM, Felipe Contreras wrote: > Signed-off-by: Felipe Contreras > --- > revision.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/revision.c b/revision.c > index 0173e01..4049867 100644 > --- a/revision.c > +++ b/revision.c > @@ -1503,7

[PATCH 16/20] revision: trivial style fixes

2013-10-12 Thread Felipe Contreras
Signed-off-by: Felipe Contreras --- revision.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/revision.c b/revision.c index 0173e01..4049867 100644 --- a/revision.c +++ b/revision.c @@ -1503,7 +1503,7 @@ struct cmdline_pathspec { static void append_prune_data(