Re: [PATCH v3 1/2] diff: move no-index detection to builtin/diff.c

2013-12-10 Thread Thomas Gummerer
Jonathan Nieder writes: > (pruning cc list) > Hi, > > Thomas Gummerer wrote: > >> Currently the --no-index option is parsed in diff_no_index(). Move the >> detection if a no-index diff should be executed to builtin/diff.c > > No functional change intended, I assume? Correct, I thought I'd split

Re: [PATCH v3 1/2] diff: move no-index detection to builtin/diff.c

2013-12-10 Thread Jonathan Nieder
(pruning cc list) Hi, Thomas Gummerer wrote: > Currently the --no-index option is parsed in diff_no_index(). Move the > detection if a no-index diff should be executed to builtin/diff.c No functional change intended, I assume? [...] > --- a/builtin/diff.c > +++ b/builtin/diff.c > @@ -283,14 +2

[PATCH v3 1/2] diff: move no-index detection to builtin/diff.c

2013-12-10 Thread Thomas Gummerer
Currently the --no-index option is parsed in diff_no_index(). Move the detection if a no-index diff should be executed to builtin/diff.c, where we can use it for executing diff_no_index() conditionally. This will also allow us to execute other operations conditionally, which will be done in the n