Re: [PATCH v4 5/6] format-patch: add format.cover-letter configuration

2013-04-07 Thread Jonathan Nieder
Hi, Simon Ruderich wrote: > On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote: >> +test_expect_success 'cover letter auto' ' >> +mkdir -p tmp && >> +test_when_finished "rm -rf tmp; [...] > I'm not sure if it's better to use test_when_finished with rm or > just && rm -rf tmp

Re: [PATCH v4 5/6] format-patch: add format.cover-letter configuration

2013-04-07 Thread Simon Ruderich
On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote: > [snip] > > +test_expect_success 'cover letter auto' ' > + mkdir -p tmp && > + test_when_finished "rm -rf tmp; > + git config --unset format.coverletter" && > + > + git config format.coverletter auto &&

[PATCH v4 5/6] format-patch: add format.cover-letter configuration

2013-04-07 Thread Felipe Contreras
Also, add a new option: 'auto', so if there's more than one patch, the cover letter is generated, otherwise it's not. Signed-off-by: Felipe Contreras --- Documentation/config.txt | 5 + Documentation/git-format-patch.txt | 5 +++-- builtin/log.c | 32