[PATCH] implement submodule config cache for lookup of submodule names

2014-03-10 Thread Heiko Voigt
This submodule configuration cache allows us to lazily read .gitmodules configurations by commit into a runtime cache which can then be used to easily lookup values from it. Currently only the values for path or name are stored but it can be extended for any value needed. It is expected that .gitm

Re: [PATCH] implement submodule config cache for lookup of submodule names

2014-03-11 Thread Jeff King
On Mon, Mar 10, 2014 at 10:24:12PM +0100, Heiko Voigt wrote: > I have also moved all functions into the new submodule-config-cache > module. I am not completely satisfied with the naming since it is quite > long. If someone comes up with some different naming I am open for it. > Maybe simply submo

Re: [PATCH] implement submodule config cache for lookup of submodule names

2014-03-11 Thread Jonathan Nieder
Hi, Some quick thoughts. Heiko Voigt wrote: > This submodule configuration cache allows us to lazily read .gitmodules > configurations by commit into a runtime cache which can then be used to > easily lookup values from it. Currently only the values for path or name > are stored but it can be ex

Re: Re: [PATCH] implement submodule config cache for lookup of submodule names

2014-03-12 Thread Heiko Voigt
On Tue, Mar 11, 2014 at 05:58:08PM -0400, Jeff King wrote: > On Mon, Mar 10, 2014 at 10:24:12PM +0100, Heiko Voigt wrote: > > > I have also moved all functions into the new submodule-config-cache > > module. I am not completely satisfied with the naming since it is quite > > long. If someone comes

Re: Re: [PATCH] implement submodule config cache for lookup of submodule names

2014-03-12 Thread Heiko Voigt
Hi, On Tue, Mar 11, 2014 at 07:28:52PM -0700, Jonathan Nieder wrote: > Heiko Voigt wrote: > > > This submodule configuration cache allows us to lazily read .gitmodules > > configurations by commit into a runtime cache which can then be used to > > easily lookup values from it. Currently only the

Re: Re: [PATCH] implement submodule config cache for lookup of submodule names

2014-03-12 Thread Jonathan Nieder
Heiko Voigt wrote: > On Tue, Mar 11, 2014 at 07:28:52PM -0700, Jonathan Nieder wrote: >> Heiko Voigt wrote: >>> +static unsigned int hash_sha1_string(const unsigned char *sha1, const char >>> *string) >>> +{ >>> + return memhash(sha1, 20) + strhash(string); >>> +} >> >> Feels a bit unconvention