Jeff King writes:
> Sort of. It still has the bug that it dies with error() when "--debug"
> is used.
Ah, I forgot about that one. Let me squash it in without the
remove_trash change then, perhaps, but not today.
On Mon, Apr 24, 2017 at 11:05:15PM -0700, Junio C Hamano wrote:
> Jeff King writes:
>
> > Good point. There's only one caller, but it does care about being in
> > that directory.
> >
> >> Second try that hopefully is much less damaging
>
> I've been carrying it as a SQUASH??? patch, but I think
Jeff King writes:
> Good point. There's only one caller, but it does care about being in
> that directory.
>
>> Second try that hopefully is much less damaging
I've been carrying it as a SQUASH??? patch, but I think it is better
to split it as a separate pach, as removal of $remove_trash is an
o
Torsten Bögershausen writes:
> []
>>>
>>> - cd "$(dirname "$remove_trash")" &&
>>> - rm -rf "$(basename "$remove_trash")" ||
>>> - error "Tests passed but test cleanup failed; aborting"
>>> + cd "$(dirname "$TRASH_DIRECTORY")" &&
>>> +
On Mon, Apr 24, 2017 at 11:39:26AM +0200, Torsten Bögershausen wrote:
> []
> > >
> > > - cd "$(dirname "$remove_trash")" &&
> > > - rm -rf "$(basename "$remove_trash")" ||
> > > - error "Tests passed but test cleanup failed; aborting"
> > > + cd "$(dirname
[]
- cd "$(dirname "$remove_trash")" &&
- rm -rf "$(basename "$remove_trash")" ||
- error "Tests passed but test cleanup failed; aborting"
+ cd "$(dirname "$TRASH_DIRECTORY")" &&
+ rm -fr "$TRASH_DIRECTORY" ||
On Sun, Apr 23, 2017 at 09:02:41PM -0700, Junio C Hamano wrote:
> >> That looks fine, assuming the answer to the "is the cwd important"
> >> question is "no".
> >
> > And I do think the answer would be "yes", unfortunately. There are
> > systems that do not even allow a file to be removed while i
Junio C Hamano writes:
>> That looks fine, assuming the answer to the "is the cwd important"
>> question is "no".
>
> And I do think the answer would be "yes", unfortunately. There are
> systems that do not even allow a file to be removed while it is
> open, so...
In addition to "some platforms
Jeff King writes:
> On Sun, Apr 23, 2017 at 05:14:54PM -0700, Junio C Hamano wrote:
>
>> OK. I am wondering why we do not do
>>
>> rm -fr "$TRASH_DIRECTORY"
>>
>> and do this instead:
>>
>> cd "$(dirname "$remove_trash")" &&
>> rm -rf "$(basename "$remove_trash")"
>>
>> in th
On Sun, Apr 23, 2017 at 05:14:54PM -0700, Junio C Hamano wrote:
> OK. I am wondering why we do not do
>
> rm -fr "$TRASH_DIRECTORY"
>
> and do this instead:
>
> cd "$(dirname "$remove_trash")" &&
> rm -rf "$(basename "$remove_trash")"
>
> in the original. It feels somewhat
Jeff King writes:
>> -test -d "$remove_trash" &&
>> +test -d "$remove_trash" ||
>> +error "Tests passed but trash directory already removed before
>> test cleanup; aborting"
>
> I think I found out why this "test -d" was here in the first place:
>
> $ ./t000
On Thu, Apr 20, 2017 at 06:52:30PM +0200, SZEDER Gábor wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 13b569682..e9e6f677d 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -761,9 +761,12 @@ test_done () {
> say "1..$test_count$skip_all"
> fi
On Fri, Apr 21, 2017 at 2:48 AM, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
>> We had two similar bugs in the tests sporadically triggering error
>> messages during the removal of the trash directory, see commits
>> bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and
>> ef09036cf
SZEDER Gábor writes:
> We had two similar bugs in the tests sporadically triggering error
> messages during the removal of the trash directory, see commits
> bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and
> ef09036cf (t6500: wait for detached auto gc at the end of the test
> scr
On Thu, Apr 20, 2017 at 06:52:30PM +0200, SZEDER Gábor wrote:
> We had two similar bugs in the tests sporadically triggering error
> messages during the removal of the trash directory, see commits
> bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and
> ef09036cf (t6500: wait for detac
We had two similar bugs in the tests sporadically triggering error
messages during the removal of the trash directory, see commits
bb05510e5 (t5510: run auto-gc in the foreground, 2016-05-01) and
ef09036cf (t6500: wait for detached auto gc at the end of the test
script, 2017-04-13). The test scrip
16 matches
Mail list logo
