Re: [PATCH 2/2] diff.c: get rid of duplicate implementation

2017-10-30 Thread Jeff King
On Mon, Oct 30, 2017 at 10:59:41AM -0700, Jeff King wrote: > > There's also https://www.strchr.com/hash_functions, which lists DJB2 > > as Bernstein. Both functions rank somewhere in the middle of that list. > > FWIW, I did some experiments with Murmur3 and SipHash a while back, but > I don't th

Re: [PATCH 2/2] diff.c: get rid of duplicate implementation

2017-10-30 Thread Jeff King
On Thu, Oct 26, 2017 at 07:43:19PM +0200, René Scharfe wrote: > Am 25.10.2017 um 20:49 schrieb Stefan Beller: > > The implementations in diff.c to detect moved lines needs to compare > > strings and hash strings, which is implemented in that file, as well > > as in the xdiff library. > > > > Remo

Re: [PATCH 2/2] diff.c: get rid of duplicate implementation

2017-10-26 Thread René Scharfe
Am 25.10.2017 um 20:49 schrieb Stefan Beller: > The implementations in diff.c to detect moved lines needs to compare > strings and hash strings, which is implemented in that file, as well > as in the xdiff library. > > Remove the rather recent implementation in diff.c and rely on the well > exerci

Re: [PATCH 2/2] diff.c: get rid of duplicate implementation

2017-10-25 Thread Junio C Hamano
Stefan Beller writes: > The implementations in diff.c to detect moved lines needs to compare > strings and hash strings, which is implemented in that file, as well > as in the xdiff library. > > Remove the rather recent implementation in diff.c and rely on the well > exercised code in the xdiff l