Jonathan, do you see any issues with the use of lookup_commit() in
this change wrt lazy clone? I am wondering what happens when the
commit in question is at, an immediate parent of, or an immediate
child of a promisor object. I _think_ this change won't make it
worse for two features in playing t
Hi Junio & Jonathan,
On Wed, 24 Oct 2018, Junio C Hamano wrote:
> Jonathan, do you see any issues with the use of lookup_commit() in
> this change wrt lazy clone? I am wondering what happens when the
> commit in question is at, an immediate parent of, or an immediate
> child of a promisor object
Hi,
On Wed, 24 Oct 2018, Johannes Schindelin wrote:
> On Wed, 24 Oct 2018, Junio C Hamano wrote:
>
> > Jonathan, do you see any issues with the use of lookup_commit() in
> > this change wrt lazy clone? I am wondering what happens when the
> > commit in question is at, an immediate parent of, or
> On Wed, 24 Oct 2018, Johannes Schindelin wrote:
>
> > On Wed, 24 Oct 2018, Junio C Hamano wrote:
> >
> > > Jonathan, do you see any issues with the use of lookup_commit() in
> > > this change wrt lazy clone? I am wondering what happens when the
> > > commit in question is at, an immediate pare
Hi Jonathan,
On Thu, 25 Oct 2018, Jonathan Tan wrote:
> > On Wed, 24 Oct 2018, Johannes Schindelin wrote:
> >
> > Coming back to my question whether there is a better way to check for
> > the presence of a local commit, I figured that I can use
> > `has_object_file()` instead of looking up and p
> Thanks for confirming.
>
> So even better would be to use `is_promisor_object(oid) ||
> has_object_file(oid)`, right?
>
> This is something that is probably not even needed: as I mentioned, the
> shallow commits are *expected* to be local. It should not ever happen that
> they are fetched.
Tha
Hi Jonathan,
On Fri, 26 Oct 2018, Jonathan Tan wrote:
> > So even better would be to use `is_promisor_object(oid) ||
> > has_object_file(oid)`, right?
> >
> > This is something that is probably not even needed: as I mentioned,
> > the shallow commits are *expected* to be local. It should not eve
7 matches
Mail list logo