Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 09:19:01AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > As I argued in [1], I think it's not just "this must be cheaper" but > > "this must not be enabled if submodules are not in use at all". Most > > repositories don't have submodules enabled at all, so anyth

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Junio C Hamano
Jeff King writes: > As I argued in [1], I think it's not just "this must be cheaper" but > "this must not be enabled if submodules are not in use at all". Most > repositories don't have submodules enabled at all, so anything that > cause any extra traversal, even of a portion of the history, is

Re: Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 02:04:21PM +0200, Heiko Voigt wrote: > > I think the only sane default is going to be some kind of heuristic that > > says "submodules are probably in use". Something like "is there a > > .gitmodules file" is not perfect (you can have gitlink entries without > > it), but it

Re: Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Heiko Voigt
On Tue, Oct 04, 2016 at 07:44:28AM -0400, Jeff King wrote: > > My idea of a solution goes like this: > > * collect all SHA1's of the remotes refs > > * check if we have them locally > > * if not we abort and tell the user to fetch them somehow into local > > refs or disable the check > >

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Jeff King
On Tue, Oct 04, 2016 at 01:18:45PM +0200, Heiko Voigt wrote: > On Mon, Oct 03, 2016 at 02:11:36PM -0700, Linus Torvalds wrote: > > This seems to be because I'm now on 'pu' as of a day or two ago in > > order to test the abbrev logic, but lookie here: > > > > time git ls-remote > > ra.kernel.

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-04 Thread Heiko Voigt
Hi, On Mon, Oct 03, 2016 at 02:11:36PM -0700, Linus Torvalds wrote: > This seems to be because I'm now on 'pu' as of a day or two ago in > order to test the abbrev logic, but lookie here: > > time git ls-remote ra.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux > .. shows all the bran

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-03 Thread Junio C Hamano
Stefan Beller writes: > On Mon, Oct 3, 2016 at 2:17 PM, Stefan Beller wrote: >> >> * sb/push-make-submodule-check-the-default (2016-08-24) 1 commit >> - push: change submodule default to check >> >> Turn the default of "push.recurseSubmodules" to "check". >> >> Will hold to wait for hv/sub

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-03 Thread Stefan Beller
+cc Heiko On Mon, Oct 3, 2016 at 2:17 PM, Stefan Beller wrote: > > * sb/push-make-submodule-check-the-default (2016-08-24) 1 commit > - push: change submodule default to check > > Turn the default of "push.recurseSubmodules" to "check". > > Will hold to wait for hv/submodule-not-yet-pushed-

Re: Slow pushes on 'pu' - even when up-to-date..

2016-10-03 Thread Stefan Beller
On Mon, Oct 3, 2016 at 2:11 PM, Linus Torvalds wrote: > This seems to be because I'm now on 'pu' as of a day or two ago in > order to test the abbrev logic, but lookie here: > > time git ls-remote ra.kernel.org:/pub/scm/linux/kernel/git/torvalds/linux > .. shows all the branches and tags .