Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-22 Thread Junio C Hamano
Jiang Xin writes: > Mark strings in git-am, git-rebase, and git-merge for translation. > And contain fixes for shell gettext extraction and xgettext workaround. > > Jiang Xin (7): > i18n: New keywords for xgettext extraction from sh > i18n: rebase: mark strings for translation > i18n: Rewri

Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-22 Thread Jiang Xin
2012/7/23 Junio C Hamano : > I do not understand why many of these have Stefano's S-o-b in them. > If you are relaying what Stefano originally wrote, then the author > (i.e. "From: ") and the first S-o-b would say Stefano, and your > S-o-b will follow it, but that is probably not the case. > I'll d

Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-22 Thread Junio C Hamano
Jiang Xin writes: > 2012/7/23 Junio C Hamano : >> I do not understand why many of these have Stefano's S-o-b in them. >> If you are relaying what Stefano originally wrote, then the author >> (i.e. "From: ") and the first S-o-b would say Stefano, and your >> S-o-b will follow it, but that is proba

Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-23 Thread Jiang Xin
2012/7/23 Junio C Hamano : >> I find one test case failed, and correct it in PATCH 3/7. > > That test used i18ncmp already, so the update to expected string > would be sufficient. I was worried if there were existing tests > that have been expecting that the output from am/rebase/merge would > not

Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-23 Thread Nguyen Thai Ngoc Duy
On Mon, Jul 23, 2012 at 2:32 PM, Jiang Xin wrote: > If build git with GETTEXT_POISON and test, lots of test cases failed. > It seems that we haven't run these test cases for i18n for a long time. Gaah.. I should have resent the poison-fix series but so far procrastination is winning. Will do it s

Re: [PATCH v2 0/7] i18n for git-am, git-rebase and git-merge

2012-07-23 Thread Jiang Xin
2012/7/23 Nguyen Thai Ngoc Duy : > On Mon, Jul 23, 2012 at 2:32 PM, Jiang Xin wrote: >> If build git with GETTEXT_POISON and test, lots of test cases failed. >> It seems that we haven't run these test cases for i18n for a long time. > > Gaah.. I should have resent the poison-fix series but so far