Merged #1341 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1341#event-13836577291
You are receiving this because you are subscribed to this thread.
Message ID:
> What's still missing is updating the required Geany API once we bump it in
> Geany.
Done now. This PR is complete from my point of view.
Unless there are any objections, I'll squash all the commits into one and merge
this PR in about a week.
--
Reply to this email directly or view it on Git
@techee pushed 1 commit.
c00e96f3cffae558ea43d2bb5dd4a0434dbcd1b8 Mention that search is performed both
in open and project files in README
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1341/files/481f688f3b911ef000e859b02f51305ea5f3ec83..c00e96f3cffae558ea43d2bb5dd4a0434db
@techee pushed 1 commit.
481f688f3b911ef000e859b02f51305ea5f3ec83 Update required Geany API level
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1341/files/52ad718c2a847c145781d8b0750984e4f713364e..481f688f3b911ef000e859b02f51305ea5f3ec83
You are receiving this because you ar
I've updated this PR to use https://github.com/geany/geany/pull/3916. What's
still missing is updating the required Geany API once we bump it in Geany.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1341#issuecomment-2198664923
You are receiving
@techee pushed 1 commit.
52ad718c2a847c145781d8b0750984e4f713364e Use newly introduced Geany API to
access symbol icons
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1341/files/4e9eb962e79cca3b0939f41729536d75aafa334e..52ad718c2a847c145781d8b0750984e4f713364e
You are receiv
> Apart from that, I was kind of disappointed that the "goto file" only lists
> Geany open documents rather than the project's documents -- maybe you'd like
> to add that?
Done in the last commit - open files are sorted before project files and also
non-open project files don't have any icon in
@techee commented on this pull request.
> +
+ if (!symbols)
+ return ret;
+
+ tf_strv = g_strsplit_set(filter, " ", -1);
+
+ for (i = 0; i < symbols->len && j < 100; i++)
+ {
+ PrjorgGotoSymbol *symbol = symbols->pdata[i];
+ gchar
@techee commented on this pull request.
> +
+ case GDK_KEY_Return:
+ case GDK_KEY_KP_Enter:
+ case GDK_KEY_ISO_Enter:
+
tree_view_activate_focused_row(GTK_TREE_VIEW(panel_data.tree_view));
+ return TRUE;
+
+
@techee commented on this pull request.
> + gtk_icon_size_lookup(GTK_ICON_SIZE_MENU, &x, &dummy);
+ }
+ return gtk_icon_theme_load_icon(icon_theme, icon_name, x, 0, NULL);
+}
+
+
+static GdkPixbuf *get_icon_pixbuf(gint icon)
+{
+ if (!geany_icons[_ICON_CLASS].pixbuf
@techee commented on this pull request.
> + }
+ pos = new_pos;
+ }
+ end_pos = pos;
+
+ if (start_pos == end_pos)
+ return NULL;
+
+ return sci_get_contents_range(sci, start_pos, end_pos);
+}
+
+
+static void goto_panel_query(const
@techee commented on this pull request.
> + GPtrArray *arr = g_ptr_array_new_full(0,
> (GDestroyNotify)prjorg_goto_symbol_free);
+ gint lineno = atoi(line_str);
+ gint linenum = sci_get_line_count(doc->editor->sci);
+ guint i;
+
+ for (i = 0; i < 4; i++)
+ {
+
@techee pushed 6 commits.
6a541d0ab820d830bd0a49c10681c67a9153200d Add translator comments to file
navigation strings
4638f25f4ff3dd4cc9e6d270ce7e5168eb20062d Avoid possible NULL pointer
dereferences and fix some related problems
290c9a36a08fdffcf587822ee593dc18e6c62aa1 Formatting
5bf7b1ecb44
@b4n Thanks for having a look at it - I'll address the changes you suggested.
> Apart from that, I was kind of disappointed that the "goto file" only lists
> Geany open documents rather than the project's documents -- maybe you'd like
> to add that?
Definitely makes sense for projectorganizer w
@b4n requested changes on this pull request.
LGTM, see inline comments.
Apart from that, I was kind of disappointed that the "goto file" only lists
Geany open documents rather than the project's documents -- maybe you'd like to
add that?
Also, I hoped to be able to go to a specific file's line,
15 matches
Mail list logo
