[gwt-contrib] [google-web-toolkit commit] r5210 - Rollback r5208, since it is failing on IE7.

2009-04-09 Thread codesite-noreply
Author: j...@google.com Date: Thu Apr 9 22:35:06 2009 New Revision: 5210 Removed: trunk/user/src/com/google/gwt/jsonp/ trunk/user/test/com/google/gwt/jsonp/ Log: Rollback r5208, since it is failing on IE7. --~--~-~--~~~---~--~~ http://groups.google.com/

[gwt-contrib] Re: code review requested - add JSONP suport

2009-04-09 Thread John Tamplin
On Thu, Apr 9, 2009 at 7:25 PM, John Tamplin wrote: > Committed to trunk at r5208. Rolled back in r5210, since it was breaking the build on IE7. @Daniel: any ideas? -- Testsuite: com.google.gwt.jsonp.JsonpRequestSuite Tests run: 13, Failures: 0, Errors: 11, Time elapsed: 47.638 sec Testcase:

[gwt-contrib] [google-web-toolkit commit] r5209 - Added a hack to confirm that the flaky RPCSuite failure is what we think it is.

2009-04-09 Thread codesite-noreply
Author: sco...@google.com Date: Thu Apr 9 20:28:46 2009 New Revision: 5209 Modified: trunk/user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java Log: Added a hack to confirm that the flaky RPCSuite failure is what we think it is. Review by: bobv (TBR) Modified: trunk

[gwt-contrib] Re: TOT (rev 5208) broken?

2009-04-09 Thread Scott Blum
I am, I'm only doing fun stuff. :) On Thu, Apr 9, 2009 at 10:03 PM, Vitali Lovich wrote: > Thanks, that fixed it. > > Shouldn't you be on vacation :D? > > > On Thu, Apr 9, 2009 at 9:44 PM, Scott Blum wrote: > >> Try an 'ant clean' >> >> >> On Thu, Apr 9, 2009 at 9:30 PM, Vitali Lovich wrote: >

[gwt-contrib] Re: TOT (rev 5208) broken?

2009-04-09 Thread Vitali Lovich
Thanks, that fixed it. Shouldn't you be on vacation :D? On Thu, Apr 9, 2009 at 9:44 PM, Scott Blum wrote: > Try an 'ant clean' > > > On Thu, Apr 9, 2009 at 9:30 PM, Vitali Lovich wrote: > >> I'd just like to confirm that ToT is indeed broken right now. Same thing >> happens when I try to run

[gwt-contrib] Re: TOT (rev 5208) broken?

2009-04-09 Thread Scott Blum
Try an 'ant clean' On Thu, Apr 9, 2009 at 9:30 PM, Vitali Lovich wrote: > I'd just like to confirm that ToT is indeed broken right now. Same thing > happens when I try to run in hosted mode. > > Getting > [java] Loading module '' > [java][ERROR] Unexpected error while processing X

[gwt-contrib] TOT (rev 5208) broken?

2009-04-09 Thread Vitali Lovich
I'd just like to confirm that ToT is indeed broken right now. Same thing happens when I try to run in hosted mode. Getting [java] Loading module '' [java][ERROR] Unexpected error while processing XML [java] java.lang.IncompatibleClassChangeError: Found interface com.google.gwt.

[gwt-contrib] [google-web-toolkit commit] r5208 - Add JSONP support.

2009-04-09 Thread codesite-noreply
Author: j...@google.com Date: Thu Apr 9 16:25:16 2009 New Revision: 5208 Added: trunk/user/src/com/google/gwt/jsonp/ trunk/user/src/com/google/gwt/jsonp/Jsonp.gwt.xml trunk/user/src/com/google/gwt/jsonp/client/ trunk/user/src/com/google/gwt/jsonp/client/JsonpRequest.java (con

[gwt-contrib] Re: code review requested - add JSONP suport

2009-04-09 Thread John Tamplin
On Mon, Apr 6, 2009 at 7:22 PM, John Tamplin wrote: > The attached patch for trunk adds JSONP support, for use with cross-site > data retrieval, such as GData APIs. > Committed to trunk at r5208. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~-

[gwt-contrib] Re: review request: clean up the RPC compile-time noise

2009-04-09 Thread Freeland Abbott
Isn't that achieved by the auxiliary warnings? Or do you mean you want them all listed in the one error message, or am I misunderstandinging the scenario you describe? On Thu, Apr 9, 2009 at 3:26 PM, Lex Spoon wrote: > Thanks! > > The overall report layout is a big improvement. We are going to

[gwt-contrib] Re: One last memory review

2009-04-09 Thread Scott Blum
Thanks, Ray (and Bruce). I showed Anna this thread and she totally ROFLed. Then she told me if I don't stop working you guys really will need an insurance policy on me. ;) On Thu, Apr 9, 2009 at 5:26 PM, Ray Cromwell wrote: > > I hope Google takes out an extra insurance policy so that should a

[gwt-contrib] Re: One last memory review

2009-04-09 Thread Ray Cromwell
I hope Google takes out an extra insurance policy so that should an accident occur, they can cryogenically freeze your brain and thaw you out in the future in case there are any outstanding compiler issues no one has been able to fix. :) -Ray On Thu, Apr 9, 2009 at 10:24 AM, Scott Blum wrote: >

[gwt-contrib] [google-web-toolkit commit] r5207 - When sharded precompiles are on, force the option "retain

2009-04-09 Thread codesite-noreply
Author: sp...@google.com Date: Thu Apr 9 14:07:53 2009 New Revision: 5207 Modified: trunk/dev/core/src/com/google/gwt/dev/Precompile.java Log: When sharded precompiles are on, force the option "retain compilation state" to be on except for the last precompile shard. Otherwise, state is dis

[gwt-contrib] Re: RR: don't discard compilation state when sharding precompiles

2009-04-09 Thread Lex Spoon
Thanks! It's in at r5207. The variable name now has a full complement of e's. -Lex On Thu, Apr 9, 2009 at 5:01 PM, Scott Blum wrote: > LGTM, except for misspelled variable name. :-) > > On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon wrote: >> >> On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote

[gwt-contrib] Re: RR: don't discard compilation state when sharding precompiles

2009-04-09 Thread Scott Blum
LGTM, except for misspelled variable name. :-) On Thu, Apr 9, 2009 at 1:45 PM, Lex Spoon wrote: > On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote: > > Oh, a concrete reason occurred to me this morning why we'd rather have > the > > logic in Precompile.run() that binds using OptionCompilationS

[gwt-contrib] Re: review request: clean up the RPC compile-time noise

2009-04-09 Thread Lex Spoon
Thanks! The overall report layout is a big improvement. We are going to see fewer messages where all we can do is decode the messages for people. I like the three message levels. Cool. Looking at the report, I still have a slight preference for listing out the subtypes that were tried if ther

[gwt-contrib] [google-web-toolkit commit] r5206 - Rolls back r5075. It's causing mysterious failures, and nobody

2009-04-09 Thread codesite-noreply
Author: sp...@google.com Date: Thu Apr 9 11:25:44 2009 New Revision: 5206 Modified: trunk/user/src/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilder.java trunk/user/test/com/google/gwt/user/rebind/rpc/SerializableTypeOracleBuilderTest.java Log: Rolls back r5075. It's cau

[gwt-contrib] Re: RR: don't discard compilation state when sharding precompiles

2009-04-09 Thread Lex Spoon
On Thu, Apr 9, 2009 at 11:27 AM, Scott Blum wrote: > Oh, a concrete reason occurred to me this morning why we'd rather have the > logic in Precompile.run() that binds using OptionCompilationStateRetained > with OptionMaxPermsPerCompile: > You'd actually like to turn off OptionCompilationStateRetai

[gwt-contrib] Re: One last memory review

2009-04-09 Thread Scott Blum
Don't worry, I'm getting plenty of naps in during the hour-long hyperbaric sessions I do with Aaron. Which is, good, since we have to get up at 7 to make the morning ones. :) But we're having some fun too. Aaron and I just got back from hanging out at the pool and soaking up some sun. Aaron pre

[gwt-contrib] [google-web-toolkit commit] r5204 - Tweak pretty-printed Java source output for proper indentation on JSNI methods.

2009-04-09 Thread codesite-noreply
Author: sco...@google.com Date: Thu Apr 9 08:42:49 2009 New Revision: 5204 Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/impl/SourceGenerationVisitor.java trunk/dev/core/src/com/google/gwt/dev/jjs/impl/ToStringGenerationVisitor.java trunk/dev/core/src/com/google/gwt/dev/js/

[gwt-contrib] [google-web-toolkit commit] r5205 - Changes MakeCallsStatic so that it does not devirtualize calls from

2009-04-09 Thread codesite-noreply
Author: sp...@google.com Date: Thu Apr 9 09:06:36 2009 New Revision: 5205 Modified: trunk/dev/core/src/com/google/gwt/dev/jjs/impl/CodeSplitter.java trunk/dev/core/src/com/google/gwt/dev/jjs/impl/MakeCallsStatic.java Log: Changes MakeCallsStatic so that it does not devirtualize calls fr

[gwt-contrib] Re: One last memory review

2009-04-09 Thread Bruce Johnson
w00t! Vacation commits FTW! (Just kidding; @Scott: please rest) On Thu, Apr 9, 2009 at 11:52 AM, Scott Blum wrote: > FYI: I just committed the last of my outstanding memory work to trunk. Lex > kindly agreed to watch the build and do a roll-back for me if something > breaks. > > > On Tue, Apr 7

[gwt-contrib] [google-web-toolkit commit] r5203 - Make Link run faster and use less heap by caching big objects to disk.

2009-04-09 Thread codesite-noreply
Author: sco...@google.com Date: Thu Apr 9 08:42:18 2009 New Revision: 5203 Modified: trunk/dev/core/src/com/google/gwt/core/ext/linker/CompilationResult.java trunk/dev/core/src/com/google/gwt/core/ext/linker/SyntheticArtifact.java trunk/dev/core/src/com/google/gwt/core/ext/linker/i

[gwt-contrib] Re: One last memory review

2009-04-09 Thread Scott Blum
FYI: I just committed the last of my outstanding memory work to trunk. Lex kindly agreed to watch the build and do a roll-back for me if something breaks. On Tue, Apr 7, 2009 at 10:33 PM, Scott Blum wrote: > On Tue, Apr 7, 2009 at 4:12 PM, Lex Spoon wrote: > >> > 5178: Also tightened up the re

[gwt-contrib] Re: RR: don't discard compilation state when sharding precompiles

2009-04-09 Thread Scott Blum
Oh, a concrete reason occurred to me this morning why we'd rather have the logic in Precompile.run() that binds using OptionCompilationStateRetained with OptionMaxPermsPerCompile: You'd actually like to turn off OptionCompilationStateRetained on the final pass, I mean, the last set of precompilatio

[gwt-contrib] Re: trivial build.xml fix for simplerpc

2009-04-09 Thread Amit Manjhi
Good catch. LGTM. On Wed, Apr 8, 2009 at 11:02 PM, Freeland Abbott wrote: > It's not included in our distro, which is why we haven't HAD to fix it > since... um... r558. :-/  But it should still build if asked to. > (Amit, I picked you more or less at random, to be a value of !scottb. >  Sorry..

[gwt-contrib] Re: RR: don't discard compilation state when sharding precompiles

2009-04-09 Thread Lex Spoon
On Wed, Apr 8, 2009 at 11:17 AM, John Tamplin wrote: > On Wed, Apr 8, 2009 at 11:00 AM, Lex Spoon wrote: >> >> Scott, when you get back, can you review this tiny patch, or propose a >> different way to solve the problem? >> >> The problem is that when precompiles are sharded, it's not actually >