[gwt-contrib] Re: Speed up JsInliner.InliningVisitor.endVisit()

2009-05-26 Thread bobv
http://gwt-code-reviews.appspot.com/34820/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsInliner.java (right): http://gwt-code-reviews.appspot.com/34820/diff/1/2#newcode262 Line 262: public ComplexityEstimator() { } Unnecessary constructor. http://gwt-code-reviews.appspot.com/34820/diff/1/2

[gwt-contrib] Speed up JsInliner.InliningVisitor.endVisit()

2009-05-26 Thread rice
Reviewers: bobv, Description: Currently JsInliner.InliningVisitor.endVisit() tries a sequence of identifiers of the form A_B_ until it finds one that has not been used in the given scope. Profiling indicates that this loop may execute hundreds of times for a given name, accounting for a signific

[gwt-contrib] Re: Fix issue 3677: gwt-module.dtd does not reflect changes to configuration properties

2009-05-26 Thread Fred Sauer
This also addresses: http://code.google.com/p/google-web-toolkit/issues/detail?id=3667 On Tue, May 26, 2009 at 12:32 PM, wrote: > > Reviewers: bobv, > > > > Please review this at http://gwt-code-reviews.appspot.com/34819 > > Affected files: > distro-source/core/src/gwt-module.dtd > > > Index:

[gwt-contrib] Fix issue 3677: gwt-module.dtd does not reflect changes to configuration properties

2009-05-26 Thread rice
Reviewers: bobv, Please review this at http://gwt-code-reviews.appspot.com/34819 Affected files: distro-source/core/src/gwt-module.dtd Index: distro-source/core/src/gwt-module.dtd === --- distro-source/core/src/gwt-module.dtd

[gwt-contrib] [google-web-toolkit commit] r5473 - Merging trunk c5472 into this branch (SingleJsoImpl ClassCircularityError fix)

2009-05-26 Thread codesite-noreply
Author: sco...@google.com Date: Tue May 26 12:01:52 2009 New Revision: 5473 Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt branches/snapshot-2009.05.12-r5406/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java branches/snapshot-2009.05.12-r5406/dev/core/s

[gwt-contrib] [google-web-toolkit commit] r5472 - Fixes a ClassCircularityError that could be triggered computing the super interface hiera...

2009-05-26 Thread codesite-noreply
Author: sco...@google.com Date: Tue May 26 11:56:11 2009 New Revision: 5472 Modified: trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java trunk/dev/core/src/com/google/gwt/dev/shell/rewrite/HostedModeClassRewriter.java trunk/dev/core/src/com/google/gwt/dev/shell/

[gwt-contrib] [google-web-toolkit commit] r5471 - Rolling tr...@5393 out of this branch. The IFRAME XHR change is broken on IE6 hosted and...

2009-05-26 Thread codesite-noreply
Author: sco...@google.com Date: Tue May 26 11:40:15 2009 New Revision: 5471 Modified: branches/snapshot-2009.05.12-r5406/branch-info.txt branches/snapshot-2009.05.12-r5406/dev/core/src/com/google/gwt/core/ext/linker/impl/hosted.html branches/snapshot-2009.05.12-r5406/dev/core/src/

[gwt-contrib] Re: Speedups for -soyc compilation

2009-05-26 Thread דניאל רייס
I see around 2x for the story generation phase. It's hard to measure at the moment because I haven't been able to get a working "before" build so I am estimating based on some numbers jotted down earlier. Dan On Tue, May 26, 2009 at 2:27 PM, Bruce Johnson wrote: > Any numbers on the amount o

[gwt-contrib] Re: Speedups for -soyc compilation

2009-05-26 Thread Bruce Johnson
Any numbers on the amount of improvement? On Tue, May 26, 2009 at 11:04 AM, wrote: > > Reviewers: spoon, kprobst, scottb, > > Description: > This patch incorporates Kathrin's StringBuilder work along with other > miscellaneous speedups found by using JProfiler. > > Please review this at http://g

[gwt-contrib] Speedups for -soyc compilation

2009-05-26 Thread rice
Reviewers: spoon, kprobst, scottb, Description: This patch incorporates Kathrin's StringBuilder work along with other miscellaneous speedups found by using JProfiler. Please review this at http://gwt-code-reviews.appspot.com/34818 Affected files: dev/core/src/com/google/gwt/core/ext/soyc/Ran

[gwt-contrib] Comment on EnumOptimizations in google-web-toolkit

2009-05-26 Thread codesite-noreply
Comment by j...@google.com: That's unfortunate, isn't it? Sounds like we're going to have to take the latter approach if we want to eliminate all those (usually) unnecessary strings. For more information: http://code.google.com/p/google-web-toolkit/wiki/EnumOptimizations --~--~-~--

[gwt-contrib] [google-web-toolkit commit] r5470 - Edited wiki page through web user interface.

2009-05-26 Thread codesite-noreply
Author: tamplinjohn Date: Tue May 26 06:32:14 2009 New Revision: 5470 Modified: wiki/DesignOOPHM.wiki Log: Edited wiki page through web user interface. Modified: wiki/DesignOOPHM.wiki == --- wiki/DesignOOPHM.wiki

[gwt-contrib] Comment on EnumOptimizations in google-web-toolkit

2009-05-26 Thread codesite-noreply
Comment by mark.renouf: toString() returns the same as name() by default For more information: http://code.google.com/p/google-web-toolkit/wiki/EnumOptimizations --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~--