[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Alright, let's go with storing them in GWT_TOOLS for now then. I think once we move

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread John A. Tamplin
John A. Tamplin has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Yes, and many places don't allow build systems unfettered access to the internet, s

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: When I proposed downloading them from Central or Google Code, Goktug (IIRC) told me G

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Seems okay to me in principle. I take it we'll move gwt-dev.jar and gwt-user.jar int

[gwt-contrib] Re: Jenkins test setup

2013-04-14 Thread Thomas Broyer
On Friday, April 12, 2013 10:08:32 AM UTC+2, Thomas Broyer wrote: > > > > On Friday, April 12, 2013 12:44:14 AM UTC+2, Matthew Dempsky wrote: >> >> Once that's working, I'm hoping it's not too much further before we can >> allow commits directly via Gerrit. :-) >> >> > One showstopper, for me,

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 1: Tested it by downloading the 2.5.1 JARs from Central, saving them in GWT_TOOLS/api-ch

[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.

2013-04-14 Thread Thomas Broyer
Thomas Broyer has uploaded a new change for review. https://gwt-review.googlesource.com/2500 Change subject: Removes api-checker reference JARs from the source tree. .. Removes api-checker reference JARs from the source tree

[gwt-contrib] Re: Issue 5525 - Allow EntityProxyId as an argument to a Request Factory service method (issue1899803)

2013-04-14 Thread t . broyer
Sounds good! http://gwt-code-reviews.appspot.com/1899803/diff/5005/user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java File user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java (right): http://gwt-code-reviews.appspot.com/1899803/diff