[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

2012-08-09 Thread skybrian
The idea is that any SingleSelectionModel can be thought of as a set that contains either zero or one items. So it seems appropriate that it should have the new methods - and after all, the whole point is to be able to treat them uniformly. SetSelectionModel isn't intended to imply that the Selec

[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

2012-08-09 Thread tuckerpmt
On 2012/08/09 16:17:26, rkj wrote: Understandable, seems like an extension of SingleSelectionModel to fit your specific case would make the most sense here? http://gwt-code-reviews.appspot.com/1798806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

2012-08-09 Thread tuckerpmt
On 2012/08/08 22:25:10, skybrian wrote: Any reason clear() can't be moved into SelectionModel and not make SingleSelectionModel implement SetSelectionModel? It seems misleading to make SingleSelectionModel extend SetSelectionModel when it only deals with one element. http://gwt-code-reviews.app

[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

2012-08-08 Thread skybrian
Yes, by editing the description in Critique. (I just did that for you.) http://gwt-code-reviews.appspot.com/1798806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added SetSelectionModel interface and made Single- and MultiSelectionModels (issue1798806)

2012-08-08 Thread skybrian
The implementation seems fine. Could you also create a bug in the external GWT issue tracker and add it to the CL description, so we can track when this gets into a stable release? Also, for those coming in late, please add a bit of justification to the issue. All our existing widgets are gettin