[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

ping http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

LGETM I still don't like some of the changes that are being made by these settings (in particular assignments wrap very strangely), but I guess it is as good as we are going to get at the moment. http://gwt-code-reviews.appspot.com/1402803/ --

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

On 2011/04/15 15:35:21, zundel wrote: ping Despite my minor complaints, but this matches what was proposed so LGTM. http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

LGTM http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

I merged up, so rietveld thinks that every file changed, but in fact, there are no changes other than the removal of several files not related to the autoformat. http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

http://gwt-code-reviews.appspot.com/1402803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

I still the the assignment line breaks are really ugly this way, but if others would rather avoid long lines no matter how ugly the result is, I can go with it. http://gwt-code-reviews.appspot.com/1402803/diff/6001/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java File tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java (right):

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java File tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java (right):

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java File tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java (right):

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

cldr-import mostly looks good, but there are a few consistent issues. http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java File tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java

[gwt-contrib] Re: Auto-formats the GWT tools projects (excluding api-checker covered in (issue1402803)

http://gwt-code-reviews.appspot.com/1402803/diff/1/tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java File tools/cldr-import/src/com/google/gwt/tools/cldr/DateTimeFormatInfoProcessor.java (right):