libegg/recentchooser

2005-11-29 Thread Matthias Clasen
Hey Emanuele, in an attempt to get this moving forward again, I spent some time looking at the code thats currently in libegg, and wrote down some random notes. Matthias * eggdesktopbookmarks.[hc]: - Where is the GMarkup parser ? libegg still seems to have libxml - Should the name be egg_d

Re: libegg/recentchooser

2005-11-29 Thread Morten Welinder
That code also needs to be run through Valgrind or Purify. egg_recent_chooser_item_activated_cb, for example, seems to have a double free. timestamp_from_iso8601 manipulates the environment in a way that does not look po[r]table. (And it's not that hard to do using mktime-in-any-timezone, basic

Re: libegg/recentchooser

2005-11-29 Thread Emmanuele Bassi
Hi Matthias, On Tue, 2005-11-29 at 12:18 -0500, Matthias Clasen wrote: > Hey Emanuele, > > in an attempt to get this moving forward again, I spent some time > looking at the code thats currently in libegg, and wrote down some > random notes. Thanks. I'll try and do my best to answer. > > Matt

Re: libegg/recentchooser

2005-11-29 Thread Emmanuele Bassi
Hi, On Tue, 2005-11-29 at 14:56 -0500, Morten Welinder wrote: > That code also needs to be run through Valgrind or Purify. > egg_recent_chooser_item_activated_cb, for example, seems to have > a double free. I'll check it out ASAP. I'm not that good with Valgrind, so any help there would be much

Re: libegg/recentchooser

2005-11-29 Thread James Henstridge
Emmanuele Bassi wrote: >Hi, > >On Tue, 2005-11-29 at 14:56 -0500, Morten Welinder wrote: > > >>That code also needs to be run through Valgrind or Purify. >>egg_recent_chooser_item_activated_cb, for example, seems to have >>a double free. >> >> > >I'll check it out ASAP. > >I'm not that good

Re: libegg/recentchooser

2005-11-30 Thread Emmanuele Bassi
Hi James, On Wed, 2005-11-30 at 11:23 +0800, James Henstridge wrote: > Emmanuele Bassi wrote: > > >Uhm, I'll put that code under #idef G_OS_UNIX/#endif guards for the time > >being, but the getenv("TZ")/setenv("TZ") timezone trick should work on > >any sufficiently recent POSIX-like system; users

Re: libegg/recentchooser

2005-11-30 Thread Morten Welinder
> Uhm, I'll put that code under #idef G_OS_UNIX/#endif guards for the time > being, but the getenv("TZ")/setenv("TZ") timezone trick should work on > any sufficiently recent POSIX-like system; users of other operating > systems might just drop me an email. setenv isn't POSIX. You can probably ju

Re: libegg/recentchooser

2005-12-01 Thread Emmanuele Bassi
Hi Morten, On Wed, 2005-11-30 at 19:58 -0500, Morten Welinder wrote: > > Uhm, I'll put that code under #idef G_OS_UNIX/#endif guards for the time > > being, but the getenv("TZ")/setenv("TZ") timezone trick should work on > > any sufficiently recent POSIX-like system; users of other operating > > s

Re: libegg/recentchooser

2005-12-01 Thread James Henstridge
Emmanuele Bassi wrote: >Hi Morten, > >On Wed, 2005-11-30 at 19:58 -0500, Morten Welinder wrote: > > >>>Uhm, I'll put that code under #idef G_OS_UNIX/#endif guards for the time >>>being, but the getenv("TZ")/setenv("TZ") timezone trick should work on >>>any sufficiently recent POSIX-like system;