Re: [RFC] Use LLVM_BUILD_LLVM_DYLIB instead of BUILD_SHARED_LIBS

2022-09-12 Thread Maxim Cournoyer
Hi Maxime, Maxime Devos writes: > On 20-04-2022 12:56, Zhu Zihao wrote: >> We may introduce following problems if we apply this solution. >> >> 1. Increase the closure size of LLVM. >> >> By default, if LLVM_BUILD_LLVM_DYLIB is set true, LLVM still tries to >> build the static archive. This may

Re: [RFC] Use LLVM_BUILD_LLVM_DYLIB instead of BUILD_SHARED_LIBS

2022-08-26 Thread Maxime Devos
On 20-04-2022 12:56, Zhu Zihao wrote: We may introduce following problems if we apply this solution. 1. Increase the closure size of LLVM. By default, if LLVM_BUILD_LLVM_DYLIB is set true, LLVM still tries to build the static archive. This may increase the closure size of LLVM. And some

Re: [RFC] Use LLVM_BUILD_LLVM_DYLIB instead of BUILD_SHARED_LIBS

2022-08-26 Thread John Kehayias
Hello, On Mon, Aug 22, 2022 at 11:57 PM, Maxim Cournoyer wrote: > Zhu Zihao writes: > [...] > >> # Solution >> >> I suggest to replace `-DBUILD_SHARED_LIBS:BOOL=TRUE` with >> `-DLLVM_BUILD_LLVM_DYLIB:BOOL=TRUE`. > > That's something I had been meaning to do for some time, but it fell > into the

Re: [RFC] Use LLVM_BUILD_LLVM_DYLIB instead of BUILD_SHARED_LIBS

2022-08-22 Thread Maxim Cournoyer
Hi, Zhu Zihao writes: > # Background > > Now in Guix. LLVM is built with configure flag > "-DBUILD_SHARED_LIBS:BOOL=TRUE". According to > https://llvm.org/docs/CMake.html. Build LLVM with `BUILD_SHARED_LIBS` is > not recommended for non LLVM developing usage. LLVM says that packager > should

[RFC] Use LLVM_BUILD_LLVM_DYLIB instead of BUILD_SHARED_LIBS

2022-08-20 Thread Zhu Zihao
# Background Now in Guix. LLVM is built with configure flag "-DBUILD_SHARED_LIBS:BOOL=TRUE". According to https://llvm.org/docs/CMake.html. Build LLVM with `BUILD_SHARED_LIBS` is not recommended for non LLVM developing usage. LLVM says that packager should use `LLVM_BUILD_LLVM_DYLIB` instead.