Re: Golang check phase skipping some tests?

2024-02-15 Thread Simon Tournier
Hi, On jeu., 15 févr. 2024 at 10:10, Sharlatan Hellseher wrote: > I would push go-team branch to check some lower level modifications to > go-build-system which are queued right now. I need someone with admin access > to > set the branch on CI as well ;-) Cool! Thank you. Cheers, simon

Re: Golang check phase skipping some tests?

2024-02-15 Thread Sharlatan Hellseher
Hi Simon! > What is the status of this? Is all fine? There are new modules available which I use for moving packages from golang.scm and other places e.g. syncthing.scm. - golang-build.scm - golang-check.scm - golang-compression.scm - golang-crypto.scm - golang-web.scm - golang-xyz.scm I

Re: Golang check phase skipping some tests?

2024-02-15 Thread Simon Tournier
Hi, Late to the party. :-) Processing my backlog… On jeu., 18 janv. 2024 at 10:25, Sharlatan Hellseher wrote: > I'm currently in review and split some packages from (gnu packages golang) > into > (gnu packages golang-crypto) to simplify the maintenance. I try to play with > that option and

Re: Golang check phase skipping some tests?

2024-02-05 Thread Troy Figiel
Hi Oleg (and the go-team), As I have spent some time with the go-build-system, I have a couple of extra suggestions/ideas. Obviously, as the person suggesting these changes, I would be more than happy to help implement them. This will unfortunately be a rather lengthy and very information-dense

Re: Golang check phase skipping some tests?

2024-01-31 Thread Troy Figiel
Hi Oleg, Small update to give you some numbers. Looking through gnu/packages/ I found a total of 593 packages using the go-build-system. With guix refresh -l, I find 1449 dependent packages. I am currently at commit bed3a0b547a59f63b545db165e76ddd9af8bba1a. Take this as a rough estimate, since I

Re: Golang check phase skipping some tests?

2024-01-21 Thread Maxim Cournoyer
Hi Sharlatan, Sharlatan Hellseher writes: > Hi Maxim, > > Thank you for detailed replay. > >> The branch workflow for teams is to use a *-team branch that is short >> lived, e.g. for the time needed to do the integration work; with an >> associated job spec in Cuirass (ci.guix.gnu.org) to build

Re: Golang check phase skipping some tests?

2024-01-19 Thread Sharlatan Hellseher
Hi Maxim, Thank you for detailed replay. > The branch workflow for teams is to use a *-team branch that is short > lived, e.g. for the time needed to do the integration work; with an > associated job spec in Cuirass (ci.guix.gnu.org) to build it. Am I ok to push new go-team branch? And I'll

Re: Golang check phase skipping some tests?

2024-01-19 Thread Maxim Cournoyer
Hi Sharlatan, Sharlatan Hellseher writes: > Hi Maxim, > > You mentioned go-team branch which I tried to find :-) > > Is there any formal procedure to push new branches? > I might need a branch to push changes from the split task > instead of sending patches. The branch workflow for teams is to

Re: Golang check phase skipping some tests?

2024-01-18 Thread Sharlatan Hellseher
Hi, There are not too many Golang packages in Guix comparing to other language spectific modules: --8<---cut here---start->8--- grep -r "build-system go-build-system" gnu/packages | awk '{print $1}' | sort | uniq -c | sort -rn 382 gnu/packages/golang.scm:

Re: Golang check phase skipping some tests?

2024-01-18 Thread Troy Figiel
Hi Oleg and others, On 2024-01-18 11:25, Sharlatan Hellseher wrote: > With small adjustment of the invok line, I could manage to trigger all tests > to > be run, but it brings other issue of some not packed modules required for the > check phase. Thanks for the update! I noticed the same with

Re: Golang check phase skipping some tests?

2024-01-18 Thread Maxim Cournoyer
Hi Oleg, Sharlatan Hellseher writes: > Hi, > > I can't say that I'm an expert in Golang :-), but I've got some experience in > building and deploying Glang daily for some time. > > First things first the default behaviour of `go test ./...` is like this: > > find * -type f -name *_test.go | >

Re: Golang check phase skipping some tests?

2024-01-18 Thread Sharlatan Hellseher
Hi, I can't say that I'm an expert in Golang :-), but I've got some experience in building and deploying Glang daily for some time. First things first the default behaviour of `go test ./...` is like this: --8<---cut here---start->8--- find * -type f -name

Re: Golang check phase skipping some tests?

2024-01-17 Thread Simon Tournier
Hi, CC: $ ./etc/teams.scm list-members go Katherine Cox-Buday Sharlatan Hellseher On Sun, 14 Jan 2024 at 22:12, Troy Figiel wrote: > --8<---cut here---start->8--- > (define* (check #:key tests? import-path #:allow-other-keys) > "Run the

Re: Golang check phase skipping some tests?

2024-01-17 Thread Maxim Cournoyer
Hi Tomas, Tomas Volf <~@wolfsden.cz> writes: > On 2024-01-14 22:12:38 +0100, Troy Figiel wrote: >> Hi everyone, >> >> When looking into the Go build system, I noticed the default check phase >> runs (invoke "go" "test" import-path), which only runs the tests in the >> root directory of the

Re: Golang check phase skipping some tests?

2024-01-16 Thread Tomas Volf
On 2024-01-14 22:12:38 +0100, Troy Figiel wrote: > Hi everyone, > > When looking into the Go build system, I noticed the default check phase > runs (invoke "go" "test" import-path), which only runs the tests in the > root directory of the source. Running the tests in all subdirectories > would

Golang check phase skipping some tests?

2024-01-15 Thread Troy Figiel
Hi everyone, When looking into the Go build system, I noticed the default check phase runs (invoke "go" "test" import-path), which only runs the tests in the root directory of the source. Running the tests in all subdirectories would require something like this instead: --8<---cut