Re: QA is back, who wants to review patches?

2024-02-11 Thread Ian Eure
Christopher Baines writes: [[PGP Signed Part:Undecided]] Hey! After substitute availability taking a bit of a dive recently, the bordeaux build farm has finally caught back up and QA is back submitting builds for packages changed by patches. QA also has a feature to allow easily tagging

Re: QA is back, who wants to review patches?

2024-02-11 Thread Andreas Enge
Am Fri, Feb 09, 2024 at 04:08:45PM +0100 schrieb Tanguy LE CARROUR: > I’m "reviewing" `[bug#68997] gnu: lightning: Update to 2.2.3`… please > find another one!  Now that you jump to complicated and not even yet built by QA packages, you are safe from my competition :) Andreas

Re: QA is back, who wants to review patches?

2024-02-10 Thread Christopher Baines
Vivien Kraus writes: > Hello Chris, > > Le vendredi 09 février 2024 à 10:44 +, Christopher Baines a écrit : >> Let me know if you have any comments or questions! > > Thank you for all your work on QA. > > I can’t help but notice QA is missing a few patches. For instance, >

Re: QA is back, who wants to review patches?

2024-02-10 Thread Christopher Baines
Vivien Kraus writes: > Dear QA wizards, > > Le vendredi 09 février 2024 à 10:44 +, Christopher Baines a écrit : >> You just need to not be involved (so you can't review your >> own patches) > > I interpret this as it’s OK to review patches if you asked for a change > in the thread, am I

Re: QA is back, who wants to review patches?

2024-02-10 Thread Vivien Kraus
Hello Chris, Le vendredi 09 février 2024 à 10:44 +, Christopher Baines a écrit : > Let me know if you have any comments or questions! Thank you for all your work on QA. I can’t help but notice QA is missing a few patches. For instance, issues.guix.gnu.org lists 7 open issues with patches

Re: QA is back, who wants to review patches?

2024-02-10 Thread Vivien Kraus
Dear QA wizards, Le vendredi 09 février 2024 à 10:44 +, Christopher Baines a écrit : > You just need to not be involved (so you can't review your > own patches) I interpret this as it’s OK to review patches if you asked for a change in the thread, am I correct? Or is this too much

Re: QA is back, who wants to review patches?

2024-02-09 Thread Christopher Baines
Andreas Enge writes: > I see a few "Failed to process revision", for instance here: >https://qa.guix.gnu.org/issue/68778 > While I am not sure why, these look like transient (?) build failures, > at least failures not related to the patch in question. What is there to do? Long term it

Re: QA is back, who wants to review patches?

2024-02-09 Thread Tanguy LE CARROUR
Quoting Andreas Enge (2024-02-09 15:30:44) > Am Fri, Feb 09, 2024 at 02:53:59PM +0100 schrieb Tanguy LE CARROUR: > > Quoting Christopher Baines (2024-02-09 14:44:25) > > > Tanguy LE CARROUR writes: > > > > Can I safely close it?! > > > > > > Yep, this unfortunately looks like a case where there

Re: QA is back, who wants to review patches?

2024-02-09 Thread Andreas Enge
Hello, I see a few "Failed to process revision", for instance here: https://qa.guix.gnu.org/issue/68778 While I am not sure why, these look like transient (?) build failures, at least failures not related to the patch in question. What is there to do? Andreas

Re: QA is back, who wants to review patches?

2024-02-09 Thread Andreas Enge
Am Fri, Feb 09, 2024 at 02:53:59PM +0100 schrieb Tanguy LE CARROUR: > Quoting Christopher Baines (2024-02-09 14:44:25) > > Tanguy LE CARROUR writes: > > > Can I safely close it?! > > > > Yep, this unfortunately looks like a case where there was a duplication > > of effort and the original patch

Re: QA is back, who wants to review patches?

2024-02-09 Thread Tanguy LE CARROUR
Quoting Christopher Baines (2024-02-09 14:44:25) > Tanguy LE CARROUR writes: > > Can I safely close it?! > > Yep, this unfortunately looks like a case where there was a duplication > of effort and the original patch got ignored. > > It looks like the issue has been closed now. Not me! 

Re: QA is back, who wants to review patches?

2024-02-09 Thread Christopher Baines
Tanguy LE CARROUR writes: > Hi Chris, > > First of, thanks (again) for everything that you’ve done with QA! > It looks great! > > > Quoting Christopher Baines (2024-02-09 11:44:11) >> Let me know if you have any comments or questions! > > Unfortunately, I have some (stupid) questions! > > I

Re: QA is back, who wants to review patches?

2024-02-09 Thread Tanguy LE CARROUR
Hi Chris, First of, thanks (again) for everything that you’ve done with QA! It looks great! Quoting Christopher Baines (2024-02-09 11:44:11) > Let me know if you have any comments or questions! Unfortunately, I have some (stupid) questions! I decided to give it a try and I picked at random a

Re: QA is back, who wants to review patches?

2024-02-09 Thread Clément Lassieur
On Fri, Feb 09 2024, Christopher Baines wrote: > After substitute availability taking a bit of a dive recently, the > bordeaux build farm has finally caught back up and QA is back submitting > builds for packages changed by patches. > > QA also has a feature to allow easily tagging patches

QA is back, who wants to review patches?

2024-02-09 Thread Christopher Baines
Hey! After substitute availability taking a bit of a dive recently, the bordeaux build farm has finally caught back up and QA is back submitting builds for packages changed by patches. QA also has a feature to allow easily tagging patches (issues) as having been reviewed and ready to merge