[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520712#comment-16520712
]
Erik Krogen commented on HDFS-12977:
[~vagarychen] I think this is not necessary. By
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519803#comment-16519803
]
Chen Liang commented on HDFS-12977:
---
It seems the name space ID is picked up here by re
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408367#comment-16408367
]
Plamen Jeliazkov commented on HDFS-12977:
-
Thanks you [~shv]. Thanks you [~vagaryc
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405159#comment-16405159
]
Plamen Jeliazkov commented on HDFS-12977:
-
Thanks Konstantin. I propose we address
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403177#comment-16403177
]
Konstantin Shvachko commented on HDFS-12977:
Great! One last thing. Out of tho
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403145#comment-16403145
]
genericqa commented on HDFS-12977:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402622#comment-16402622
]
Plamen Jeliazkov commented on HDFS-12977:
-
Hi [~vagarychen]! Thanks for taking a l
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402512#comment-16402512
]
Chen Liang commented on HDFS-12977:
---
Thanks [~zero45] for working on this! patch looks p
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402485#comment-16402485
]
genericqa commented on HDFS-12977:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402197#comment-16402197
]
Plamen Jeliazkov commented on HDFS-12977:
-
I missed one checkstyle warning and som
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401389#comment-16401389
]
genericqa commented on HDFS-12977:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16401205#comment-16401205
]
Plamen Jeliazkov commented on HDFS-12977:
-
Thanks for the thorough review Konstant
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399808#comment-16399808
]
Konstantin Shvachko commented on HDFS-12977:
Great progress, Plamen. Few edito
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399424#comment-16399424
]
genericqa commented on HDFS-12977:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398897#comment-16398897
]
Plamen Jeliazkov commented on HDFS-12977:
-
Attached new patch with whitespace chan
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397798#comment-16397798
]
genericqa commented on HDFS-12977:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397440#comment-16397440
]
Plamen Jeliazkov commented on HDFS-12977:
-
I think with this edition of the patch
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397434#comment-16397434
]
Plamen Jeliazkov commented on HDFS-12977:
-
I spoke with Konstantin offline and con
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396403#comment-16396403
]
Konstantin Shvachko commented on HDFS-12977:
Was looking into this and realize
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386960#comment-16386960
]
Plamen Jeliazkov commented on HDFS-12977:
-
Hey Konst,
My logic around (1) had bee
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376246#comment-16376246
]
Konstantin Shvachko commented on HDFS-12977:
Liked the patch Palmen, this is o
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372125#comment-16372125
]
Plamen Jeliazkov commented on HDFS-12977:
-
Attached new patch.
I created two new
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370481#comment-16370481
]
Plamen Jeliazkov commented on HDFS-12977:
-
Thanks for taking a look Konstantin.
W
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368689#comment-16368689
]
Konstantin Shvachko commented on HDFS-12977:
I agree try/finally look excessiv
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366464#comment-16366464
]
Plamen Jeliazkov commented on HDFS-12977:
-
Attaching a rough first patch.
All the
[
https://issues.apache.org/jira/browse/HDFS-12977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366457#comment-16366457
]
Plamen Jeliazkov commented on HDFS-12977:
-
Hey Konstantin, I'd like to take this u
26 matches
Mail list logo