[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983127#comment-16983127 ] Hudson commented on HDFS-14649: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16983121#comment-16983121 ] Yiqun Lin commented on HDFS-14649: -- The latest patch LGTM, +1. > Add suspect probe for

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982617#comment-16982617 ] Hadoop QA commented on HDFS-14649: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982570#comment-16982570 ] Lisheng Sun commented on HDFS-14649: {quote} We can introduce one additional variable

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982366#comment-16982366 ] Hadoop QA commented on HDFS-14649: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-26 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982255#comment-16982255 ] Yiqun Lin commented on HDFS-14649: -- Some review comments for the unit test: * We can in

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-25 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981894#comment-16981894 ] Hadoop QA commented on HDFS-14649: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-25 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981612#comment-16981612 ] Yiqun Lin commented on HDFS-14649: -- [~leosun08], we can add a corner case that the node

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-25 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981439#comment-16981439 ] Lisheng Sun commented on HDFS-14649: hi [~linyiqun] {quote} We need a additional unit

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981297#comment-16981297 ] Hadoop QA commented on HDFS-14649: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-24 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981285#comment-16981285 ] Yiqun Lin commented on HDFS-14649: -- I think I almost got the idea from the latest patch,

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-24 Thread Yiqun Lin (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981269#comment-16981269 ] Yiqun Lin commented on HDFS-14649: -- Hi [~leosun08], can you have a summary note for this

[jira] [Commented] (HDFS-14649) Add suspect probe for DeadNodeDetector

2019-11-24 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981153#comment-16981153 ] Hadoop QA commented on HDFS-14649: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote