[jira] [Commented] (HDFS-3976) SampleQuantiles#query is O(N^2) instead of O(N)

2012-09-28 Thread Aaron T. Myers (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466054#comment-13466054 ] Aaron T. Myers commented on HDFS-3976: -- The patch looks good to me as well. Committing

[jira] [Commented] (HDFS-3976) SampleQuantiles#query is O(N^2) instead of O(N)

2012-09-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463460#comment-13463460 ] Hadoop QA commented on HDFS-3976: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-3976) SampleQuantiles#query is O(N^2) instead of O(N)

2012-09-25 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463358#comment-13463358 ] Todd Lipcon commented on HDFS-3976: --- I guess what you're doing now makes more sense then,

[jira] [Commented] (HDFS-3976) SampleQuantiles#query is O(N^2) instead of O(N)

2012-09-25 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463349#comment-13463349 ] Andrew Wang commented on HDFS-3976: --- I suppose, though I think we need to keep a counter

[jira] [Commented] (HDFS-3976) SampleQuantiles#query is O(N^2) instead of O(N)

2012-09-25 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-3976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463330#comment-13463330 ] Todd Lipcon commented on HDFS-3976: --- While you're at it, why not get rid of size() and nu