[HelenOS-devel] leak in gpt source

Hi all, I found a leak in gpt.c source and I try to fix it. See my attached file. Regards, Manuele === modified file 'uspace/lib/label/src/gpt.c' --- uspace/lib/label/src/gpt.c 2015-11-04 18:39:51 + +++ uspace/lib/label/src/gpt.c 2016-03-15 12:50:21 + @@ -823,8 +823,10 @@ b0 = uint64_t

[HelenOS-devel] memory leak in driver.c

Hi all, I found a memory leak in driver.c. I'm using a software tool to catch, and I already found some errors like this. Can I send a mail for each? Regards, Manuele === modified file 'uspace/lib/drv/generic/driver.c' --- uspace/lib/drv/generic/driver.c 2015-09-30 17:47:41 + +++ uspace/lib/dr

[HelenOS-devel] Fix a memory leak in remote_ahci_get_sata_device_name

Hi all, I found a missing check about malloc fault and memory not deallocated. Regards, Manuele === modified file 'uspace/lib/drv/generic/remote_ahci.c' --- uspace/lib/drv/generic/remote_ahci.c 2015-08-23 12:50:23 + +++ uspace/lib/drv/generic/remote_ahci.c 2016-03-16 13:06:29 + @@ -221,7 +

[HelenOS-devel] Patch: Avoid segfault in nic driver

Hi all, I found a bug in nic_query_address function when a NULL is passed to nic_data parameter. I try to fix it, let me know what do you think. Best regards, Manuele === modified file 'uspace/lib/nic/src/nic_driver.c' --- uspace/lib/nic/src/nic_driver.c 2015-08-23 12:50:23 + +++ uspace/lib/nic

[HelenOS-devel] Duplicate include header

Hi all, I write a patch to remove duplicate include header. This is not a bug but only a "cosmetic" changes. Best regards, Manuele === modified file 'kernel/arch/amd64/src/interrupt.c' --- kernel/arch/amd64/src/interrupt.c 2014-10-09 15:03:55 + +++ kernel/arch/amd64/src/interrupt.c 2016-03-15 1

[HelenOS-devel] (no subject)

Hi all, I create a patch to remove a memory leak when tcp_pdu_create procedure fails. My patch solve this problem but I think that best way to solve it is call tcp_pdu_delete, let me know. Regards, Manuele === modified file 'uspace/srv/net/tcp/pdu.c' --- uspace/srv/net/tcp/pdu.c 2015-05-22 07:21:3

[HelenOS-devel] Remove leak in tcp_pdu_encode

Hi all, I found a memory leak in tcp_pdu_encode function and I try to fix it. Regards, Manuele === modified file 'uspace/srv/net/tcp/pdu.c' --- uspace/srv/net/tcp/pdu.c 2015-05-22 07:21:37 + +++ uspace/srv/net/tcp/pdu.c 2016-03-29 10:06:56 + @@ -333,8 +333,10 @@ text_size = tcp_segment

[HelenOS-devel] Fix memory leak about mkmfs util

Hi All, I found a memory leak in a mkmfs util and I try to fix it. Regards, Manuele === modified file 'uspace/app/mkmfs/mkmfs.c' --- uspace/app/mkmfs/mkmfs.c 2015-08-22 05:12:30 + +++ uspace/app/mkmfs/mkmfs.c 2016-03-30 11:03:04 + @@ -639,8 +639,10 @@ ibmap_buf = malloc(ibmap_nblocks * s

Re: [HelenOS-devel] Fix memory leak about mkmfs util

Hi Jan, You right tomorrow I'll resend my patch with your suggest. Many thanks, Manuele > On 30 Mar 2016, at 15:54, Jan Vesely wrote: > >> On Wed, 2016-03-30 at 13:21 +0200, Manuele Conti wrote: >> Hi All, >> I found a memory leak in a mkmfs util and I try to fix it

Re: [HelenOS-devel] Fix memory leak about mkmfs util

Hi all, this is my patch file without check null pointer before free call. Cheers, Manuele 2016-03-30 13:21 GMT+02:00 Manuele Conti : > Hi All, > I found a memory leak in a mkmfs util and I try to fix it. > > Regards, > Manuele > === modified file 'uspace/app/mkmfs/

[HelenOS-devel] memory leak vbd source

Hi all, I found a memory leak about vbds_get_disks_srv function in vbd.c source. My fix is attached. Best regards, Manuele === modified file 'uspace/srv/bd/vbd/vbd.c' --- uspace/srv/bd/vbd/vbd.c 2015-11-02 20:54:19 + +++ uspace/srv/bd/vbd/vbd.c 2016-03-30 12:33:52 + @@ -106,6 +106,7 @@

[HelenOS-devel] Fix cmd_mkfile

Hi all, I found two possible bug in cmd_mkfile: - File not closed - Memory not deallocated Patch is attached. Let me know. Best regards, Manuele === modified file 'uspace/app/bdsh/cmds/modules/mkfile/mkfile.c' --- uspace/app/bdsh/cmds/modules/mkfile/mkfile.c 2016-03-29 19:36:43 + +++ uspace/a

[HelenOS-devel] fix vfs_ops bug

Hi All, I found a bug in vfs_open function. It is not correctly handled the returned NULL value by vfs_node_get. My patch is attached, let me know. Best regards, Manuele === modified file 'uspace/srv/vfs/vfs_ops.c' --- uspace/srv/vfs/vfs_ops.c 2015-10-06 19:01:36 + +++ uspace/srv/vfs/vfs_ops.c

[HelenOS-devel] Memory leak patch

Hi all, I try to fix a memory leak in dnsr_name2host function. Also I found a missing call to async_forget and I fixed. Let me know. Cheers, Manuele === modified file 'uspace/lib/c/generic/dnsr.c' --- uspace/lib/c/generic/dnsr.c 2015-08-23 12:50:23 + +++ uspace/lib/c/generic/dnsr.c 2016-06-16

[HelenOS-devel] Fix memory leak in gpt_update_pt_crc function

Hi All, I find a memory leak about gpt_update_pt_crc function and I try to fix it. Cheers, Manuele === modified file 'uspace/lib/label/src/gpt.c' --- uspace/lib/label/src/gpt.c 2016-03-15 15:05:13 + +++ uspace/lib/label/src/gpt.c 2016-06-16 11:02:46 + @@ -918,7 +918,7 @@ gpt_hdr = calloc

[HelenOS-devel] Fix leak kdio producer

Hi All, I found this bug in kio.c using cppcheck and I try to fix. Cheers, Manuele === modified file 'uspace/app/kio/kio.c' --- uspace/app/kio/kio.c 2014-08-16 00:02:04 + +++ uspace/app/kio/kio.c 2016-07-06 08:25:10 + @@ -78,13 +78,16 @@ */ static void producer(size_t length, wchar_t *da

[HelenOS-devel] Fix Null pointer passed as an argument to a 'nonnull' parameter

Hi All, I found a bug in uspace/lib/drv/generic/remote_nic.c and I try to fix it. Cheers, Manuele === modified file 'uspace/lib/drv/generic/remote_nic.c' --- uspace/lib/drv/generic/remote_nic.c 2015-08-23 12:50:23 + +++ uspace/lib/drv/generic/remote_nic.c 2016-07-06 10:44:23 + @@ -2338,10

[HelenOS-devel] Fix potential leak of memory

Hi All, I found a potential leak of memory pointed to by 'entry' in task.c and i fix it. Cheers, Manuele === modified file 'uspace/srv/ns/task.c' --- uspace/srv/ns/task.c 2015-09-30 17:47:41 + +++ uspace/srv/ns/task.c 2016-07-06 11:02:57 + @@ -241,8 +241,10 @@ return ENOMEM; hashed

[HelenOS-devel] Fix potential leak of memory

Hi All, I found a potential leak of memory pointed to by 'frag' in uspace/srv/net/inetsrv/reass.c and I fix it. Cheers, Manuele ___ HelenOS-devel mailing list HelenOS-devel@lists.modry.cz http://lists.modry.cz/listinfo/helenos-devel

[HelenOS-devel] Missing patch about Fix potential leak of memory

Hi All, I forgot to attach my patch file in my previous mail. Cheers, Manuele === modified file 'uspace/srv/net/inetsrv/reass.c' --- uspace/srv/net/inetsrv/reass.c 2015-06-02 16:00:42 + +++ uspace/srv/net/inetsrv/reass.c 2016-07-06 11:40:20 + @@ -192,8 +192,10 @@ /* Clone the packet */

[HelenOS-devel] Remove double free pointer

Hi all, I found an attempt to free released memory. My fix is attached. Cheers, Manuele === modified file 'uspace/app/mkbd/main.c' --- uspace/app/mkbd/main.c 2015-08-23 12:50:23 + +++ uspace/app/mkbd/main.c 2016-07-19 09:54:39 + @@ -122,12 +122,7 @@ rc = usb_hid_parse_report_descriptor(*r

[HelenOS-devel] Fix memory leak in client_conn

Hi I found a memory leak in client_conn.c. My fix is attached. Cheers, Manuele === modified file 'uspace/srv/devman/client_conn.c' --- uspace/srv/devman/client_conn.c 2015-08-23 12:50:23 + +++ uspace/srv/devman/client_conn.c 2016-07-19 10:03:34 + @@ -631,6 +631,7 @@ link_t *link = list_nt

Re: [HelenOS-devel] #pragma once

Hi Jakub, "Pragma one" is not supported by some old compiler, so I prefer to use the classical header guards. Regards, Manuele > On 2 Jun 2017, at 16:48, Jakub Jermář wrote: > > Hello, > > how controversial would it be to start using #pragma once instead of > classical header guards? Asking fo

[HelenOS-devel] Add drawctx_stroke implementation

Hi All, I try to add by myself drawctx_stroke function. This stroke implementation strokes the shape using a thin line. You can find my code at link below: https://github.com/manux81/helenos-1/tree/add_draw_stroke (https://link.getmailspring.com/link/8fc93b0a-d553-4ec0-b6a2-00c3c3422...@getmailsp