Hi Flo,
First your vetting exercise is ok. I commited it to the trunk.
> Of course it did. I didn'nt mention, that i checked out the 2010.0.0
> release from svn, not the trunk.
> So the patches are based on that release. (Should I use the trunk
> instead?)
Okay, I understand.The trunk contains s
The SrcPanoImage class changed a lot since the last release, but i
should have used getSize() from the beginning.
This patch is based on the current trunk rev.
http://groups.google.com/group/hugin-ptx/web/ExivOrientationTrust.patch
It only contains the Exiv part. The rotation of the preview image
On 1 Apr., 19:10, "T. Modes" wrote:
> > +bool SrcPanoImage::trustExivOrientation()
> > +{
> > + if(m_size.width() < m_size.height())
> > + return false;
> > +
>
> m_size: unknow member variable (or something similiar)
> Did the patch compile on your machine?
You're right, it doesn't w
Hi Thomas
On 1 Apr., 19:10, "T. Modes" wrote:
> I would not rotate that little preview image. It would be helpful to
> see in at least one position the right orientation in the file. In all
> controls which show the image and where you can edit parts (cp, crop,
> mask) the image is rotated in onl
Hi Flo,
> Thanks for your support. I tried to understand the code some more and
> did a little improvement to the Exiv orientation feature.
> - added the trusted tag feature, which doesn't do a lot, actually.
> - rotate the preview in the image panel according to image roll value.
> It's rotated b
Hi!
Thanks for your support. I tried to understand the code some more and
did a little improvement to the Exiv orientation feature.
- added the trusted tag feature, which doesn't do a lot, actually.
- rotate the preview in the image panel according to image roll value.
It's rotated by the exact ro
On Tue 30-Mar-2010 at 12:00 -0700, Thomas Modes wrote:
SrcPanoImage somehow encapsulates an image, and when one adds an Image
in the GUI wxAddImagesCmd::execute creates an instance of SrcPanoImage
and calls it's readEXIF(...) method.
This huge method already reads Exif orientation tags and fina
Hi Florian
> What parts are in hugin_base and in hugin1?
It is as Lukas has already written. In hugin_base there is mainly the
core function.
Hugin1 holds all code which depends on wxWidgets. This is mainly the
gui programs and related code.
> For Example there is an ImageCache class in
> hugin_
