Re: [Intel-gfx] [PATCH 5/5] drm/i915/error: Capture WA ctx batch in error state

Arun Siluvery writes: > From Gen8 onwards we apply ctx workarounds using special batch buffers that > execute during save/restore, good to have them in error state. > > Signed-off-by: Arun Siluvery > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > drivers/gpu/drm/i915/i915_gpu_error.c |

[Intel-gfx] [maintainer-tools PATCH] dim: update copyright year and authorship

Considering the git stats on the script, seems fair to add myself as an author. Signed-off-by: Jani Nikula --- dim | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dim b/dim index c64f6e86af62..4cb6ceff5228 100755 --- a/dim +++ b/dim @@ -1,6 +1,6 @@ #!/bin/bash -# Copyrig

Re: [Intel-gfx] [PATCH 1/5] drm/i915/error: capture execlist state on error

Arun Siluvery writes: > From: Dave Gordon > > At present, execlist status/ctx_id and CSBs, not the submission queue > > For: VIZ-2021 > Signed-off-by: Dave Gordon > --- > drivers/gpu/drm/i915/i915_drv.h | 9 + > drivers/gpu/drm/i915/i915_gpu_error.c | 38 > +

[Intel-gfx] [maintainer-tools RFC PATCH] dim: add cherry-pick-[next-]fixes subcommands

Add two new subcommands for cherry-picking fixes from dinq to drm-intel-fixes and drm-intel-next-fixes. The only difference in the subcommands is the assert branch check to ensure the user is on the right branch. The commands scan dinq for commits Cc'd to stable or drm-intel-fixes, checks whether

Re: [Intel-gfx] [PATCH v2] drm/i915: refine qemu south bridge detection

On Thu, 28 Jan 2016, Bruno Wolff III wrote: > On Mon, Jan 25, 2016 at 12:02:28 +0100, > Gerd Hoffmann wrote: >>The test for the qemu q35 south bridge added by commit >>"39bfcd52 drm/i915: more virtual south bridge detection" >>also matches on real hardware. Having the check for >>virtual syste

Re: [Intel-gfx] [RFC 14/22] drm/i915/slpc: Notification of Display mode change

Thanks for the review Ville. I will update the patch. On 1/22/2016 10:44 PM, Ville Syrjälä wrote: On Wed, Jan 20, 2016 at 06:26:16PM -0800, tom.orou...@intel.com wrote: From: Sagar Arun Kamble GuC SLPC need to be sent data related to Active pipes, refresh rates, widi pipes, fullscreen pipes r

Re: [Intel-gfx] [PATCH 01/25] drm/i915/fbc: wait for a vblank instead of 50ms when enabling

Thanks for all the explanation. Makes sense now and everything looks fine for me. Reviewed-by: Rodrigo Vivi On Tue, Jan 26, 2016 at 10:08 AM Zanoni, Paulo R wrote: > Em Ter, 2016-01-26 às 17:44 +, Rodrigo Vivi escreveu: > > > > > > On Thu, Jan 21, 2016 at 12:03 PM Paulo Zanoni > om> wro

[Intel-gfx] i915 corrupting memory on shutdown since 4.4?

Hi, I'm using 4.5-rc1 and before that 4.4. Twice in the past month I've rebooted and the root btrfs partition has become corrupted and unbootable. I was wondering if the cause could be i915 and if so is there any better way to track it down? In test 200 reboots gave only 3 errors, but the third e

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0

First of all: Reviewed-by: Rodrigo Vivi I've checked with DMC folks that DMC 1.23 that we are currently using and the following releases support J0 and K0. With this patch we are covering all SKL steppings we know so far, but besides being concern with new steppings appearing at any moment I'm

[Intel-gfx] [PATCH] drm/i915: Fix file permissions

No functional change Signed-off-by: Mat Martineau --- drivers/gpu/drm/i915/intel_hdmi.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 drivers/gpu/drm/i915/intel_hdmi.c diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c old mo

[Intel-gfx] [PATCH] drm/i915/skl: Fix DMC load on Skylake J0 and K0

The driver does not load firmware for unknown steppings, so these new steppings must be added to the list. Cc: Rodrigo Vivi Signed-off-by: Mat Martineau --- drivers/gpu/drm/i915/intel_csr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/

[Intel-gfx] [PATCH] drm/i915: Check DDI max lanes after applying BXT workaround

In commit bfb9faab8 we added a workaround for some BXT BIOS that fail to properly initialize the DDI_A_4_LANES bit of the control register (4 lanes is the only valid configuration on BXT since there is no DDI E to share with). A recent patch added some additional checks on this register bit before

Re: [Intel-gfx] drm/i915: Decouple execbuf uAPI from internal implementation

Hello Tvrtko Ursulin, The patch de1add360522: "drm/i915: Decouple execbuf uAPI from internal implementation" from Jan 15, 2016, leads to the following static checker warning: drivers/gpu/drm/i915/i915_gem_execbuffer.c:1411 eb_select_ring() warn: buffer overflow 'dev_priv->ring' 5

Re: [Intel-gfx] [PATCH 07/18] drm/i915: Fix intel_tile_width() parameters

On Thu, Jan 28, 2016 at 08:35:26PM +0200, Ville Syrjälä wrote: > On Mon, Jan 25, 2016 at 06:12:15PM +0100, Daniel Vetter wrote: > > On Wed, Jan 20, 2016 at 09:05:28PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > The fb_modifiers and cpp arguments passed t

[Intel-gfx] [PATCH 3/5] drm/i915/error: report ctx id & desc for each request in the queue

From: Dave Gordon Also decode and output CSB entries, in time order For: VIZ-2021 Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 37 +++ 2 files changed, 30 insertions(+), 8 deletions(-) diff

[Intel-gfx] [PATCH 5/5] drm/i915/error: Capture WA ctx batch in error state

From Gen8 onwards we apply ctx workarounds using special batch buffers that execute during save/restore, good to have them in error state. Signed-off-by: Arun Siluvery --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 25 + 2 files

[Intel-gfx] [PATCH 0/5] Capture more useful details in error state

Few patches to capture more useful details in error state - these details include execlist state, csb events and their decoded form, WA ctx batch buffer. Except WA ctx batch all other patches are already sent as part of preemption patch series but these are independent patches; it may take a while

[Intel-gfx] [PATCH 2/5] drm/i915/error: capture ringbuffer pointed to by START

From: Dave Gordon For: VIZ-2021 Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c | 36 +-- 2 files changed, 27 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/driver

[Intel-gfx] [PATCH 4/5] drm/i915/error: improve CSB reporting

From: Dave Gordon v2: add separators for readability For: VIZ-2021 Signed-off-by: Dave Gordon Signed-off-by: Arun Siluvery (v2) Signed-off-by: Arun Siluvery --- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/i915_gpu_error.c | 87 --- 2 fi

[Intel-gfx] [PATCH 1/5] drm/i915/error: capture execlist state on error

From: Dave Gordon At present, execlist status/ctx_id and CSBs, not the submission queue For: VIZ-2021 Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_drv.h | 9 + drivers/gpu/drm/i915/i915_gpu_error.c | 38 +-- 2 files changed, 45 inserti

[Intel-gfx] [PATCH v3 6/6] drm/i915: fix context/engine cleanup order

From: Nick Hoath Swap the order of context & engine cleanup, so that contexts are cleaned up first, and *then* engines. This is a more sensible order anyway, but in particular has become necessary since the 'intel_ring_initialized() must be simple and inline' patch, which now uses ring->dev as an

[Intel-gfx] [PATCH v3 0/6] A collection of cleanups, version 3

Various things can go wrong during initialisation and teardown, but they usually don't, so the error-handling paths go largely untested. This collection of patches fixes some things I recently noticed. Some might lead to a kernel OOPS, but mostly they're leaks and other inconsistencies. Includes

[Intel-gfx] [PATCH v3 5/6] drm/i915: HWSP should be unmapped earlier in LRC teardown sequence

In LRC mode, the HWSP is part of the default context object, and therefore does not exist independently. Worse, it doesn't contribute to the refcount on the default context object either. Currently, the default context is deallocated in intel_lr_context_free(), but the HWSP kmapping is not torn do

[Intel-gfx] [PATCH v3 1/6] drm/i915: tidy up initialisation failure paths (legacy)

1. Fix intel_cleanup_ring_buffer() to handle the error cleanup case where the ringbuffer has been allocated but map-and-pin failed. Unpin it iff it's previously been mapped-and-pinned. 2. Fix the error path in intel_init_ring_buffer(), which already called intel_destroy_ringbuffer_obj(),

[Intel-gfx] [PATCH v3 3/6] drm/i915: unmap the correct page in intel_logical_ring_cleanup()

The kunmap() call here didn't match the corresponding kmap(). The kmap()ing was changed with the introduction of the GuC-compatible layout of context objects and the introduction of "LRC_PPHWSP_PN", in d167519 drm/i915: Integrate GuC-based command submission but the corresponding kunmap() was

[Intel-gfx] [PATCH v3 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC)

1. add call to i915_gem_context_fini() to deallocate the default context(s) if the call to init_rings() fails, so that we don't leak the context in that situation. 2. remove useless code in intel_logical_ring_cleanup(), presumably copypasted from legacy ringbuffer version at creation. Si

[Intel-gfx] [PATCH v3 4/6] drm/i915: consolidate LRC mode HWSP setup & teardown

In legacy ringbuffer mode, the HWSP is a separate GEM object with its own pinning and reference counts. In LRC mode, however, it's not; instead its part of the default context object. The LRC-mode setup & teardown code therefore needs to handle this specially; the presence of the two bugs fixed in

Re: [Intel-gfx] [PATCH v3 08/18] drm/i915: Pass 90/270 vs. 0/180 rotation info for intel_gen4_compute_page_offset()

On Mon, Jan 25, 2016 at 06:30:17PM +0100, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 09:05:29PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The page aligned surface address calculation needs to know which way > > things are rotated. The contract now says that t

Re: [Intel-gfx] [PATCH 07/18] drm/i915: Fix intel_tile_width() parameters

On Mon, Jan 25, 2016 at 06:12:15PM +0100, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 09:05:28PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > The fb_modifiers and cpp arguments passed to intel_tile_width() in > > intel_fill_fb_ggtt_view() got accidentally swapped

Re: [Intel-gfx] [PATCH v2 06/18] drm: Add drm_format_plane_width() and drm_format_plane_height()

On Mon, Jan 25, 2016 at 06:08:23PM +0100, Daniel Vetter wrote: > On Wed, Jan 20, 2016 at 09:05:27PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Add a few helpers to get the dimensions of the chroma plane(s). > > > > v2: Add kernel-doc (Daniel) > > > > Cc: dri-de.

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix pointer tests in error-handling paths

== Summary == Series 2897v1 Fix pointer tests in error-handling paths http://patchwork.freedesktop.org/api/1.0/series/2897/revisions/1/mbox/ bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2total:159 pass:135 dwarn:0 dfail:0 fail:0 skip:24 byt

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Make LRC (un)pinning work on context and engine

On 28/01/16 17:26, Patchwork wrote: == Summary == Series 2896v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/2896/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE Known a

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Make LRC (un)pinning work on context and engine

== Summary == Series 2896v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/2896/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE bdw-nuci7total:156 pass:147 dwarn:0 df

[Intel-gfx] [PATCH] drm/i915: Capture PCI revision and subsytem details in error state

Revision id along with device id is useful in better identification of the HW and its limitations so include this detail in error state. v2: make it clear that it is PCI revision and We might as well dump PCI subsystem details while we update this (Ville, Chris). Cc: Chris Wilson Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: failure for iGVT-g implementation in i915

== Summary == Series 2895v1 iGVT-g implementation in i915 Apply patch: http://patchwork.freedesktop.org/api/1.0/series/2895/revisions/1/mbox/ Applying: drm/i915/gvt: Introduce the basic architecture of GVT-g Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_dma.c M

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make wa_tail_dwords flexible for future platforms. (rev2)

== Summary == Series 2818v2 drm/i915: Make wa_tail_dwords flexible for future platforms. http://patchwork.freedesktop.org/api/1.0/series/2818/revisions/2/mbox/ Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-b: pass -> DMESG-WARN (ivb-t430s) bdw-nuci7

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: check that rpm ref is held when accessing ringbuf in stolen mem (rev2)

== Summary == Series 2878v2 drm/i915: check that rpm ref is held when accessing ringbuf in stolen mem http://patchwork.freedesktop.org/api/1.0/series/2878/revisions/2/mbox/ Test gem_exec_basic: Subgroup basic-bsd1: pass -> SKIP (bsw-nuc-2) pass

Re: [Intel-gfx] [PATCH v2] drm/i915: refine qemu south bridge detection

On Mon, Jan 25, 2016 at 12:02:28 +0100, Gerd Hoffmann wrote: The test for the qemu q35 south bridge added by commit "39bfcd52 drm/i915: more virtual south bridge detection" also matches on real hardware. Having the check for virtual systems last in the list is not enough to avoid that ... Ref

[Intel-gfx] ✓ Fi.CI.BAT: success for Adding CPU mmap support to DRM_IOCTL_I915_GEM_MMAP_GTT (rev3)

== Summary == Series 2843v3 Adding CPU mmap support to DRM_IOCTL_I915_GEM_MMAP_GTT http://patchwork.freedesktop.org/api/1.0/series/2843/revisions/3/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0

Re: [Intel-gfx] [PATCH] drm/i915/bxt: update list of PCIIDs

Imre Deak writes: > Add PCIIDs for new versions of the SOC, based on BSpec. Also add the > name of the versions as code comment where this is available. The new > versions don't have any changes visible to the kernel driver. > > Signed-off-by: Imre Deak Reviewed-by: Mika Kuoppala > --- > inc

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] agp/intel-gtt: Don't leak the scratch page

== Summary == Series 2876v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/2876/revisions/1/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: check that rpm ref is held when writing to ringbuf in stolen mem

== Summary == Series 2862v1 drm/i915: check that rpm ref is held when writing to ringbuf in stolen mem http://patchwork.freedesktop.org/api/1.0/series/2862/revisions/1/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0

Re: [Intel-gfx] [maintainer-tools PATCH v2 00/33] dim: function based subcommand handling

On Thu, 28 Jan 2016, Jani Nikula wrote: > This is v2 of [1], with Daniel's concern regarding aliases > addressed. It's much better now. > > Patches 1-11 and 15-31 are mostly just mechanical renames or code > movement. They explode the series so big, but I think they're easier to > look at this way

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: expose fifo pipe underrun counts

== Summary == Series 2852v1 drm/i915: expose fifo pipe underrun counts http://patchwork.freedesktop.org/api/1.0/series/2852/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE bdw-nuci7total:156 pass:147

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] agp/intel-gtt: Don't leak the scratch page

== Summary == Series 2851v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/2851/revisions/1/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Capture revision id in error state

== Summary == Series 2850v1 drm/i915: Capture revision id in error state http://patchwork.freedesktop.org/api/1.0/series/2850/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (bsw-nuc-2) pass -> DMESG-WARN (ilk

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/gen9: Probe power well 1 status on dc status query

== Summary == Series 2845v1 drm/i915/gen9: Probe power well 1 status on dc status query http://patchwork.freedesktop.org/api/1.0/series/2845/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (skl-i5k-2) pass -> DME

[Intel-gfx] ✓ Fi.CI.BAT: success for MAINTAINERS: Add "B:" preferred bug reporting method (rev3)

== Summary == Series 2539v3 MAINTAINERS: Add "B:" preferred bug reporting method http://patchwork.freedesktop.org/api/1.0/series/2539/revisions/3/mbox/ bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 s

[Intel-gfx] [PATCH v3 5/5] drm/atomic: Add encoder_mask to crtc_state, v3.

This allows iteration over encoders without requiring connection_mutex. Changes since v1: - Add a set_best_encoder helper function and update encoder_mask inside it. Changes since v2: - Relax the WARN_ON(!crtc), with explanation. - Call set_best_encoder when connector is moved between crtc's. -

[Intel-gfx] [PATCH] drm/i915/bxt: update list of PCIIDs

Add PCIIDs for new versions of the SOC, based on BSpec. Also add the name of the versions as code comment where this is available. The new versions don't have any changes visible to the kernel driver. Signed-off-by: Imre Deak --- include/drm/i915_pciids.h | 4 +++- 1 file changed, 3 insertions(+

Re: [Intel-gfx] [PATCH 5/5] drm/atomic: Add encoder_mask to crtc_state, v2.

A diff to make this v3. Found when running this through IGT bat. - Keeping an encoder but moving it to a different crtc resulted, in encoder_mask not being updated. - Add some paranoia when best_encoder was already updated to a different encoder in steal_encoder. This could happen in theory.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: add WaIncreaseDefaultTLBEntries

== Summary == Series 2811v1 drm/i915: add WaIncreaseDefaultTLBEntries Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pas

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915: Make LRC (un)pinning work on context and engine

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

[Intel-gfx] [maintainer-tools PATCH v2 30/33] dim: abstract dim_checker

Signed-off-by: Jani Nikula --- dim | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/dim b/dim index 4ff903fb3818..4370aec28ec0 100755 --- a/dim +++ b/dim @@ -662,6 +662,13 @@ function dim_checkpatch done } +function dim_checker +{ + rm drivers/gpu/

[Intel-gfx] [maintainer-tools PATCH v2 25/33] dim: abstract dim_cherry_pick

Signed-off-by: Jani Nikula --- dim | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/dim b/dim index 4942b1684f74..69c8d6a49495 100755 --- a/dim +++ b/dim @@ -453,6 +453,22 @@ function dim_apply_next_fixes dim_apply_branch drm-intel-next-

[Intel-gfx] [maintainer-tools PATCH v2 29/33] dim: abstract dim_{create, remove}_branch

Signed-off-by: Jani Nikula --- dim | 100 +++- 1 file changed, 52 insertions(+), 48 deletions(-) diff --git a/dim b/dim index 88ee7350741d..4ff903fb3818 100755 --- a/dim +++ b/dim @@ -515,6 +515,58 @@ function dim_magic_patch

[Intel-gfx] [maintainer-tools PATCH v2 31/33] dim: abstract dim_help

dim help being the last subcommand handled by the switch case, obliterate it as well, finishing the job we set out to do. Now all subcommands are handled via dim_ prefixed functions. Signed-off-by: Jani Nikula --- dim | 50 -- 1 file changed, 24 in

[Intel-gfx] [maintainer-tools PATCH v2 28/33] dim: abstract dim_tag_next

Signed-off-by: Jani Nikula --- dim | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/dim b/dim index 25597743e2a0..88ee7350741d 100755 --- a/dim +++ b/dim @@ -772,6 +772,24 @@ function dim_update_next "$addr_intel_qa2" } +func

[Intel-gfx] [maintainer-tools PATCH v2 23/33] dim: abstract dim_tc

Signed-off-by: Jani Nikula --- dim | 30 -- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/dim b/dim index 808c9c74a8d4..8c21c4d905b6 100755 --- a/dim +++ b/dim @@ -876,6 +876,22 @@ function dim_cat_to_fixup cat > `cat .fixup_file_path` } +f

[Intel-gfx] [maintainer-tools PATCH v2 17/33] dim: abstract dim_for_each_workdirs

Signed-off-by: Jani Nikula --- dim | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/dim b/dim index fd61ce5a7f49..d887a9afc426 100755 --- a/dim +++ b/dim @@ -603,6 +603,19 @@ function dim_create_workdir done } +dim_alias_fw=for-each-workdir

[Intel-gfx] [maintainer-tools PATCH v2 27/33] dim: abstract dim_update_next

Signed-off-by: Jani Nikula --- dim | 126 +++- 1 file changed, 64 insertions(+), 62 deletions(-) diff --git a/dim b/dim index 1ecdfefc4f11..25597743e2a0 100755 --- a/dim +++ b/dim @@ -708,6 +708,70 @@ function dim_for_each_workdirs

[Intel-gfx] [maintainer-tools PATCH v2 21/33] dim: abstract dim_magic_rebase_resolve

Signed-off-by: Jani Nikula --- dim | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/dim b/dim index 898889a28c69..f86ba6253e49 100755 --- a/dim +++ b/dim @@ -461,6 +461,16 @@ function dim_apply_resolved git commit --amend & } +dim_alias_mrr=magic

[Intel-gfx] [maintainer-tools PATCH v2 32/33] dim: show usage instead of the man page on unknown subcommands

I find displaying the man page on every typo a bit distracting. Now that we can list all the supported subcommands (by way of listing all the dim_ prefixed functions), add usage to show quick help. Also make it a subcommand of its own. Signed-off-by: Jani Nikula --- dim | 17 ++--- 1

[Intel-gfx] [maintainer-tools PATCH v2 20/33] dim: abstract dim apply* subcommands

Signed-off-by: Jani Nikula --- dim | 56 +--- 1 file changed, 33 insertions(+), 23 deletions(-) diff --git a/dim b/dim index 519d09a1cdc8..898889a28c69 100755 --- a/dim +++ b/dim @@ -435,6 +435,39 @@ function dim_apply_branch eval $DRY

[Intel-gfx] [maintainer-tools PATCH v2 19/33] dim: abstract dim_checkout callers

Signed-off-by: Jani Nikula --- dim | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/dim b/dim index 07ef5d70db1e..519d09a1cdc8 100755 --- a/dim +++ b/dim @@ -486,6 +486,21 @@ function dim_checkout fi } +function dim_conq +{ + dim_check

[Intel-gfx] [maintainer-tools PATCH v2 33/33] dim: add -h option for usage, imrove output on unknown options

Show usage also with the -h option, and improve output on unknown options. Signed-off-by: Jani Nikula --- dim | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dim b/dim index 1651b5e8218a..fe1b2e8f1bad 100755 --- a/dim +++ b/dim @@ -107,6 +107,7 @@ DRY_RUN= INTERAC

[Intel-gfx] [maintainer-tools PATCH v2 18/33] dim: abstract dim_push_*

Signed-off-by: Jani Nikula --- dim | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/dim b/dim index d887a9afc426..07ef5d70db1e 100755 --- a/dim +++ b/dim @@ -376,6 +376,24 @@ function dim_push_branch update_linux_next } +dim_alias_pq=

[Intel-gfx] [maintainer-tools PATCH v2 26/33] dim: abstract dim_pull_request_*

Signed-off-by: Jani Nikula --- dim | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/dim b/dim index 69c8d6a49495..1ecdfefc4f11 100755 --- a/dim +++ b/dim @@ -750,6 +750,24 @@ function dim_pull_request "$addr_drm_maintainer" }

[Intel-gfx] [maintainer-tools PATCH v2 24/33] dim: abstract dim_fixes

Signed-off-by: Jani Nikula --- dim | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/dim b/dim index 8c21c4d905b6..4942b1684f74 100755 --- a/dim +++ b/dim @@ -892,6 +892,13 @@ function dim_tc fi } +function dim_fixes +{ + sha1=$1 + git log -1

[Intel-gfx] [maintainer-tools PATCH v2 07/33] dim: rename setup_dim to dim_setup

Rename to match the subcommand. Signed-off-by: Jani Nikula --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index f8da41d71bc1..5d06918f207e 100755 --- a/dim +++ b/dim @@ -625,7 +625,7 @@ function dim_pull_request "$addr_drm_maintainer" }

[Intel-gfx] [maintainer-tools PATCH v2 09/33] dim: rename update_nightly to dim_rebuild_nightly

Rename to match the subcommand name. Signed-off-by: Jani Nikula --- dim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dim b/dim index 6f209e360391..fa6e896aaf46 100755 --- a/dim +++ b/dim @@ -234,7 +234,7 @@ function update_rerere_cache cd - } -function upd

[Intel-gfx] [maintainer-tools PATCH v2 22/33] dim: abstract dim_cat_to_fixup

Signed-off-by: Jani Nikula --- dim | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dim b/dim index f86ba6253e49..808c9c74a8d4 100755 --- a/dim +++ b/dim @@ -870,6 +870,12 @@ function dim_alias sed 's/^dim_alias_/\t/;s/=/\t/' } +function dim_cat_to

[Intel-gfx] [maintainer-tools PATCH v2 15/33] dim: abstract dim_nightly_forget

Signed-off-by: Jani Nikula --- dim | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/dim b/dim index 651ee5882ca3..c8daacfdf9f4 100755 --- a/dim +++ b/dim @@ -347,6 +347,15 @@ function dim_rebuild_nightly } +function dim_nightly_forget +{ + cd $DIM_PR

[Intel-gfx] [maintainer-tools PATCH v2 11/33] dim: move dim_pull_request parameter check to the function

More abstraction is better, also guards against invalid internal use. Signed-off-by: Jani Nikula --- dim | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/dim b/dim index a2c0d74c37e8..5833306e35c5 100755 --- a/dim +++ b/dim @@ -591,6 +591,11 @@ function dim_create_wor

[Intel-gfx] [maintainer-tools PATCH v2 16/33] dim: abstract dim_update_branches

Signed-off-by: Jani Nikula --- dim | 42 ++ 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/dim b/dim index c8daacfdf9f4..fd61ce5a7f49 100755 --- a/dim +++ b/dim @@ -645,6 +645,28 @@ function dim_pull_request "$addr_drm_maint

[Intel-gfx] [maintainer-tools PATCH v2 14/33] dim: add alias command to list aliases

Helpful convenience. Signed-off-by: Jani Nikula --- dim | 7 +++ dim.rst | 5 + 2 files changed, 12 insertions(+) diff --git a/dim b/dim index 98b090eadf33..651ee5882ca3 100755 --- a/dim +++ b/dim @@ -743,6 +743,13 @@ function assert_branch fi } +function dim_alias +{ +

[Intel-gfx] [maintainer-tools PATCH v2 05/33] dim: rename dim_checkpatch to checkpatch_commit

Rename as there's no corresponding subcommand (the check-patch subcommand does a slightly different thing). Signed-off-by: Jani Nikula --- dim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dim b/dim index d26abceb21a6..8865778a34f5 100755 --- a/dim +++ b/dim @@ -478,7

[Intel-gfx] [maintainer-tools PATCH v2 08/33] dim: rename create_workdir to dim_create_workdir

Add dim_ prefix to functions corresponding to subcommands. Signed-off-by: Jani Nikula --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index 5d06918f207e..6f209e360391 100755 --- a/dim +++ b/dim @@ -555,7 +555,7 @@ function prep_pull_mail prep_pul

[Intel-gfx] [maintainer-tools PATCH v2 13/33] dim: handle subcommands through functions

If there's a dim_ prefixed function matching the subcommand, call it to handle the subcommand without going through the big switch case. Drop the cases which already match the convention. Once all the cases are converted to functions, the handling of subcommands becomes much cleaner. This also al

[Intel-gfx] [maintainer-tools PATCH v2 10/33] dim: rename magic_patch to dim_magic_patch

Add dim_ prefix to functions corresponding to subcommands. Signed-off-by: Jani Nikula --- dim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dim b/dim index fa6e896aaf46..a2c0d74c37e8 100755 --- a/dim +++ b/dim @@ -406,7 +406,7 @@ function dim_apply_branch eval $

[Intel-gfx] [maintainer-tools PATCH v2 06/33] dim: rename dim_checkrange to dim_checkpatch

Rename to match the subcommand. Also add checkpatch subcommand (without the hyphen) to match the spelling of the tool. Signed-off-by: Jani Nikula --- dim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dim b/dim index 8865778a34f5..f8da41d71bc1 100755 --- a/dim +++ b/di

[Intel-gfx] [maintainer-tools PATCH v2 04/33] dim: rename dim_shell_checkpatch to shell_checkpatch

Drop the dim_ prefix as there's no corresponding subcommand. Signed-off-by: Jani Nikula --- dim | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dim b/dim index e2d4869fdab0..d26abceb21a6 100755 --- a/dim +++ b/dim @@ -386,7 +386,7 @@ function dim_apply_branch

[Intel-gfx] [maintainer-tools PATCH v2 00/33] dim: function based subcommand handling

This is v2 of [1], with Daniel's concern regarding aliases addressed. It's much better now. Patches 1-11 and 15-31 are mostly just mechanical renames or code movement. They explode the series so big, but I think they're easier to look at this way. The real changes are in patches 12-14 and 32-33.

[Intel-gfx] [maintainer-tools PATCH v2 12/33] dim: separate handling of aliases

Allow specifying dim subcommand aliases using variables of the format dim_alias_. The value of the variable should be the name of the actual subcommand. The user can specify aliases in the dimrc. Signed-off-by: Jani Nikula --- dim | 56 1

[Intel-gfx] [maintainer-tools PATCH v2 01/33] dim: rename dim_push to dim_push_branch

Rename to match the subcommand name. Move error checking to the function too. Signed-off-by: Jani Nikula --- dim | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/dim b/dim index e08fdffd3d86..faa98114a027 100755 --- a/dim +++ b/dim @@ -349,8 +349,13 @@ fun

[Intel-gfx] [maintainer-tools PATCH v2 02/33] dim: rename dim_apply to dim_apply_branch

Rename to match the subcommand name. Signed-off-by: Jani Nikula --- dim | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/dim b/dim index faa98114a027..aee6e4b87b14 100755 --- a/dim +++ b/dim @@ -369,7 +369,7 @@ function dim_push_branch # ensure we're on branch $1

[Intel-gfx] [maintainer-tools PATCH v2 03/33] dim: rename dim_co to dim_checkout

Rename to match the (long) subcommand name. Move error checking to the function too. Signed-off-by: Jani Nikula --- dim | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/dim b/dim index aee6e4b87b14..e2d4869fdab0 100755 --- a/dim +++ b/dim @@ -440,8 +4

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: more virtual south bridge detection"

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE bdw-nuci7total:156 pass:147 dwarn:0

Re: [Intel-gfx] [RFC 17/29] gvt: Xen hypervisor GVT-g MPT module

Hi Joonas, On Thu, Jan 28, 2016 at 01:33:33PM +0200, Joonas Lahtinen wrote: > Hi, > > See the file MAINTAINERS and add Cc: lines according to "XEN HYPERVISOR > INTERFACE". Also I think it'll be useful to split the i915 changes to a > separate patch next int he series (as the reviewer will be diff

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_core.c: Expand --run-subtest functionality.

On 28/01/16 11:05, Derek Morton wrote: Added support for specifying arbitary lists of subtests to run, or to exclude from being run if prefixed by ^ or !. subtest1,subtest2 Will run subtest1 and subtest2 ^subtest1,subtest2 or !subtest1,subtest2 will run all subtests except subtest1 and subtest2.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't ERROR for an expected intel_rcs_ctx_init() interruption

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: edp resume/On time optimization. (rev10)

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE Test kms_pipe_crc_basic: Subgroup susp

Re: [Intel-gfx] [PATCH v3] drm/i915: check that rpm ref is held when accessing ringbuf in stolen mem

On Thu, Jan 28, 2016 at 02:09:37PM +0200, Ville Syrjälä wrote: > On Thu, Jan 28, 2016 at 11:45:24AM +, Chris Wilson wrote: > > On Thu, Jan 28, 2016 at 10:55:16AM +, Daniele Ceraolo Spurio wrote: > > > > > > > > > On 27/01/16 16:39, Ville Syrjälä wrote: > > > >On Wed, Jan 27, 2016 at 03:43

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow i915_gem_object_get_page() on userptr as well (rev2)

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

[Intel-gfx] [PATCH igt] igt/gem_ringfill: Add exercising the default-ring to basic testing

ringfill generates a few very common errors when submitting requests, and historically these have been where we have had many implementation bugs, repeated over and over again. Signed-off-by: Chris Wilson --- tests/gem_ringfill.c | 21 + 1 file changed, 9 insertions(+), 12 de

[Intel-gfx] ✓ Fi.CI.BAT: success for A collection of cleanups

== Summary == Built on b3f8ad64bc71f6236f05c2e9f4ad49a61745869a drm-intel-nightly: 2016y-01m-28d-10h-26m-23s UTC integration manifest bdw-nuci7total:156 pass:147 dwarn:0 dfail:0 fail:0 skip:9 bdw-ultratotal:159 pass:153 dwarn:0 dfail:0 fail:0 skip:6 bsw-nuc-2

Re: [Intel-gfx] [PATCH v3] drm/i915: check that rpm ref is held when accessing ringbuf in stolen mem

On Thu, Jan 28, 2016 at 11:45:24AM +, Chris Wilson wrote: > On Thu, Jan 28, 2016 at 10:55:16AM +, Daniele Ceraolo Spurio wrote: > > > > > > On 27/01/16 16:39, Ville Syrjälä wrote: > > >On Wed, Jan 27, 2016 at 03:43:49PM +,daniele.ceraolospu...@intel.com > > >wrote: > > >>From: Danie

Re: [Intel-gfx] [PATCH 075/190] drm/i915: Refactor activity tracking for requests

On 28/01/16 11:46, Chris Wilson wrote: On Thu, Jan 28, 2016 at 11:41:37AM +, Tvrtko Ursulin wrote: Hi, On 11/01/16 09:17, Chris Wilson wrote: With the introduction of requests, we amplified the number of atomic refcounted objects we use and update every execbuffer; from none to several r

Re: [Intel-gfx] [PATCH 063/190] drm/i915: Rename struct intel_ringbuffer to intel_ring

Oh right, I suppose patch 59 is OK then if it goes together with this one. Regards, Tvrtko On 11/01/16 09:17, Chris Wilson wrote: Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c| 21 +++--- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/

Re: [Intel-gfx] [PATCH 060/190] drm/i915: Rename backpointer from intel_ringbuffer to intel_engine_cs

On 11/01/16 09:17, Chris Wilson wrote: Having ringbuf->ring point to an engine is confusing, so rename it once again to ring->engine. Another one to extract, rebase and merge ahead of the big work. Regards, Tvrtko ___ Intel-gfx mailing list Intel-

  1   2   >