Hi,
> Hmm, I don't like that interface. Can you cite examples of other
> ioctls that behave this way? It doesn't feel like an elegant user
> interface; the user can get the dmabuf, but only after they query the
> dmabuf, even though the get-dmabuf ioctl returns the same data as the
> query-pla
On 2017-06-26 11:35, Daniel Vetter wrote:
> On Thu, Jun 22, 2017 at 08:06:23AM +0200, Peter Rosin wrote:
>> Hi!
>>
>> While trying to get CLUT support for the atmel_hlcdc driver, and
>> specifically for the emulated fbdev interface, I received some
>> push-back that my feeble in-driver attempts sho
On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> This removes the reset call from the reset_state function and renames
> it
> to disconnect_connector. Since a call to reset is already done in
> chamelium_init, there is no need to do an extra reset in each test.
>
> This allows reducin
On 20/06/17 11:25, Michel Thierry wrote:
From: Chris Wilson
The hang detector relies on a uevent for notification and aborting the
test. As proposed, fine-grained resets may not produce a global uevent
and so this hang detection becomes void. As we don't expect any hang, we
can just reduce th
rb'd and pushed, thanks!
On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> Using a 1 s delay seems too large for detecting a connector change,
> that
> may happen faster than this. Since the constraints on execution time
> are
> high, it is preferable to use a much smaller sleep time.
rb'd and pushed, thanks!
On Mon, 2017-06-26 at 16:59 +0300, Paul Kocialkowski wrote:
> Without doing a full reprobe, hpd toggles are sent without much delay
> between them. With a VGA connector attached, the reset occurring
> before
> the test will toggle its state, with a delay (inherent to hpd
>
On Monday, June 26, 2017 04:40:08 PM Lyude wrote:
> There's quite a number of machines on the market, mainly Lenovo
> ThinkPads, that make the horrible mistake in their firmware of reusing
> the PCIBAR space reserved for the SMBus for things that are completely
> unrelated to the SMBus controller,
> >
> > Fair enough, but at this point, only lib/igt_chamelium.c is using
> > igtrc and all
> > the parsing is implemented there.
> >
> > So one course of action here would be to move igtrc parsing outside
> > of
> > igt_chamelium (maybe to igt_core?) and use some global variable for
> > storing
This all looks great! I'm happy to see us finally getting rid of the
very hacky workaround I had to make async hotplugging work (to be fair,
it was only partly broken ;). Thanks for dealing with chameleond
upstream too, I couldn't stand how ugly the code in that thing is...
Anyway, this whole patc
== Series Details ==
Series: drm/i915: Disable MSI for all pre-gen5
URL : https://patchwork.freedesktop.org/series/26392/
State : failure
== Summary ==
Series 26392v1 drm/i915: Disable MSI for all pre-gen5
https://patchwork.freedesktop.org/api/1.0/series/26392/revisions/1/mbox/
Test kms_flip:
There's quite a number of machines on the market, mainly Lenovo
ThinkPads, that make the horrible mistake in their firmware of reusing
the PCIBAR space reserved for the SMBus for things that are completely
unrelated to the SMBus controller, such as the OpRegion used for i915.
This is very bad and e
From: Ville Syrjälä
We have pretty clear evidence that MSIs are getting lost on g4x and
somehow the interrupt logic doesn't seem to recover from that state
even if we try hard to clear the IIR.
Disabling IER around the normal IIR clearing in the irq handler isn't
sufficient to avoid this, so the
>
> I'm traveling and cannot make progress this week. The merge window is
> also real close so this series will therefore probably miss it unless
> something unexpected happens...
Don't worry you missed the merge window for drm already, we don't merge
things after -rc6. Please remember the Linus m
On 2017-06-20 01:57 PM, Andrey Grodzovsky wrote:
> Problem : While running IGT kms_atomic_transition test suite i encountered
> a hang in drmHandleEvent immediately following an atomic_commit.
> After dumping the atomic state I relized that in this case there was
> not even one CRTC attached to th
== Series Details ==
Series: series starting with [RESEND,1/2] drm/i915/dp: Fix the t11_t12 panel
power cycle delay from VBT read
URL : https://patchwork.freedesktop.org/series/26388/
State : success
== Summary ==
Series 26388v1 Series without cover letter
https://patchwork.freedesktop.org/ap
Now the VBT.seq->t11_t12 value adds 100ms to both Gen9_LP
as well as non Gen9_LP cases so no need to special case
and do -1 during HW readout and +1 during pp_div write
for Gen9_LP/CNP case.
Reviewed-by: Ville Syrjala
Signed-off-by: Manasi Navare
Suggested-by: Ville Syrjala
Cc: Ville Syrjala
C
When we read the VBT t11_t12 value for panel power cycle delay,
it is a zero based value so we need to 100ms to that. And then it
needs to be multiplied by 10 to store it in 100usecs unit same as
SW VBT.
v3:
* Add it as part of series
v2:
* Change the VBT value instead of HW readout and pp div (Vi
Patch looks correct,
Reviewed-by: Dhinakaran Pandiyan
On Mon, 2017-06-26 at 10:33 +0200, Maarten Lankhorst wrote:
> Commit 9a148a96fc3a ("drm/i915/debugfs: add dp mst info") adds support
> for DP-MST to intel_connector_info, but forgot to remove the early
> return for DP-MST.
>
> Remove it, an
== Series Details ==
Series: series starting with [1/2] drm/vmwgfx: Drop drm_vblank_cleanup
URL : https://patchwork.freedesktop.org/series/26379/
State : success
== Summary ==
Series 26379v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/26379/revisions/1/mbox/
T
On Mon, Jun 26, 2017 at 7:47 PM, Takashi Iwai wrote:
> On Mon, 26 Jun 2017 18:16:30 +0200,
> Daniel Vetter wrote:
>>
>> On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote:
>> > On Wed, 21 Jun 2017 17:23:57 +0200,
>> > Chris Wilson wrote:
>> > >
>> > > Quoting Daniel Vetter (2017-06-21 16
On Mon, 26 Jun 2017 18:16:30 +0200,
Daniel Vetter wrote:
>
> On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote:
> > On Wed, 21 Jun 2017 17:23:57 +0200,
> > Chris Wilson wrote:
> > >
> > > Quoting Daniel Vetter (2017-06-21 16:08:54)
> > > > So back when the i915 power well support lande
On Mon, 26 Jun 2017 08:39:17 +0200
Gerd Hoffmann wrote:
> Hi,
>
> > > With the generation we can also do something different: Pass in
> > > plane_type and
> > > generation, and have VFIO_DEVICE_GET_DMABUF_FD return an error in
> > > case
> > > the generation doesn't match. In that case it do
On Mon, 2017-06-26 at 10:18 +0200, Maarten Lankhorst wrote:
> When reading all debugfs files on a system with DP-MST the kernel panics
> on a null pointer dereference because intel_dp is null for a DP-MST
> connector. Detect this case and skip those connectors.
>
> Also fix the write for the DP
On Thu, Jun 22, 2017 at 12:25:24PM -0700, Manasi Navare wrote:
> Now the VBT.seq->t11_t12 value adds 100ms to both Gen9_LP
> as well as non Gen9_LP cases so no need to special case
> and do -1 during HW readout and +1 during pp_div write
> for Gen9_LP/CNP case.
>
> Signed-off-by: Manasi Navare
>
Again stopping the vblank before uninstalling the irq handler is kinda
the wrong way round, but the fb_off stuff should take care of
disabling the dsiplay at least in most cases. So drop the
drm_vblank_cleanup code since it's not really doing anything, it looks
all cargo-culted.
v2: Appease gcc be
There's no reason for drivers to call this, and all the ones I've
removed looked very fishy:
- Proper quiescenting of the vblank machinery should be done by
calling drm_crtc_vblank_off(), which is best done by shutting down
the entire display engine with drm_atomic_helper_shutdown.
- Releasing
On Wed, Jun 21, 2017 at 05:30:10PM +0200, Takashi Iwai wrote:
> On Wed, 21 Jun 2017 17:23:57 +0200,
> Chris Wilson wrote:
> >
> > Quoting Daniel Vetter (2017-06-21 16:08:54)
> > > So back when the i915 power well support landed in
> > >
> > > commit 99a2008d0b32d72dfc2a54e7be1eb698dd2e3bd6
> > >
On Fri, Jun 23, 2017 at 12:31:39PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Small series which saves test execution time by removing the redundant tests.
>
> Tvrtko Ursulin (4):
> igt: Remove default from the engine list
> gem_exec_basic: Exercise the default engine selection
On Fri, Jun 23, 2017 at 12:21:48PM +0100, Chris Wilson wrote:
> Quoting Daniel Vetter (2017-06-23 12:14:49)
> > On Thu, Jun 22, 2017 at 12:45 PM, Tvrtko Ursulin
> > wrote:
> > >
> > > On 22/06/2017 10:54, Daniel Vetter wrote:
> > >>
> > >> On Fri, Jun 16, 2017 at 12:55 PM, Tvrtko Ursulin
> > >> w
== Series Details ==
Series: New engine discovery and execbuffer2 engine selection uAPI (rev8)
URL : https://patchwork.freedesktop.org/series/23189/
State : success
== Summary ==
Series 23189v8 New engine discovery and execbuffer2 engine selection uAPI
https://patchwork.freedesktop.org/api/1.0
From: Tvrtko Ursulin
Submit a few valid and invalid no-op batches using the new class-
instance execbuf interface.
Signed-off-by: Tvrtko Ursulin
---
tests/Makefile.sources | 1 +
tests/gem_exec_class_instance.c | 177
2 files changed, 178 ins
From: Tvrtko Ursulin
Test that the engine info ioctl works.
Signed-off-by: Tvrtko Ursulin
---
tests/Makefile.sources | 1 +
tests/gem_engine_info.c | 317
2 files changed, 318 insertions(+)
create mode 100644 tests/gem_engine_info.c
diff --
From: Tvrtko Ursulin
Building on top of the previous patch which exported the concept
of engine classes and instances, we can also use this instead of
the current awkward engine selection uAPI.
This is primarily interesting for the VCS engine selection which
is a) currently done via disjoint set
From: Tvrtko Ursulin
Engine discovery uAPI allows userspace to probe for engine
configuration and features without needing to maintain the
internal PCI id based database.
This enables removal of code duplications across userspace
components.
Probing is done via the new DRM_IOCTL_I915_GEM_ENGINE
On 26/06/17 17:33, Paul Kocialkowski wrote:
On Mon, 2017-06-26 at 17:25 +0300, Martin Peres wrote:
On 26/06/17 16:59, Paul Kocialkowski wrote:
This adds support for reading a SuspendResumeDelay property (under
[DUT]) in the IGT configuration (igtrc) and exposing it through a
chamelium_get_suspe
Link to FDO regression list:
https://bugs.freedesktop.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&bug_status=NEEDINFO&component=DRM%2FIntel&f0=OP&f1=OP&f2=short_desc&f3=keywords&f4=CP&f5=CP&j1=OR&known_name=i915%20regressions&list_id=600614&o2=anywordssubstr&o3=anywordss
Highlights:
- 15 bugs open during the week
- 11 bugs closed during the week
- 350 total bugs remain open
- 27 bugs labeled ReadyForDev during the week
- 111 total bugs labeled ReadyForDev remain open
Details:
- Bugs open during the week (
On Mon, 2017-06-26 at 17:25 +0300, Martin Peres wrote:
> On 26/06/17 16:59, Paul Kocialkowski wrote:
> > This adds support for reading a SuspendResumeDelay property (under
> > [DUT]) in the IGT configuration (igtrc) and exposing it through a
> > chamelium_get_suspend_resume_delay function.
> >
> >
On 26/06/17 16:59, Paul Kocialkowski wrote:
This adds support for reading a SuspendResumeDelay property (under
[DUT]) in the IGT configuration (igtrc) and exposing it through a
chamelium_get_suspend_resume_delay function.
Signed-off-by: Paul Kocialkowski
---
lib/igt_chamelium.c | 31 +
On Thu, Jun 22, 2017 at 12:03:39PM -0700, Puthikorn Voravootivat wrote:
> This patch adds option to enable dynamic backlight for eDP
> panel that supports this feature via DPCD register and
> set minimum / maximum brightness to 0% and 100% of the
> normal brightness.
This patch causes a regression
This renames the reprobe_connector function to update_connector and
ensures that full reprobe of the connector is only done when really
necessary (e.g. when changing the EDID).
A full reprobe takes time and is not required for updating the connector
state. Thus, this allows executing tests faster.
Now that the suspend/resume delay can be configured in the IGT
configuration (igtrc), use it in the chamelium suspend/resume tests.
Signed-off-by: Paul Kocialkowski
---
tests/chamelium.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/tests/chamelium.c b/tests
This adds support for reading a SuspendResumeDelay property (under
[DUT]) in the IGT configuration (igtrc) and exposing it through a
chamelium_get_suspend_resume_delay function.
Signed-off-by: Paul Kocialkowski
---
lib/igt_chamelium.c | 31 ++-
lib/igt_chamelium.h |
Using a 1 s delay seems too large for detecting a connector change, that
may happen faster than this. Since the constraints on execution time are
high, it is preferable to use a much smaller sleep time.
Signed-off-by: Paul Kocialkowski
---
tests/chamelium.c | 2 +-
1 file changed, 1 insertion(+)
Without doing a full reprobe, hpd toggles are sent without much delay
between them. With a VGA connector attached, the reset occurring before
the test will toggle its state, with a delay (inherent to hpd detection
on VGA).
It often occurs that this VGA state toggle is detected in the middle of
the
This removes the reset call from the reset_state function and renames it
to disconnect_connector. Since a call to reset is already done in
chamelium_init, there is no need to do an extra reset in each test.
This allows reducing the execution time a bit.
Signed-off-by: Paul Kocialkowski
---
test
Since VGA hpd detection is done through RGB lines load detection and
nowadays often goes through a bridge to some digital interface, HPD
detection usually takes a while (up to a couple seconds).
Thus, it is not as relevant to stress it as many as 15 times.
This brings the toggle count down to 5 ti
== Series Details ==
Series: drm/i915: Synchronize connectors states when switching from poll to irq
URL : https://patchwork.freedesktop.org/series/26361/
State : success
== Summary ==
Series 26361v1 drm/i915: Synchronize connectors states when switching from poll
to irq
https://patchwork.fre
With the below fixed,
Reviewed-by: Thomas Hellstrom
On 06/23/2017 04:10 PM, Sean Paul wrote:
On Wed, Jun 21, 2017 at 10:28:48AM +0200, Daniel Vetter wrote:
Again stopping the vblank before uninstalling the irq handler is kinda
the wrong way round, but the fb_off stuff should take care of
dis
After detecting an IRQ storm, hotplug detection will switch from
irq-based detection to poll-based detection. After a short delay or
when resetting storm detection from debugfs, detection will switch
back to being irq-based.
However, it may occur that polling does not have enough time to detect
th
On 23 June 2017 at 17:45, Ben Widawsky wrote:
> This was based on a patch originally by Kristian. It has been modified
> pretty heavily to use the new callbacks from the previous patch.
>
> v2:
> - Add LINEAR and Yf modifiers to list (Ville)
> - Combine i8xx and i965 into one list of formats (
On Wed, 2017-06-21 at 21:19 +0530, Sharma, Shashank wrote:
> Regards
>
> Shashank
>
>
> On 6/20/2017 7:50 PM, Ander Conselvan De Oliveira wrote:
> > On Mon, 2017-06-19 at 21:38 +0530, Shashank Sharma wrote:
> > > This patch checks encoder level support for HDMI YCBCR outputs.
> > > HDMI output m
== Series Details ==
Series: drm/i915: Make DP-MST connector info work
URL : https://patchwork.freedesktop.org/series/26352/
State : success
== Summary ==
Series 26352v1 drm/i915: Make DP-MST connector info work
https://patchwork.freedesktop.org/api/1.0/series/26352/revisions/1/mbox/
Test gem
== Series Details ==
Series: drm/i915: Prevent kernel panic on reading out compliance debugfs files
(rev2)
URL : https://patchwork.freedesktop.org/series/26139/
State : success
== Summary ==
Series 26139v2 drm/i915: Prevent kernel panic on reading out compliance debugfs
files
https://patchwo
On Thu, Jun 22, 2017 at 08:06:23AM +0200, Peter Rosin wrote:
> Hi!
>
> While trying to get CLUT support for the atmel_hlcdc driver, and
> specifically for the emulated fbdev interface, I received some
> push-back that my feeble in-driver attempts should be solved
> by the core. This is my attempt
On Thu, Jun 22, 2017 at 12:22:10PM +0200, Peter Rosin wrote:
> This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get
> totally obsolete.
>
> Signed-off-by: Peter Rosin
> ---
> drivers/gpu/drm/drm_fb_helper.c | 151
> +---
> 1 file changed,
On Thu, Jun 22, 2017 at 08:06:24AM +0200, Peter Rosin wrote:
> I think the gamma_store can end up invalid on error. But the way I read
> it, that can happen in drm_mode_gamma_set_ioctl as well, so why should
> this pesky legacy fbdev stuff be any better?
>
> Signed-off-by: Peter Rosin
> ---
> dr
Op 14-06-17 om 15:44 schreef Ville Syrjälä:
> On Wed, Jun 14, 2017 at 11:08:42AM +0200, Maarten Lankhorst wrote:
>> The nonblocking modeset tests were failing on systems with a DP output,
>> because lijnk training could occur during the modeset.
>>
>> With normal modesets we're protected by the con
On Thu, Jun 22, 2017 at 08:06:26AM +0200, Peter Rosin wrote:
> This makes the redundant fb helpers .load_lut, .gamma_set and .gamma_get
> totally obsolete.
>
> Signed-off-by: Peter Rosin
> ---
> drivers/gpu/drm/drm_fb_helper.c | 154
>
> 1 file changed,
On Thu, Jun 22, 2017 at 08:06:25AM +0200, Peter Rosin wrote:
> drm_fb_helper_save_lut_atomic is redundant since the .gamma_store is
> now always kept up to date by drm_fb_helper_setcmap.
>
> Signed-off-by: Peter Rosin
Also note that this is for kgdb support only and so likely very buggy
(since n
On Fri, 2017-06-23 at 15:35 +0100, Tvrtko Ursulin wrote:
> On 23/06/2017 15:17, Szwichtenberg, Radoslaw wrote:
> > On Fri, 2017-06-23 at 12:31 +0100, Tvrtko Ursulin wrote:
> > > From: Tvrtko Ursulin
> > >
> > > Default is not an engine but an ABI alias for RCS. Remove it
> > > from the engine lis
Commit 9a148a96fc3a ("drm/i915/debugfs: add dp mst info") adds support
for DP-MST to intel_connector_info, but forgot to remove the early
return for DP-MST.
Remove it, and print out MST connectors directly.
Fixes: 9a148a96fc3a ("drm/i915/debugfs: add dp mst info")
Cc: # v4.11+
Cc: Dhinakaran Pan
When reading all debugfs files on a system with DP-MST the kernel panics
on a null pointer dereference because intel_dp is null for a DP-MST
connector. Detect this case and skip those connectors.
Also fix the write for the DP compliance file in the same way.
Changes since v1:
- Fix i915_displaypo
This adds support for the newly-introduced ScheduleHpdToggle XMLRPC
method of the Chamelium's interface. It allows scheduling an HPD toggle,
for which the call will return immediately.
This is especially useful for testing HPD during suspend/resume.
Signed-off-by: Paul Kocialkowski
---
lib/igt_
This adds HPD toggle after suspend and hibernate testing for VGA, in the
same fashion as currently done for DP and HDMI.
---
tests/chamelium.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/tests/chamelium.c b/tests/chamelium.c
index c7114987..07dc4849 100644
---
This removes the functions related to async hpd pulse handling, that
were used for hpd toggle during suspend testing. Since the XMLRPC
library does not guarantee that the call will be made before caring
for its result, this function did not work properly.
These functions are deprecated in favor of
Now that HPD toggle during suspend and hibernate can be tested for VGA
as well, there is no need to exclude it in the common tests.
Signed-off-by: Paul Kocialkowski
---
tests/chamelium.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/tests/chamelium.c b/tests/chamelium.c
index 07dc4
This switches over to HPD toggle scheduling instead of starting pulses
with an asynchronous call, suspending and dealing with the result at
resume.
The XMLRPC library does not guarantee that the call will be made before
caring for its outcome and this is in fact what was happening:
the call was be
Op 22-06-17 om 14:40 schreef Chris Wilson:
> Quoting ville.syrj...@linux.intel.com (2017-06-22 12:55:40)
>> From: Ville Syrjälä
>>
>> The GEN5_IRQ_RESET/INIT macros are perfectly suitable even for
>> gen3/4 hardware as those have 32 bit interrupt registers. Let's
>> rename the macros to reflect th
69 matches
Mail list logo
