Re: [Intel-gfx] [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-02-10 Thread Chris Wilson
Quoting Daniel Vetter (2020-02-04 15:01:45) > We want to only take the BKL on crap drivers, but to know whether > we have a crap driver we first need to look it up. Split this shuffle > out from the main BKL-disabling patch, for more clarity. Historical > aside: When the kernel-wide BKL was removed

Re: [Intel-gfx] [PATCH 5/5] drm: Nerf drm_global_mutex BKL for good drivers

2020-02-10 Thread Chris Wilson
Quoting Daniel Vetter (2020-02-04 15:01:46) > This catches the majority of drivers (unfortunately not if we take > users into account, because all the big drivers have at least a > lastclose hook). > > With the prep patches out of the way all drm state is fully protected > and either prevents or c

Re: [Intel-gfx] [PATCH v3 04/17] drm/i915/dp: Add writing of DP SDPs (Secondary Data Packet)

2020-02-10 Thread Shankar, Uma
> -Original Message- > From: Mun, Gwan-gyeong > Sent: Sunday, February 9, 2020 9:05 AM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Cc: dri-de...@lists.freedesktop.org; linux-fb...@vger.kernel.org > Subject: Re: [PATCH v3 04/17] drm/i915/dp: Add writing of DP SDPs (Secondary >

Re: [Intel-gfx] [PATCH v2 1/6] drm: Include the encoder itself in possible_clones

2020-02-10 Thread Thomas Zimmermann
Hi Am 07.02.20 um 17:27 schrieb Daniel Vetter: > On Fri, Feb 07, 2020 at 04:50:01PM +0200, Ville Syrjälä wrote: >> On Fri, Feb 07, 2020 at 03:28:35PM +0100, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 07.02.20 um 14:59 schrieb Ville Syrjala: From: Ville Syrjälä The docs say possible

Re: [Intel-gfx] Paging out when free memory is low but not exhausted (and available memory remains high)

2020-02-10 Thread Michal Hocko
[Let's CC i915 people - the email thread started here: http://lkml.kernel.org/r/e994b0a76099437b8edbae925e9cc...@its-mail-p04.registry.otago.ac.nz Long story short, there is a swap out activity even when there is a clean page cache available that could be reclaimed and there is a suspicion that the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/gt: Prevent queuing retire workers on the virtual engine (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/gt: Prevent queuing retire workers on the virtual engine (rev2) URL : https://patchwork.freedesktop.org/series/73116/ State : success == Summary == CI Bug Log - changes from CI_DRM_7882_full -> Patchwork_16476_full =

Re: [Intel-gfx] [PATCH 0/5] disable drm_global_mutex for most drivers, take 2

2020-02-10 Thread Thomas Zimmermann
Hi, I smoke-tested the patchset by running X11, Weston and fbdev emulation on ast and udl. No apparent problems found, so Tested-by: Thomas Zimmermann Best regards Thomas Am 04.02.20 um 16:01 schrieb Daniel Vetter: > CI didn't like my test-with tag :-/ > > Test-with: 20200128112549.172135-1-d

[Intel-gfx] [PATCH i-g-t] intel-ci: Enable gem_exec_whisper

2020-02-10 Thread Chris Wilson
In hindsignt, gem_exec_whisper has an excellent detection rate for the 5.3/5.4 faux pas. Had it been enabled... Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- tests/i915/gem_exec_whisper.c | 31 +-- tests/intel-ci/blacklist.txt | 2 +- 2 files changed, 18 inse

[Intel-gfx] ✗ Fi.CI.IGT: failure for disable drm_global_mutex for most drivers (rev7)

2020-02-10 Thread Patchwork
== Series Details == Series: disable drm_global_mutex for most drivers (rev7) URL : https://patchwork.freedesktop.org/series/72711/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7877_full -> Patchwork_16468_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/3] drm/i915: Introduce encoder->compute_config_late()

2020-02-10 Thread Manasi Navare
The failed test cases are not related to any changes in this patch Mansi On Wed, Feb 05, 2020 at 03:19:24PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/3] drm/i915: Introduce > encoder->compute_config_late() > URL : https://patchwork.freedesktop.org/s

Re: [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled()

2020-02-10 Thread Mika Kuoppala
Jani Nikula writes: > Make future work slightly easier. > > Signed-off-by: Jani Nikula Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/display/intel_psr.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c > b/dr

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/dp: Add all tiled and port sync conns to modeset

2020-02-10 Thread Manasi Navare
On Wed, Feb 05, 2020 at 04:32:48PM +0200, Ville Syrjälä wrote: > On Sun, Feb 02, 2020 at 11:47:56PM -0800, Manasi Navare wrote: > > If one of the synced crtcs needs a full modeset, we need > > to make sure all the synced crtcs are forced a full > > modeset. > > > > v2: > > * Add tiles based on cpu

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/dp: Compute port sync crtc states post compute_config()

2020-02-10 Thread Manasi Navare
Thanks for the review will make the changes and add your r-b Manasi On Wed, Feb 05, 2020 at 04:25:44PM +0200, Ville Syrjälä wrote: > On Sun, Feb 02, 2020 at 11:47:55PM -0800, Manasi Navare wrote: > > This patch pushes out the computation of master and slave > > transcoders in crtc states after en

Re: [Intel-gfx] [igt-dev] ✓ Fi.CI.IGT: success for tests/gem_userptr_blits: Enhance invalid mapping exercise

2020-02-10 Thread Janusz Krzysztofik
(adding intel-gfx to the loop) Hi Chris, On Wednesday, January 29, 2020 12:24:39 PM CET Chris Wilson wrote: > Quoting Patchwork (2020-01-23 20:22:25) > > == Series Details == > > > > Series: tests/gem_userptr_blits: Enhance invalid mapping exercise > > URL : https://patchwork.freedesktop.org/s

Re: [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Disable capturing forced error states

2020-02-10 Thread Mika Kuoppala
Chris Wilson writes: > When we are forcing the error for a selftest, we don't need to capture > the GPU state (typically). > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gem/selftests/mock_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --g

Re: [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable

2020-02-10 Thread Jani Nikula
On Wed, 05 Feb 2020, Jani Nikula wrote: > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to > encoders on DDI platforms") pushed pipe and vblank enable to encoders on > DDI platforms, however it missed the DP MST encoder. Fix it. > > Fixes: 21fd23ac222f ("drm/i915: move pipe, pch

Re: [Intel-gfx] [PATCH 2/4] drm/i915/selftests: Drop live_preempt_hang

2020-02-10 Thread Mika Kuoppala
Chris Wilson writes: > live_preempt_hang's use of hang injection has been superseded by > live_preempt_reset's use of an non-preemptable spinner. The latter does > not require intrusive hacks into the code. > > Signed-off-by: Chris Wilson Good riddance, Reviewed-by: Mika Kuoppala > --- > dr

Re: [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable

2020-02-10 Thread Lisovskiy, Stanislav
On Mon, 2020-02-10 at 13:32 +0200, Jani Nikula wrote: > On Wed, 05 Feb 2020, Jani Nikula wrote: > > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to > > encoders on DDI platforms") pushed pipe and vblank enable to > > encoders on > > DDI platforms, however it missed the DP MST e

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel-ci: Enable gem_exec_whisper

2020-02-10 Thread Petri Latvala
On Mon, Feb 10, 2020 at 10:11:35AM +, Chris Wilson wrote: > In hindsignt, Your h is damaged. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] intel-ci: Enable gem_exec_whisper

2020-02-10 Thread Chris Wilson
Quoting Petri Latvala (2020-02-10 11:44:53) > On Mon, Feb 10, 2020 at 10:11:35AM +, Chris Wilson wrote: > > In hindsignt, > > Your h is damaged. And soul. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.or

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev2)

2020-02-10 Thread Kai Vehmanen
Hey, some delay but coming back to this CI failure: On Fri, 31 Jan 2020, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add missing HDMI audio pixel clocks for gen12 (rev2) > URL : https://patchwork.freedesktop.org/series/72617/ > State : failure I've been going through the lo

Re: [Intel-gfx] [PATCH 1/8] drm/i915/execlists: Fix hold/unhold recursion

2020-02-10 Thread Tvrtko Ursulin
On 09/02/2020 13:19, Chris Wilson wrote: In eliminating the recursion from walking the tree of signalers/waiters for processing the hold/unhold operations, a crucial error crept in where we looked at the parent request and not the list element when processing the list. Brown paper bag, much?

Re: [Intel-gfx] [PATCH 4/8] drm/i915/selftests: Remove erroneous intel_engine_pm_put

2020-02-10 Thread Tvrtko Ursulin
On 09/02/2020 13:19, Chris Wilson wrote: On an allocation error path for live_hwsp_alternate, we dropped the engine wakeref before we had even acquired it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/selftest_timeline.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers

[Intel-gfx] ✓ Fi.CI.IGT: success for disable drm_global_mutex for most drivers (rev7)

2020-02-10 Thread Patchwork
== Series Details == Series: disable drm_global_mutex for most drivers (rev7) URL : https://patchwork.freedesktop.org/series/72711/ State : success == Summary == CI Bug Log - changes from CI_DRM_7877_full -> Patchwork_16468_full Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size

2020-02-10 Thread Matthew Auld
On Thu, 6 Feb 2020 at 14:10, Chris Wilson wrote: > > Reduce the amount of work we do to verify client blt correctness as > currently our 0.5s subtests takes about 15s on slower devices! > > v2: Grow the maximum block size until we run out of time > > Signed-off-by: Chris Wilson Is that bsw-kefka

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size

2020-02-10 Thread Chris Wilson
Quoting Matthew Auld (2020-02-10 12:47:35) > On Thu, 6 Feb 2020 at 14:10, Chris Wilson wrote: > > > > Reduce the amount of work we do to verify client blt correctness as > > currently our 0.5s subtests takes about 15s on slower devices! > > > > v2: Grow the maximum block size until we run out of t

Re: [Intel-gfx] [PATCH] drm/i915/psr: pass i915 to psr_global_enabled()

2020-02-10 Thread Jani Nikula
On Mon, 10 Feb 2020, Mika Kuoppala wrote: > Jani Nikula writes: > >> Make future work slightly easier. >> >> Signed-off-by: Jani Nikula > > Reviewed-by: Mika Kuoppala Pushed to dinq, thanks for the review. BR, Jani. > >> --- >> drivers/gpu/drm/i915/display/intel_psr.c | 8 >> 1 fil

[Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Andi Shyti
"We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) I agree, change the functions name from "debugfs_*" to "intel_gt_*" prefix. [*] https://patchwork.freedesktop.org/patch/352553/#comment_651183 Signed-off-by: Andi Shyti Cc: Jani Nikula --- drivers/gpu/drm/i915/gt/debugfs_engines

Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Chris Wilson
Quoting Andi Shyti (2020-02-10 13:40:39) > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > I agree, change the functions name from "debugfs_*" to > "intel_gt_*" prefix. > > [*] https://patchwork.freedesktop.org/patch/352553/#comment_651183 > > Signed-off-by: Andi Shyti > Cc

Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Chris Wilson
Quoting Andi Shyti (2020-02-10 13:40:39) > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > I agree, change the functions name from "debugfs_*" to > "intel_gt_*" prefix. An alternate way of looking at it is that these are all dependent on CONFIG_DEBUGFS. So are they not the de

Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Andi Shyti
Hi Chris, > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > > > I agree, change the functions name from "debugfs_*" to > > "intel_gt_*" prefix. > > An alternate way of looking at it is that these are all dependent on > CONFIG_DEBUGFS. So are they not the debugfs interface?

Re: [Intel-gfx] [PATCH] drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Chris Wilson
Quoting Andi Shyti (2020-02-10 13:58:08) > Hi Chris, > > > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > > > > > I agree, change the functions name from "debugfs_*" to > > > "intel_gt_*" prefix. > > > > An alternate way of looking at it is that these are all dependent on

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/selftests: Disable capturing forced error states

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Disable capturing forced error states URL : https://patchwork.freedesktop.org/series/73221/ State : warning == Summary == $ dim checkpatch origin/drm-tip c6407ea9ac72 drm/i915/selftests: Disable capturing forced error

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915/selftests: Disable capturing forced error states

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Disable capturing forced error states URL : https://patchwork.freedesktop.org/series/73221/ State : success == Summary == CI Bug Log - changes from CI_DRM_7900 -> Patchwork_16501 ==

Re: [Intel-gfx] [PATCH] drm/i915/mst: fix pipe and vblank enable

2020-02-10 Thread Arkadiusz Hiler
On Mon, Feb 10, 2020 at 01:43:47PM +0200, Lisovskiy, Stanislav wrote: > On Mon, 2020-02-10 at 13:32 +0200, Jani Nikula wrote: > > On Wed, 05 Feb 2020, Jani Nikula wrote: > > > Commit 21fd23ac222f ("drm/i915: move pipe, pch and vblank enable to > > > encoders on DDI platforms") pushed pipe and vbla

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/gem: Don't leak non-persistent requests on changing engines

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gem: Don't leak non-persistent requests on changing engines URL : https://patchwork.freedesktop.org/series/73134/ State : success == Summary == CI Bug Log - changes from CI_DRM_7886_full -> Patchwork_16478_full =

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915/gem: Don't leak non-persistent requests on changing engines

2020-02-10 Thread Chris Wilson
Quoting Patchwork (2020-02-10 16:00:41) > Possible fixes > > * {igt@gem_ctx_persistence@replace-hostile@vcs0}: > - shard-kbl: [FAIL][27] ([i915#1154]) -> [PASS][28] +9 similar > issues >[27]: > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7886/shard-kbl1/igt@gem_ct

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gt: Use the kernel_context to measure the breadcrumb size

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Use the kernel_context to measure the breadcrumb size URL : https://patchwork.freedesktop.org/series/73143/ State : success == Summary == CI Bug Log - changes from CI_DRM_7886_full -> Patchwork_16479_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Make sure to sanitize CT status

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Make sure to sanitize CT status URL : https://patchwork.freedesktop.org/series/73146/ State : success == Summary == CI Bug Log - changes from CI_DRM_7886_full -> Patchwork_16480_full Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix force-probe failure message

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix force-probe failure message URL : https://patchwork.freedesktop.org/series/73149/ State : success == Summary == CI Bug Log - changes from CI_DRM_7886_full -> Patchwork_16481_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Try to fix encoder possible_clones/crtc (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: drm: Try to fix encoder possible_clones/crtc (rev2) URL : https://patchwork.freedesktop.org/series/63399/ State : success == Summary == CI Bug Log - changes from CI_DRM_7886_full -> Patchwork_16482_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: change prefix to debugfs functions

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: change prefix to debugfs functions URL : https://patchwork.freedesktop.org/series/73239/ State : success == Summary == CI Bug Log - changes from CI_DRM_7900 -> Patchwork_16503 Summary --- **S

[Intel-gfx] [PATCH] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Chris Wilson
We manipulate ring->head while active in i915_request_retire underneath the timeline manipulation. We cannot rely on a stable ring->head outside of the timeline->mutex, in particular while setting up the context for resume and reset. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1126 Ref

[Intel-gfx] [PATCH] drm/i915: terminate reauth at stream management failure

2020-02-10 Thread Ramalingam C
As per the HDCP2.2 compliance test 1B-10 expectation, when stream management for a repeater fails, HDCP2.2 reauthentication stops at kernel. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/display/intel_hdcp.c | 55 ++- 1 file changed, 34 insertions(+), 21 deletions(-)

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/ehl: Add HBR2 and HBR3 voltage swing table

2020-02-10 Thread Souza, Jose
On Sat, 2020-02-08 at 11:25 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/display/ehl: Add HBR2 and HBR3 voltage swing table > URL : https://patchwork.freedesktop.org/series/73055/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7871_full -> Patch

[Intel-gfx] [PATCH v6 01/18] drm: Add DP1.4 VSC SDP Payload related Data Structures

2020-02-10 Thread Gwan-gyeong Mun
It adds new enumeration definitions for VSC SDP Payload for Pixel Encoding/Colorimetry Format. And it adds a new drm data structure for DP VSC SDP. enum dp_colorspace and enum dp_colorimetry correspond "Pixel Encoding and Colorimetry Formats". enum dp_dynamic_range corresponds "Dynamic Range". And

[Intel-gfx] [PATCH v6 02/18] drm/i915/dp: Add compute routine for DP VSC SDP

2020-02-10 Thread Gwan-gyeong Mun
In order to support state readout for DP VSC SDP, we need to have a structure which holds DP VSC SDP payload data such as "union hdmi_infoframe drm" which is used for DRM infoframe. It adds a struct drm_dp_vsc_sdp vsc to intel_crtc_state.infoframes. And it stores computed dp vsc sdp to infoframes.

[Intel-gfx] [PATCH v6 07/18] drm: Add logging function for DP VSC SDP

2020-02-10 Thread Gwan-gyeong Mun
When receiving video it is very useful to be able to log DP VSC SDP. This greatly simplifies debugging. v2: Minor style fix v3: Move logging functions to drm core [Jani N] v5: Rebased Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/drm_dp_helper.c | 174

[Intel-gfx] [PATCH v6 00/18] In order to readout DP SDPs, refactors the handling of DP SDPs

2020-02-10 Thread Gwan-gyeong Mun
In order to readout DP SDPs (Secondary Data Packet: DP HDR Metadata Infoframe SDP, DP VSC SDP), it refactors handling DP SDPs codes. It adds new compute routines for DP HDR Metadata Infoframe SDP and DP VSC SDP. And new writing routines of DP SDPs (Secondary Data Packet) that uses computed configs

[Intel-gfx] [PATCH v6 06/18] drm/i915/dp: Read out DP SDPs

2020-02-10 Thread Gwan-gyeong Mun
It adds code to read the DP SDPs from the video DIP and unpack them into the crtc state. It adds routines that read out DP VSC SDP and DP HDR Metadata Infoframe SDP In order to unpack DP VSC SDP, it adds intel_dp_vsc_sdp_unpack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header Byte

[Intel-gfx] [PATCH v6 05/18] video/hdmi: Add Unpack only function for DRM infoframe

2020-02-10 Thread Gwan-gyeong Mun
It adds an unpack only function for DRM infoframe for dynamic range and mastering infoframe readout. It unpacks the information data block contained in the binary buffer into a structured frame of the HDMI Dynamic Range and Mastering (DRM) information frame. In contrast to hdmi_drm_infoframe_unpac

[Intel-gfx] [PATCH v6 04/18] drm/i915/dp: Add writing of DP SDPs

2020-02-10 Thread Gwan-gyeong Mun
It adds routines that write DP VSC SDP and DP HDR Metadata Infoframe SDP. In order to pack DP VSC SDP, it adds intel_dp_vsc_sdp_pack() function. It follows DP 1.4a spec. [Table 2-116: VSC SDP Header Bytes] and [Table 2-117: VSC SDP Payload for DB16 through DB18] In order to pack DP HDR Metadata In

[Intel-gfx] [PATCH v6 08/18] drm/i915: Include HDMI DRM infoframe in the crtc state dump

2020-02-10 Thread Gwan-gyeong Mun
Dump out the HDMI Dynamic Range and Mastering (DRM) infoframe in the normal crtc state dump. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display

[Intel-gfx] [PATCH v6 03/18] drm/i915/dp: Add compute routine for DP HDR Metadata Infoframe SDP

2020-02-10 Thread Gwan-gyeong Mun
It stores computed dp hdr metadata infoframe sdp to infoframes.drm of crtc state. It referenced intel_hdmi_compute_drm_infoframe(). While computing, we'll also fill out the infoframes.enable bitmask appropriately. v2: Wrap a long line. v4: Use struct drm_device logging macros v5: Fix typo [Uma]

[Intel-gfx] [PATCH v6 16/18] drm/i915: Stop sending DP SDPs on ddi disable

2020-02-10 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes(false) function on intel_ddi_post_disable_dp() to make sure not to send VSC SDP and HDR Metadata Infoframe SDP. v5: Polish commit message [Uma] Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ 1 file chang

[Intel-gfx] [PATCH v6 09/18] drm/i915: Include DP HDR Metadata Infoframe SDP in the crtc state dump

2020-02-10 Thread Gwan-gyeong Mun
Dump out the DP HDR Metadata Infoframe SDP in the normal crtc state dump. HDMI Dynamic Range and Mastering (DRM) infoframe and DP HDR Metadata Infoframe SDP use the same member variable in infoframes of crtc state. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v6 12/18] drm/i915: Add state readout for DP HDR Metadata Infoframe SDP

2020-02-10 Thread Gwan-gyeong Mun
Added state readout for DP HDR Metadata Infoframe SDP. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_

[Intel-gfx] [PATCH v6 18/18] drm/i915/psr: Use new DP VSC SDP compute routine on PSR

2020-02-10 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it uses a new psr vsc sdp compute routine. Because PSR routine has its own scenario and timings of writing a VSC SDP, the current PSR routine needs to have its own drm_dp_vsc_sdp structure member variable on struct i915_psr. In

[Intel-gfx] [PATCH v6 17/18] drm/i915/dp: Add compute routine for DP PSR VSC SDP

2020-02-10 Thread Gwan-gyeong Mun
In order to use a common VSC SDP Colorimetry calculating code on PSR, it adds a compute routine for PSR VSC SDP. As PSR routine can not use infoframes.vsc of crtc state, it also adds new writing of DP SDPs (Secondary Data Packet) for PSR. PSR routine has its own scenario and timings of writing a VS

[Intel-gfx] [PATCH v6 14/18] drm/i915: Fix enabled infoframe states of lspcon

2020-02-10 Thread Gwan-gyeong Mun
Compared to implementation of DP and HDMI's encoder->infoframes_enabled, the lspcon's implementation returns its active state. (we expect enabled infoframe states of HW.) It leads to pipe state mismatch error when ddi_get_config is called. Because the current implementation of lspcon is not ready

[Intel-gfx] [PATCH v6 10/18] drm/i915: Include DP VSC SDP in the crtc state dump

2020-02-10 Thread Gwan-gyeong Mun
Dump out the DP VSC SDP in the normal crtc state dump v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp Use drm core's DP VSC SDP logging function Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display.c | 13 +

[Intel-gfx] [PATCH v6 15/18] drm/i915: Program DP SDPs on pipe updates

2020-02-10 Thread Gwan-gyeong Mun
Call intel_dp_set_infoframes() function on pipe updates to make sure that we send VSC SDP and HDR Metadata Infoframe SDP (when applicable) on fastsets. Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1 insertion(+) dif

[Intel-gfx] [PATCH v6 13/18] drm/i915: Add state readout for DP VSC SDP

2020-02-10 Thread Gwan-gyeong Mun
Added state readout for DP VSC SDP and enabled state validation for DP VSC SDP. v2: Minor style fix v3: Replace a structure name to drm_dp_vsc_sdp from intel_dp_vsc_sdp v4: Use struct drm_device logging macros Signed-off-by: Gwan-gyeong Mun Reviewed-by: Uma Shankar --- drivers/gpu/drm/i915/dis

[Intel-gfx] [PATCH v6 11/18] drm/i915: Program DP SDPs with computed configs

2020-02-10 Thread Gwan-gyeong Mun
In order to use computed config for DP SDPs (DP VSC SDP and DP HDR Metadata Infoframe SDP), it replaces intel_dp_vsc_enable() function and intel_dp_hdr_metadata_enable() function to intel_dp_set_infoframes() function. And it removes unused functions. Before: intel_dp_vsc_enable() and intel_dp_hdr

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dc3co: Add description of how it works

2020-02-10 Thread Souza, Jose
On Sat, 2020-02-08 at 12:22 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/dc3co: Add description of how it works > URL : https://patchwork.freedesktop.org/series/73058/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7871_full -> Patchwork_16444_f

[Intel-gfx] ✓ Fi.CI.BAT: success for Adding YUV444 packed format support for skl+ (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: Adding YUV444 packed format support for skl+ (rev2) URL : https://patchwork.freedesktop.org/series/73020/ State : success == Summary == CI Bug Log - changes from CI_DRM_7900 -> Patchwork_16502 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Chris Wilson
Quoting Chris Wilson (2020-02-10 16:42:15) > We manipulate ring->head while active in i915_request_retire underneath > the timeline manipulation. We cannot rely on a stable ring->head outside > of the timeline->mutex, in particular while setting up the context for > resume and reset. > > Closes: h

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/ehl: Update port clock voltage level requirements

2020-02-10 Thread Matt Roper
On Mon, Feb 10, 2020 at 04:05:34AM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915/ehl: Update port clock voltage > level requirements > URL : https://patchwork.freedesktop.org/series/73123/ > State : success > > == Summary == > > CI Bug Log - ch

[Intel-gfx] [PATCH] drm/i915/mst: Set intel_dp_set_m_n() for MST slaves

2020-02-10 Thread José Roberto de Souza
Commit 1c9d2eb24153 ("drm/i915: move intel_dp_set_m_n() to encoder for DDI platforms") moved the intel_dp_set_m_n() from hsw_crtc_enable() to intel_ddi_pre_enable_dp() but it missed add it to intel_mst_pre_enable_dp() causing MST slaves to not work. Fixes: 1c9d2eb24153 ("drm/i915: move intel_dp_se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex URL : https://patchwork.freedesktop.org/series/73248/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3838891e9c61 drm/i915/gt: Avoid resetting ring->head outside of its timeline m

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex URL : https://patchwork.freedesktop.org/series/73248/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16504

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 Comp fixes (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: HDCP 2.2 Comp fixes (rev2) URL : https://patchwork.freedesktop.org/series/73101/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16505 Summary --- **SUCCESS** No regres

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for In order to readout DP SDPs, refactors the handling of DP SDPs (rev6)

2020-02-10 Thread Patchwork
== Series Details == Series: In order to readout DP SDPs, refactors the handling of DP SDPs (rev6) URL : https://patchwork.freedesktop.org/series/72853/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b39096a6173 drm: Add DP1.4 VSC SDP Payload related Data Structures 7b89b55cb71

Re: [Intel-gfx] [PATCH] drm/i915: Skip CPU synchronisation on dmabuf attachments

2020-02-10 Thread Dongwon Kim
Acked-by: Dongwon Kim It makes lots of sense to make CPU cache operation done only when needed. Similar change was already landed in drm-prime and other vendor specific drivers. We are actually seeing huge performance boost in a specific customer case where dmabuf was used between camera driver (

Re: [Intel-gfx] [PATCH] drm/i915: Skip CPU synchronisation on dmabuf attachments

2020-02-10 Thread Dongwon Kim
(mistakenly put a wrong message id in "In-reply-To") Acked-by: Dongwon Kim It makes lots of sense to make CPU cache operation done only when needed. Similar change was already landed in drm-prime and other vendor specific drivers. We are actually seeing huge performance boost in a specific cust

Re: [Intel-gfx] [PATCH] drm/i915: Skip CPU synchronisation on dmabuf attachments

2020-02-10 Thread Dongwon Kim
The patch is here: https://lists.freedesktop.org/archives/intel-gfx/2017-November/148988.html On Mon, Feb 10, 2020 at 11:34:07AM -0800, Dongwon Kim wrote: > Acked-by: Dongwon Kim > > It makes lots of sense to make CPU cache operation done only when > needed. Similar change was already landed in

[Intel-gfx] ✓ Fi.CI.BAT: success for In order to readout DP SDPs, refactors the handling of DP SDPs (rev6)

2020-02-10 Thread Patchwork
== Series Details == Series: In order to readout DP SDPs, refactors the handling of DP SDPs (rev6) URL : https://patchwork.freedesktop.org/series/72853/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16506

[Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_22010178259:tgl

2020-02-10 Thread Matt Roper
We need to explicitly set the TLB Request Timer initial value in the BW_BUDDY registers to 0x8 rather than relying on the hardware default. Bspec: 52890 Bspec: 50044 Cc: Stanislav Lisovskiy Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/display/intel_display_power.c | 6 ++ drivers/gpu/

Re: [Intel-gfx] [PATCH] drm/i915/mst: Set intel_dp_set_m_n() for MST slaves

2020-02-10 Thread Jani Nikula
On Mon, 10 Feb 2020, José Roberto de Souza wrote: > Commit 1c9d2eb24153 ("drm/i915: move intel_dp_set_m_n() to encoder for > DDI platforms") moved the intel_dp_set_m_n() from hsw_crtc_enable() > to intel_ddi_pre_enable_dp() but it missed add it to > intel_mst_pre_enable_dp() causing MST slaves to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mst: Set intel_dp_set_m_n() for MST slaves

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/mst: Set intel_dp_set_m_n() for MST slaves URL : https://patchwork.freedesktop.org/series/73252/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16507 Summary ---

[Intel-gfx] [PATCH 5/7] drm/i915: Disable use of hwsp_cacheline for kernel_context

2020-02-10 Thread Chris Wilson
Currently on execlists, we use a local hwsp for the kernel_context, rather than the engine's HWSP, as this is the default for execlists. However, seqno rollover requires allocating a new HWSP cachline, and may require pinning a new HWSP page in the GTT. This operation requiring pinning in the GGTT

[Intel-gfx] [PATCH 7/7] drm/i915/execlists: Remove preempt-to-busy roundtrip delay

2020-02-10 Thread Chris Wilson
To prevent the context from proceeding past the end of the request as we unwind, we embed a semaphore into the footer of each request. (If the context were to skip past the end of the request as we perform the preemption, next time we reload the context it's RING_HEAD would be past the RING_TAIL an

[Intel-gfx] [PATCH 2/7] drm/i915/selftests: Exercise timeslice rewinding

2020-02-10 Thread Chris Wilson
Originally, I did not expect having to rewind a context upon timeslicing: the point was to replace the executing context with an idle one! However, given a second context that depends on requests from the first, we may have to split the requests along the first context to execute the second, causin

[Intel-gfx] [PATCH 6/7] drm/i915/gt: Yield the timeslice if caught waiting on a user semaphore

2020-02-10 Thread Chris Wilson
If we find ourselves waiting on a MI_SEMAPHORE_WAIT, either within the user batch or in our own preamble, the engine raises a GT_WAIT_ON_SEMAPHORE interrupt. We can unmask that interrupt and so respond to a semaphore wait by yielding the timeslice, if we have another context to yield to! The only

[Intel-gfx] [PATCH 4/7] drm/i915/gem: Don't leak non-persistent requests on changing engines

2020-02-10 Thread Chris Wilson
If we have a set of active engines marked as being non-persistent, we lose track of those if the user replaces those engines with I915_CONTEXT_PARAM_ENGINES. As part of our uABI contract is that non-persistent requests are terminated if they are no longer being tracked by the user's context (in ord

[Intel-gfx] [PATCH 3/7] drm/i915/selftests: Relax timeout for error-interrupt reset processing

2020-02-10 Thread Chris Wilson
We can not require that the system process a tasklet in reasonable time (thanks be to ksoftirqd), but we can insist that having waited sufficiently for the error interrupt to have been raised and having kicked the tasklet, the reset has begun and the request will be marked as in error (if not alrea

[Intel-gfx] [PATCH 1/7] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Chris Wilson
We manipulate ring->head while active in i915_request_retire underneath the timeline manipulation. We cannot rely on a stable ring->head outside of the timeline->mutex, in particular while setting up the context for resume and reset. Closes: https://gitlab.freedesktop.org/drm/intel/issues/1126 Fix

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Add Wa_22010178259:tgl

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Add Wa_22010178259:tgl URL : https://patchwork.freedesktop.org/series/73255/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16508 Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: Downgrade gen7 (ivb, byt, hsw) back to aliasing-ppgtt

2020-02-10 Thread Rodrigo Vivi
On Sat, Feb 08, 2020 at 10:01:06PM +, Chris Wilson wrote: > Full-ppgtt on gen7 is proving to be highly unstable and not robust. > > Fixes: 3cd6e8860ecd ("drm/i915/gen7: Re-enable full-ppgtt for ivb & hsw") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Jani Nik

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Program MBUS with rmw during initialization (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Program MBUS with rmw during initialization (rev2) URL : https://patchwork.freedesktop.org/series/72950/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16509 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex URL : https://patchwork.freedesktop.org/series/73256/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1f4fe3bfcb66 drm/i915/gt: Avoid resetting ring->hea

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size

2020-02-10 Thread Chris Wilson
Quoting Chris Wilson (2020-02-10 12:52:26) > Quoting Matthew Auld (2020-02-10 12:47:35) > > On Thu, 6 Feb 2020 at 14:10, Chris Wilson wrote: > > > > > > Reduce the amount of work we do to verify client blt correctness as > > > currently our 0.5s subtests takes about 15s on slower devices! > > > >

[Intel-gfx] [PATCH] drm/i915/selftests: Trim blitter block size

2020-02-10 Thread Chris Wilson
Reduce the amount of work we do to verify client blt correctness as currently our 0.5s subtests takes about 15s on slower devices! v2: Grow the maximum block size until we run out of time Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- .../i915/gem/selftests/i915_gem_object_blt.c |

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/7] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex

2020-02-10 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/gt: Avoid resetting ring->head outside of its timeline mutex URL : https://patchwork.freedesktop.org/series/73256/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16510 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mst: Set intel_dp_set_m_n() for MST slaves (rev2)

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/mst: Set intel_dp_set_m_n() for MST slaves (rev2) URL : https://patchwork.freedesktop.org/series/73252/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16511 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Trim blitter block size (rev5)

2020-02-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Trim blitter block size (rev5) URL : https://patchwork.freedesktop.org/series/73066/ State : success == Summary == CI Bug Log - changes from CI_DRM_7903 -> Patchwork_16512 Summary ---

[Intel-gfx] [PATCH i-g-t] i915/gem_exec_nop: Keep a copy of the names

2020-02-10 Thread Chris Wilson
The engine names are now stored inside the iterator and not as static strings. If we wish to use them later, we need to make a copy. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_exec_nop.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/i915

[Intel-gfx] [PATCH i-g-t 0/3] mmio_base via debugfs infrastructure + gem_ctx_isolation

2020-02-10 Thread Dale B Stimson
This patch series provides infrastructure to allow determination of i915 per-engine mmio_base (which is otherwise sometimes hard to get). The provided method uses debugfs mmio_base information if present. Otherwise, a default determination is provided when possible. Also, gem_ctx_isolation is mo

[Intel-gfx] [PATCH i-g-t 1/3] i915/gem_mmio_base.c - get mmio_base from debugfs (if possible)

2020-02-10 Thread Dale B Stimson
Signed-off-by: Dale B Stimson --- lib/Makefile.sources | 2 + lib/i915/gem_mmio_base.c | 346 +++ lib/i915/gem_mmio_base.h | 19 +++ lib/igt.h| 1 + lib/meson.build | 1 + 5 files changed, 369 insertions(+) create mode 10064

[Intel-gfx] [PATCH i-g-t 2/3] i915/gem_ctx_isolation: Check engine relative registers

2020-02-10 Thread Dale B Stimson
From: Chris Wilson Some of the non-privileged registers are at the same offset on each engine. We can improve our coverage for unknown HW layout by using the reported engine->mmio_base for relative offsets. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_isolation.c | 164 ++

  1   2   >