Looks good:
Reviewed-by: Christoph Hellwig
Looks good:
Reviewed-by: Christoph Hellwig
Reviewed-by: Nirmoy Das
On 7/5/2022 12:49 PM, Matthew Auld wrote:
This was broken by the kernel change: 71b1669ea9bd ("drm/i915/uapi:
tweak error capture on recoverable contexts"). Update the test to use
non-recoverable context if needed.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issu
> - vfio_unpin_pages(&q->matrix_mdev->vdev, &q->saved_pfn, 1);
> + vfio_unpin_pages(&q->matrix_mdev->vdev, q->saved_pfn <<
> PAGE_SHIFT, 1);
Overly long line here.
Otherwise looks good:
Reviewed-by: Christoph Hellwig
> +void vfio_unpin_pages(struct vfio_device *device, unsigned long *user_pfn,
> + int npage)
> {
> struct vfio_container *container;
> struct vfio_iommu_driver *driver;
> - int ret;
>
> - if (!user_pfn || !npage || !vfio_assert_device_open(device))
> -
On Thu, 2022-06-09 at 16:19 -0700, Ceraolo Spurio, Daniele wrote:
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> index 075ec97b459d..33bfac91fa01 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_huc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_huc.
Other than the one nit below, everything looks in order as per internal
development and reviews...
but really wish we had the nit added - so we have a single location we can
build on to get all
the various stages of gsc vs pxp vs huc operation sequences across hw gens (at
least the first
gen wh
On 6/15/2022 7:28 PM, Zhang, Carl wrote:
On From: Ye, Tony
Sent: Thursday, June 16, 2022 12:15 AM
On 6/15/2022 3:13 AM, Tvrtko Ursulin wrote:
On 15/06/2022 00:15, Ye, Tony wrote:
On 6/14/2022 8:30 AM, Ceraolo Spurio, Daniele wrote:
On 6/14/2022 12:44 AM, Tvrtko Ursulin wrote:
On 13/06/2
On 6/6/2022 17:23, Alan Previn wrote:
Both error-capture and relay-logging mechanism use the GuC
log infrastructure. That means the KMD must send a log flush
complete notification back to GuC after reading the data out.
This call is currently being sent synchronously.
However, synchronous H2Gs ca
LGTM.
Reviewed-by: Alan Previn
On Thu, 2022-06-09 at 16:19 -0700, Ceraolo Spurio, Daniele wrote:
> intel_huc_wait_for_auth_complete
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev3)
URL : https://patchwork.freedesktop.org/series/104704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwo
== Series Details ==
Series: Add support for LMEM PCIe resizable bar
URL : https://patchwork.freedesktop.org/series/105928/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_105928v1_full
Summary
---
They both are known issues. Re-reported.
-Original Message-
From: Roper, Matthew D
Sent: Friday, July 1, 2022 8:44 AM
To: intel-gfx@lists.freedesktop.org
Cc: Sousa, Gustavo ; Vudum, Lakshminarayana
Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pvc: Implement w/a
160166949
== Series Details ==
Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_105925v1_full
Summary
== Series Details ==
Series: drm/i915/pvc: Implement w/a 16016694945
URL : https://patchwork.freedesktop.org/series/105837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11835_full -> Patchwork_105837v1_full
Summary
---
== Series Details ==
Series: drm: Clean up drm_crtc.h (rev7)
URL : https://patchwork.freedesktop.org/series/105073/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/105073/revisions/7/mbox/ not
applied
Applying: drm/vmwgfx: Stop using 'TRUE'
error:
On Jun 30, 2022, at 3:51 PM, Ville Syrjala
mailto:ville.syrj...@linux.intel.com>> wrote:
From: Ville Syrjälä
mailto:ville.syrj...@linux.intel.com>>
Stop using the 'TRUE' define. This ultimately gets defined by
acpi/actypes.h that gets included here via a convoluted chain of
other headers. drm_
== Series Details ==
Series: drm/i915/pvc: Implement w/a 16016694945
URL : https://patchwork.freedesktop.org/series/105837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11835_full -> Patchwork_105837v1_full
Summary
---
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev3)
URL : https://patchwork.freedesktop.org/series/104704/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849 -> Patchwork_10
== Series Details ==
Series: Fixes integer overflow or integer truncation issues in page lookups,
ttm place configuration and scatterlist creation (rev3)
URL : https://patchwork.freedesktop.org/series/104704/
State : warning
== Summary ==
Error: dim checkpatch failed
a9f2e87eee8d drm: Move an
On Tue, 5 Jul 2022 15:24:55 +0300
Gwan-gyeong Mun wrote:
> From: Chris Wilson
>
> Having addressed the issues surrounding incorrect types for local
> variables and potential integer truncation in using the scatterlist API,
> we have closed all the loop holes we had previously identified with
>
On Tue, 5 Jul 2022 15:24:54 +0300
Gwan-gyeong Mun wrote:
> The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big
> to add vma. The direct function that returns -ENOSPC is
> drm_mm_insert_node_in_range().
> To handle the same error as other code returning -E2BIG when the si
On Tue, 5 Jul 2022 15:24:53 +0300
Gwan-gyeong Mun wrote:
> The __shmem_file_setup() function returns -EINVAL if size is greater than
> MAX_LFS_FILESIZE. To handle the same error as other code that returns
> -E2BIG when the size is too large, it add a code that returns -E2BIG when
> the size is l
On Tue, 5 Jul 2022 15:24:51 +0300
Gwan-gyeong Mun wrote:
> From: Chris Wilson
>
> There is an impedance mismatch between the scatterlist API using unsigned
> int and our memory/page accounting in unsigned long. That is we may try
> to create a scatterlist for a large object that overflows retu
On Tue, 5 Jul 2022 15:24:52 +0300
Gwan-gyeong Mun wrote:
> There is an impedance mismatch between the first/last valid page
> frame number of ttm place in unsigned and our memory/page accounting in
> unsigned long.
> As the object size is under the control of userspace, we have to be prudent
> a
== Series Details ==
Series: Add support for LMEM PCIe resizable bar
URL : https://patchwork.freedesktop.org/series/105928/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849 -> Patchwork_105928v1
Summary
---
**SUCC
On Tue, 5 Jul 2022 15:24:50 +0300
Gwan-gyeong Mun wrote:
> From: Chris Wilson
>
> We need to check that we avoid integer overflows when looking up a page,
> and so fix all the instances where we have mistakenly used a plain
> integer instead of a more suitable long. Be pedantic and add integer
On Tue, 5 Jul 2022 15:24:49 +0300
Gwan-gyeong Mun wrote:
> It moves overflows_type utility macro into drm util header from i915_utils
> header. The overflows_type can be used to catch the truncation between data
> types. And it adds safe_conversion() macro which performs a type conversion
> (cas
== Series Details ==
Series: Add support for LMEM PCIe resizable bar
URL : https://patchwork.freedesktop.org/series/105928/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849 -> Patchwork_105925v1
Summary
---
== Series Details ==
Series: drm/i915: Apply waitboosting before fence wait
URL : https://patchwork.freedesktop.org/series/105925/
State : warning
== Summary ==
Error: dim checkpatch failed
3102ce715842 drm/i915/gem: Look for waitboosting across the whole object prior
to individual waits
bc7a
Thanks,
Oak
> -Original Message-
> From: C, Ramalingam
> Sent: July 5, 2022 5:20 AM
> To: Zeng, Oak
> Cc: Vishwanathapura, Niranjana ;
> intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Vetter,
> Daniel ; christian.koe...@amd.com; Hellstrom,
> Thomas ; Zanoni, Paulo R
== Series Details ==
Series: Remove the VFIO_IOMMU_NOTIFY_DMA_UNMAP notifier (rev3)
URL : https://patchwork.freedesktop.org/series/104793/
State : failure
== Summary ==
Error: patch
https://patchwork.freedesktop.org/api/1.0/series/104793/revisions/3/mbox/ not
applied
Applying: vfio: Replace
From: Chris Wilson
Having addressed the issues surrounding incorrect types for local
variables and potential integer truncation in using the scatterlist API,
we have closed all the loop holes we had previously identified with
dangerously large object creation. As such, we can eliminate the warnin
The ttm_bo_init_reserved() functions returns -ENOSPC if the size is too big
to add vma. The direct function that returns -ENOSPC is
drm_mm_insert_node_in_range().
To handle the same error as other code returning -E2BIG when the size is
too large, it converts return value to -E2BIG.
Signed-off-by:
The __shmem_file_setup() function returns -EINVAL if size is greater than
MAX_LFS_FILESIZE. To handle the same error as other code that returns
-E2BIG when the size is too large, it add a code that returns -E2BIG when
the size is larger than the size that can be handled.
Signed-off-by: Gwan-gyeong
There is an impedance mismatch between the first/last valid page
frame number of ttm place in unsigned and our memory/page accounting in
unsigned long.
As the object size is under the control of userspace, we have to be prudent
and catch the conversion errors.
To catch the implicit truncation as we
From: Chris Wilson
There is an impedance mismatch between the scatterlist API using unsigned
int and our memory/page accounting in unsigned long. That is we may try
to create a scatterlist for a large object that overflows returning a
small table into which we try to fit very many pages. As the o
From: Chris Wilson
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain
integer instead of a more suitable long. Be pedantic and add integer
typechecking to the lookup so that we can be sure that we are safe.
A
It moves overflows_type utility macro into drm util header from i915_utils
header. The overflows_type can be used to catch the truncation between data
types. And it adds safe_conversion() macro which performs a type conversion
(cast) of an source value into a new variable, checking that the
destina
This patch series fixes integer overflow or integer truncation issues in
page lookups, ttm place configuration and scatterlist creation, etc.
We need to check that we avoid integer overflows when looking up a page,
and so fix all the instances where we have mistakenly used a plain integer
instead o
From: Priyanka Dandamudi
For testing purposes, support forcing the lmem_bar_size through a new
modparam. In CI we only have a limited number of configurations for DG2,
but we still need to be reasonably sure we get a usable device (also
verifying we report the correct values for things like
probe
From: Akeem G Abodunrin
Add support for the local memory PICe resizable bar, so that
local memory can be resized to the maximum size supported by the device,
and mapped correctly to the PCIe memory bar. It is usual that GPU
devices expose only 256MB BARs primarily to be compatible with 32-bit
sys
From: Priyanka Dandamudi
Added support to resize the bar to maximum supported.
Also, added new modparam lmem_bar_size which can resize the bar to one of the
supported sizes.
Akeem G Abodunrin (1):
drm/i915: Add support for LMEM PCIe resizable bar
Priyanka Dandamudi (1):
drm/i915: Add lmem_
Make sure we always print the seed. Also make sure we use the correct
helpers for the igt_assert when comparing values of type uint64.
Signed-off-by: Matthew Auld
Cc: Nirmoy Das
---
tests/i915/i915_query.c | 36 +++-
1 file changed, 19 insertions(+), 17 deletions
Waitboost is a heuristic that detects latency sensitive workloads waiting for
the results from previous execution. The wait can be seen as GPU
under-utilisation by RPS, Render Power State management, which might lower the
GPU frequency to save power. Limiting the frequency means more waiting for
re
On 6/28/2022 4:34 PM, Arun R Murthy wrote:
In oder to trigger the async flip, a dummy flip is required after sync
flip so as to update the watermarks for async in KMD which happens as
part of this dummy flip. Thereafter async memory update will act as a
trigger register.
Capturing the CRC is done
Hi,
On 5.7.2022 12.49, Karthik B S wrote:
On 7/5/2022 3:08 PM, Murthy, Arun R wrote:
On 6/28/2022 4:34 PM, Arun R Murthy wrote:
In oder to trigger the async flip, a dummy flip is required after sync
flip so as to update the watermarks for async in KMD which happens as
part of this dummy flip.
> On 5.7.2022 12.49, Karthik B S wrote:
> > On 7/5/2022 3:08 PM, Murthy, Arun R wrote:
> >>> On 6/28/2022 4:34 PM, Arun R Murthy wrote:
> In oder to trigger the async flip, a dummy flip is required after
> sync flip so as to update the watermarks for async in KMD which
> happens as p
This was broken by the kernel change: 71b1669ea9bd ("drm/i915/uapi:
tweak error capture on recoverable contexts"). Update the test to use
non-recoverable context if needed.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/6350
Signed-off-by: Matthew Auld
Cc: Nirmoy Das
---
tests/i915/g
From: Chris Wilson
We employ a "waitboost" heuristic to detect when userspace is stalled
waiting for results from earlier execution. Under latency sensitive work
mixed between the gpu/cpu, the GPU is typically under-utilised and so
RPS sees that low utilisation as a reason to downclock the freque
On 7/5/2022 3:08 PM, Murthy, Arun R wrote:
On 6/28/2022 4:34 PM, Arun R Murthy wrote:
In oder to trigger the async flip, a dummy flip is required after sync
flip so as to update the watermarks for async in KMD which happens as
part of this dummy flip. Thereafter async memory update will act as a
> On 7/5/2022 3:08 PM, Murthy, Arun R wrote:
> >> On 6/28/2022 4:34 PM, Arun R Murthy wrote:
> >>> In oder to trigger the async flip, a dummy flip is required after
> >>> sync flip so as to update the watermarks for async in KMD which
> >>> happens as part of this dummy flip. Thereafter async memor
From: Chris Wilson
One impact of commit 047a1b877ed4 ("dma-buf & drm/amdgpu: remove
dma_resv workaround") is that it stores many, many more fences. Whereas
adding an exclusive fence used to remove the shared fence list, that
list is now preserved and the write fences included into the list. Not
j
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> VM_BIND functionality maintain that vm->vm_bind_mutex will never be
> taken
> while holding vm->mutex.
> However, while closing 'vm', vma is destroyed while holding vm-
> >mutex.
> But vma releasing needs to take vm->vm_bind_mute
On 2022-07-04 at 17:05:38 +, Zeng, Oak wrote:
>
>
> Thanks,
> Oak
>
> > -Original Message-
> > From: Intel-gfx On Behalf Of
> > Niranjana Vishwanathapura
> > Sent: July 1, 2022 6:51 PM
> > To: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org
> > Cc: Zanoni, Paulo R ;
On 2022.07.04 21:59:03 -0300, Jason Gunthorpe wrote:
> Instead of having drivers register the notifier with explicit code just
> have them provide a dma_unmap callback op in their driver ops and rely on
> the core code to wire it up.
>
> Suggested-by: Christoph Hellwig
> Reviewed-by: Christoph He
From: Chris Wilson
In monitoring a transcode pipeline that is latency sensitive (it waits
between submitting frames, and each frame requires work on rcs/vcs/vecs
engines), it is found that it took longer than a single jiffy for it to
sustain its workload. Allowing an extra jiffy headroom for the
== Series Details ==
Series: drm/i915/pvc: Implement w/a 16016694945
URL : https://patchwork.freedesktop.org/series/105837/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11835_full -> Patchwork_105837v1_full
Summary
---
> On 6/28/2022 4:34 PM, Arun R Murthy wrote:
> > In oder to trigger the async flip, a dummy flip is required after sync
> > flip so as to update the watermarks for async in KMD which happens as
> > part of this dummy flip. Thereafter async memory update will act as a
> > trigger register.
> > Captu
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> vma_lookup is tied to segment of the object instead of section
> of VA space. Hence, it do not support aliasing (ie., multiple
> bindings to the same section of the object).
> Skip vma_lookup for persistent vmas as it supports al
Hi,
On Fri, 2022-07-01 at 15:50 -0700, Niranjana Vishwanathapura wrote:
> Add VM_BIND and VM_UNBIND ioctls to bind/unbind a section of an
> object at the specified GPU virtual addresses.
>
> Add I915_PARAM_VM_BIND_VERSION to indicate version of VM_BIND feature
> supported and I915_VM_CREATE_FLAG
== Series Details ==
Series: Protect vma destruction with the object lock
URL : https://patchwork.freedesktop.org/series/105902/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_105902v1_full
Summary
--
== Series Details ==
Series: drm/i915/dp: wait on timeout before retry (rev4)
URL : https://patchwork.freedesktop.org/series/105660/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11848_full -> Patchwork_105660v4_full
Summar
== Series Details ==
Series: Fix TLB invalidate issues with Broadwell (rev3)
URL : https://patchwork.freedesktop.org/series/105167/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_105167v3_full
Summary
Hi,
On 5.7.2022 13.28, Murthy, Arun R wrote:
On 5.7.2022 12.49, Karthik B S wrote:
On 7/5/2022 3:08 PM, Murthy, Arun R wrote:
On 6/28/2022 4:34 PM, Arun R Murthy wrote:
In oder to trigger the async flip, a dummy flip is required after
sync flip so as to update the watermarks for async in KMD
== Series Details ==
Series: drm/i915: Support Async Flip on Linear buffers (rev3)
URL : https://patchwork.freedesktop.org/series/103137/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11849_full -> Patchwork_103137v3_full
S
== Series Details ==
Series: drm/i915/pvc: Implement w/a 16016694945
URL : https://patchwork.freedesktop.org/series/105837/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11835_full -> Patchwork_105837v1_full
Summary
---
> -Original Message-
> From: Intel-gfx On Behalf Of
> Stanislav
> Lisovskiy
> Sent: Tuesday, June 14, 2022 6:01 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 1/1] drm/i915/dg2: Bump up CDCLK for DG2
>
> We seem to need this W/A same way as for TGL, in order to
69 matches
Mail list logo
