Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 14:43, Dmitry Baryshkov escreveu: On Tue, Jun 18, 2024 at 01:18:10PM GMT, André Almeida wrote: Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities

Re: [PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-18 Thread André Almeida
Em 18/06/2024 07:07, Dmitry Baryshkov escreveu: On Tue, 18 Jun 2024 at 12:38, Jani Nikula wrote: On Tue, 18 Jun 2024, André Almeida wrote: Drivers have different capabilities on what plane types they can or cannot perform async flips. Create a plane::async_flip field so each driver can

[PATCH v7 9/9] drm/amdgpu: Make it possible to async flip overlay planes

2024-06-17 Thread André Almeida
amdgpu can handle async flips on overlay planes, so mark it as true during the plane initialization. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH v7 8/9] drm: Enable per-plane async flip check

2024-06-17 Thread André Almeida
Replace the generic "is this plane primary" for a plane::async_flip check, so DRM follows the plane restrictions set by the driver. Signed-off-by: André Almeida --- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH v7 7/9] drm/vc4: Enable async flips on the primary plane

2024-06-17 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/vc4/vc4_plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 07caf2a47c6c

[PATCH v7 6/9] drm/nouveau: Enable async flips on the primary plane

2024-06-17 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 drivers/gpu/drm/nouveau/dispnv50/wndw.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b

[PATCH v7 5/9] drm/i915: Enable async flips on the primary plane

2024-06-17 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++ drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display

[PATCH v7 4/9] drm: atmel-hlcdc: Enable async flips on the primary plane

2024-06-17 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc

[PATCH v7 3/9] drm/amdgpu: Enable async flips on the primary plane

2024-06-17 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display

[PATCH v7 2/9] drm: Support per-plane async flip configuration

2024-06-17 Thread André Almeida
Drivers have different capabilities on what plane types they can or cannot perform async flips. Create a plane::async_flip field so each driver can choose which planes they allow doing async flips. Signed-off-by: André Almeida --- include/drm/drm_plane.h | 5 + 1 file changed, 5 insertions

[PATCH v7 1/9] drm/atomic: Allow userspace to use explicit sync with atomic async flips

2024-06-17 Thread André Almeida
Allow userspace to use explicit synchronization with atomic async flips. That means that the flip will wait for some hardware fence, and then will flip as soon as possible (async) in regard of the vblank. Signed-off-by: André Almeida --- drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1 file

[PATCH v7 0/9] drm: Support per-plane async flip configuration

2024-06-17 Thread André Almeida
driver https://lore.kernel.org/dri-devel/20240612193713.167448-1-andrealm...@igalia.com/ André Almeida (9): drm/atomic: Allow userspace to use explicit sync with atomic async flips drm: Support per-plane async flip configuration drm/amdgpu: Enable async flips on the primary plane drm: atmel

Re: [PATCH v6 2/8] drm: Support per-plane async flip configuration

2024-06-14 Thread André Almeida
Em 14/06/2024 14:32, Dmitry Baryshkov escreveu:> On Fri, Jun 14, 2024 at 12:35:29PM GMT, André Almeida wrote: >> Drivers have different capabilities on what plane types they can or >> cannot perform async flips. Create a plane::async_flip field so each >> driver ca

Re: [PATCH v6 0/8] drm: Support per-plane async flip configuration

2024-06-14 Thread André Almeida
Hi Dmitry, Em 14/06/2024 14:32, Dmitry Baryshkov escreveu: On Fri, Jun 14, 2024 at 12:35:27PM GMT, André Almeida wrote: AMD hardware can do async flips with overlay planes, but currently there's no easy way to enable that in DRM. To solve that, this patchset creates a new drm_plane field, bool

[PATCH v6 8/8] drm/amdgpu: Make it possible to async flip overlay planes

2024-06-14 Thread André Almeida
amdgpu can handle async flips on overlay planes, so mark it as true during the plane initialization. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm

[PATCH v6 1/8] drm/atomic: Allow userspace to use explicit sync with atomic async flips

2024-06-14 Thread André Almeida
Allow userspace to use explicit synchronization with atomic async flips. That means that the flip will wait for some hardware fence, and then will flip as soon as possible (async) in regard of the vblank. Signed-off-by: André Almeida --- drivers/gpu/drm/drm_atomic_uapi.c | 4 +++- 1 file

[PATCH v6 7/8] drm/vc4: Enable async flips on the primary plane

2024-06-14 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/vc4/vc4_plane.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c index 07caf2a47c6c

[PATCH v6 6/8] drm/nouveau: Enable async flips on the primary plane

2024-06-14 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 drivers/gpu/drm/nouveau/dispnv50/wndw.c | 4 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c b

[PATCH v6 5/8] drm/i915: Enable async flips on the primary plane

2024-06-14 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/i915/display/i9xx_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c index

[PATCH v6 4/8] drm: atmel-hlcdc: Enable async flips on the primary plane

2024-06-14 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc

[PATCH v6 3/8] drm/amdgpu: Enable async flips on the primary plane

2024-06-14 Thread André Almeida
This driver can perfom async flips on primary planes, so enable it. Signed-off-by: André Almeida --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display

[PATCH v6 0/8] drm: Support per-plane async flip configuration

2024-06-14 Thread André Almeida
8-1-andrealm...@igalia.com/ André Almeida (8): drm/atomic: Allow userspace to use explicit sync with atomic async flips drm: Support per-plane async flip configuration drm/amdgpu: Enable async flips on the primary plane drm: atmel-hlcdc: Enable async flips on the primary plane drm/i

[PATCH v6 2/8] drm: Support per-plane async flip configuration

2024-06-14 Thread André Almeida
Drivers have different capabilities on what plane types they can or cannot perform async flips. Create a plane::async_flip field so each driver can choose which planes they allow doing async flips. Signed-off-by: André Almeida --- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- include/drm

Re: [Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-23 Thread André Almeida
Em 23/11/2023 13:24, Simon Ser escreveu: Thanks! This iteration of the first 3 patches LGTM, I've pushed them to drm-misc-next. I've made two adjustments to make checkpatch.pl happy: Thank you! - s/uint64_t/u64/ - Fix indentation for a drm_dbg_atomic() ops :)

Re: [Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-22 Thread André Almeida
Hi Hamza, Em 22/11/2023 17:23, Hamza Mahfooz escreveu: Hi André, On 11/22/23 11:19, André Almeida wrote: Hi, This work from me and Simon adds support for DRM_MODE_PAGE_FLIP_ASYNC through the atomic API. This feature is already available via the legacy API. The use case is to be able

[Intel-gfx] [PATCH v9 4/4] drm/doc: Define KMS atomic state set

2023-11-22 Thread André Almeida
From: Pekka Paalanen Specify how the atomic state is maintained between userspace and kernel, plus the special case for async flips. Signed-off-by: Pekka Paalanen Signed-off-by: André Almeida --- v9: - no changes v8: - no changes v7: - add a note that drivers can make exceptions for ad-hoc

[Intel-gfx] [PATCH v9 3/4] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP

2023-11-22 Thread André Almeida
-by: Simon Ser Reviewed-by: André Almeida Reviewed-by: Alex Deucher Signed-off-by: André Almeida --- v9: no changes --- --- drivers/gpu/drm/drm_ioctl.c | 4 include/uapi/drm/drm.h | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c

[Intel-gfx] [PATCH v9 2/4] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits

2023-11-22 Thread André Almeida
to something else. For instance, Xorg falls back to a blit. Another option is to wait as close to the next vblank as possible before performing the page-flip to reduce latency. Signed-off-by: Simon Ser Reviewed-by: Alex Deucher Co-developed-by: André Almeida Signed-off-by: André Almeida --- v9

[Intel-gfx] [PATCH v9 1/4] drm: Refuse to async flip with atomic prop changes

2023-11-22 Thread André Almeida
Given that prop changes may lead to modesetting, which would defeat the fast path of the async flip, refuse any atomic prop change for async flips in atomic API. The only exception is the framebuffer ID to flip to. Currently the only plane type supported is the primary one. Signed-off-by: André

[Intel-gfx] [PATCH v9 0/4] drm: Add support for atomic async page-flip

2023-11-22 Thread André Almeida
the KMS atomic state set v3: https://lore.kernel.org/dri-devel/20220929184307.258331-1-cont...@emersion.fr/ André Almeida (1): drm: Refuse to async flip with atomic prop changes Pekka Paalanen (1): drm/doc: Define KMS atomic state set Simon Ser (2): drm: allow DRM_MODE_PAGE_FLIP_ASYNC

Re: [Intel-gfx] [PATCH v2 2/2] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-10-01 Thread André Almeida
,height} and fb_plane_{width,height} call to drm_format_info_plane_{width,height} and remove them. Signed-off-by: Carlos Eduardo Gallo Filho Reviewed-by: André Almeida

Re: [Intel-gfx] [PATCH v2 1/2] drm: Remove plane hsub/vsub alignment requirement for core helpers

2023-10-01 Thread André Almeida
than that, Reviewed-by: André Almeida Signed-off-by: Carlos Eduardo Gallo Filho --- include/drm/drm_fourcc.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 532ae78ca747..ccf91daa4307 100644 --- a/include/drm

Re: [Intel-gfx] [PATCH] drm: Replace drm_framebuffer plane size functions with its equivalents

2023-07-12 Thread André Almeida
Hi Carlos, Em 27/06/2023 15:22, Carlos Eduardo Gallo Filho escreveu: [...] So, replace each drm_framebuffer_plane_{width,height} and fb_plane_{width,height} call to drm_format_info_plane_{width,height} and remove them. I see that with this replace, there's a small code change from

Re: [Intel-gfx] [PATCH v2] drm/ttm: Fix dummy res NULL ptr deref bug

2022-07-27 Thread André Almeida
Hi Arunpravin, Às 02:30 de 27/07/22, Arunpravin Paneer Selvam escreveu: > Check the bo->resource value before accessing the resource > mem_type. > > v2: Fix commit description unwrapped warning > > > [ 40.191227][ T184] general protection fault, probably for non-canonical > address

Re: [Intel-gfx] Enabling sample_c optimization for Broadwell GPUs

2021-05-06 Thread André Almeida
g this bit to be set. So, I would not recommend to use it in any product, even downstream. Regardless the state of sample c message optimization in later platforms. Thanks, Rodrigo. On Tue, May 04, 2021 at 08:07:14PM -0300, André Almeida wrote: Hi there, While browsing an old downstream kernel, I fou