Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-25 Thread David Weinehall
On Wed, Jun 24, 2015 at 10:17:34AM +0530, Jindal, Sonika wrote: > > > On 6/23/2015 4:42 PM, David Weinehall wrote: > >On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: > >>On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > >>>@@ -3520,6 +3545,9 @@ intel_dp_set_signal_

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-25 Thread David Weinehall
On Thu, Jun 18, 2015 at 11:10:13AM +0100, Chris Wilson wrote: > These are static routing, but called fairly often. (Often enough that > you care to only read the register once.) Any reason not to preserve > these routing tables in dev_priv or, slightly more preferrable, intel_dp? Looking over this

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-23 Thread Jindal, Sonika
On 6/23/2015 4:42 PM, David Weinehall wrote: On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, uint32_t *DP) } else if (HAS_DDI(de

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-23 Thread Daniel Vetter
On Tue, Jun 23, 2015 at 02:12:41PM +0300, David Weinehall wrote: > On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: > > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp > > > *intel_dp, uint32_t *D

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-23 Thread David Weinehall
On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, > > uint32_t *DP) > > } else if (HAS_DDI(dev)) { > > signal_levels = hsw

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-23 Thread David Weinehall
On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote: > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, > > uint32_t *DP) > > } else if (HAS_DDI(dev)) { > > signal_levels = hsw

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-23 Thread David Weinehall
On Thu, Jun 18, 2015 at 11:59:34AM +0100, Chris Wilson wrote: > On Thu, Jun 18, 2015 at 01:47:30PM +0300, David Weinehall wrote: > > On Thu, Jun 18, 2015 at 11:10:13AM +0100, Chris Wilson wrote: > > > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > > > +static const struct ddi_

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-18 Thread Daniel Vetter
On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, > uint32_t *DP) > } else if (HAS_DDI(dev)) { > signal_levels = hsw_signal_levels(train_set); > mask = DDI_BUF_EMP_MASK; >

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-18 Thread Chris Wilson
On Thu, Jun 18, 2015 at 01:47:30PM +0300, David Weinehall wrote: > On Thu, Jun 18, 2015 at 11:10:13AM +0100, Chris Wilson wrote: > > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > > +static const struct ddi_buf_trans *skl_get_buf_trans_dp(struct > > > drm_device *dev, > > >

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-18 Thread David Weinehall
On Thu, Jun 18, 2015 at 11:10:13AM +0100, Chris Wilson wrote: > On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > > +static const struct ddi_buf_trans *skl_get_buf_trans_dp(struct drm_device > > *dev, > > struct drm_i915_private not struct drm_device! The device uses both dev an

Re: [Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-18 Thread Chris Wilson
On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote: > +static const struct ddi_buf_trans *skl_get_buf_trans_dp(struct drm_device > *dev, struct drm_i915_private not struct drm_device! > + int *n_entries) > +{ > + struct drm_i91

[Intel-gfx] [PATCH] drm/i915/skl: Buffer translation improvements

2015-06-18 Thread David Weinehall
This patch adds support for 0.85V VccIO on Skylake Y, separate buffer translation tables for Skylake U, and support for I_boost for the entries that needs this. Issue: VIZ-5677 Signed-off-by: David Weinehall --- drivers/gpu/drm/i915/i915_drv.h | 8 + drivers/gpu/drm/i915/i915_reg.h | 12 ++