Re: [Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-17 Thread Daniel Vetter
On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds torva...@linux-foundation.org wrote: Sorry for the top post, I'm on the road.. In wondering if we couldn't just keep both the old an the new names and have them both point at the same variable? Remove the description for the old name, but keep

Re: [Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-17 Thread Amit Shah
On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds torva...@linux-foundation.org wrote: Sorry for the top post, I'm on the road.. In wondering if we couldn't just keep both the old an the new names and have them both point at the same

Re: [Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-17 Thread Daniel Vetter
On Thu, Jul 17, 2014 at 02:32:41PM +0530, Amit Shah wrote: On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds torva...@linux-foundation.org wrote: Sorry for the top post, I'm on the road.. In wondering if we couldn't just keep both

Re: [Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-17 Thread Amit Shah
On (Thu) 17 Jul 2014 [11:11:15], Daniel Vetter wrote: On Thu, Jul 17, 2014 at 02:32:41PM +0530, Amit Shah wrote: On (Thu) 17 Jul 2014 [09:35:20], Daniel Vetter wrote: On Wed, Jul 16, 2014 at 9:54 PM, Linus Torvalds torva...@linux-foundation.org wrote: Sorry for the top post, I'm on

[Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-16 Thread Amit Shah
This reverts commit 3adee7a7976012a20f1d3b5a529a3c105e29fef1. After upgrading to v3.15, my laptop's battery started draining quite fast. Powertop pointed to the deep RC6 states not being used. The kernel param I had put to enable them had stopped working the way it used to; so I disagree with

Re: [Intel-gfx] [PATCH 1/1] Revert drm/i915: drop i915_ prefix from enable_rc6, enable_fbc, enable_ppgtt parameters

2014-07-16 Thread Linus Torvalds
Sorry for the top post, I'm on the road.. In wondering if we couldn't just keep both the old an the new names and have them both point at the same variable? Remove the description for the old name, but keep it working? Linus On Jul 16, 2014 8:34 AM, Amit Shah amit.s...@redhat.com wrote: