Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-04 Thread Imre Deak
On Sat, 2016-11-05 at 00:32 +0200, Imre Deak wrote: > On Fri, 2016-11-04 at 21:01 +, Chris Wilson wrote: > > On Fri, Nov 04, 2016 at 10:33:24PM +0200, Imre Deak wrote: > > > On Thu, 2016-11-03 at 21:14 +, Chris Wilson wrote: > > > > Where is that guaranteed? I thought we only serialised

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-04 Thread Imre Deak
On Fri, 2016-11-04 at 21:01 +, Chris Wilson wrote: > On Fri, Nov 04, 2016 at 10:33:24PM +0200, Imre Deak wrote: > > On Thu, 2016-11-03 at 21:14 +, Chris Wilson wrote: > > > Where is that guaranteed? I thought we only serialised with the > > > pm > > > interrupts. Remember this happens

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-04 Thread Chris Wilson
On Fri, Nov 04, 2016 at 10:33:24PM +0200, Imre Deak wrote: > On Thu, 2016-11-03 at 21:14 +, Chris Wilson wrote: > > Where is that guaranteed? I thought we only serialised with the pm > > interrupts. Remember this happens before rpm suspend, since > > gem_idle_work_handler is responsible for

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-04 Thread Imre Deak
On Thu, 2016-11-03 at 21:14 +, Chris Wilson wrote: > On Thu, Nov 03, 2016 at 10:57:23PM +0200, Imre Deak wrote: > > On Thu, 2016-11-03 at 18:59 +, Chris Wilson wrote: > > > On Thu, Nov 03, 2016 at 06:19:37PM +0200, Imre Deak wrote: > > > > We assume that the GPU is idle once receiving the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-03 Thread Chris Wilson
On Thu, Nov 03, 2016 at 10:57:23PM +0200, Imre Deak wrote: > On Thu, 2016-11-03 at 18:59 +, Chris Wilson wrote: > > On Thu, Nov 03, 2016 at 06:19:37PM +0200, Imre Deak wrote: > > > We assume that the GPU is idle once receiving the seqno via the last > > > request's user interrupt. In execlist

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-03 Thread Imre Deak
On Thu, 2016-11-03 at 18:59 +, Chris Wilson wrote: > On Thu, Nov 03, 2016 at 06:19:37PM +0200, Imre Deak wrote: > > We assume that the GPU is idle once receiving the seqno via the last > > request's user interrupt. In execlist mode the corresponding context > > completed interrupt can be

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-03 Thread Chris Wilson
On Thu, Nov 03, 2016 at 06:19:37PM +0200, Imre Deak wrote: > We assume that the GPU is idle once receiving the seqno via the last > request's user interrupt. In execlist mode the corresponding context > completed interrupt can be delayed though and until this latter > interrupt arrives we consider

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-03 Thread Tvrtko Ursulin
On 03/11/2016 16:19, Imre Deak wrote: We assume that the GPU is idle once receiving the seqno via the last request's user interrupt. In execlist mode the corresponding context completed interrupt can be delayed though and until this latter interrupt arrives we consider the request to be pending

[Intel-gfx] [PATCH 1/2] drm/i915: Make sure engines are idle during GPU idling in LR mode

2016-11-03 Thread Imre Deak
We assume that the GPU is idle once receiving the seqno via the last request's user interrupt. In execlist mode the corresponding context completed interrupt can be delayed though and until this latter interrupt arrives we consider the request to be pending on the ELSP submit port. This can cause