[PHP-DEV] re2c --no-generation-date

2012-12-04 Thread Sebastian Bergmann
Any objections to applying the attached patch? This would suppress date output in the generated output so that (hopefully) files generated by re2c are not changed during the build just because of the date. >From 21f8149129609594a01bb08c77088effbe422aa7 Mon Sep 17 00:00:00 2001 From: Sebastian Be

Re: [PHP-DEV] re2c --no-generation-date

2012-12-04 Thread Stas Malyshev
Hi! > Any objections to applying the attached patch? This would suppress date > output in the generated output so that (hopefully) files generated by > re2c are not changed during the build just because of the date. I think it is a great idea. If we ever need a date for checked in files, we ha

Re: [PHP-DEV] re2c --no-generation-date

2012-12-04 Thread Sebastian Bergmann
On 12/05/2012 06:06 AM, Stas Malyshev wrote: >> Any objections to applying the attached patch? This would suppress date >> output in the generated output so that (hopefully) files generated by >> re2c are not changed during the build just because of the date. > > I think it is a great idea. If

Re: [PHP-DEV] re2c --no-generation-date

2012-12-05 Thread Stas Malyshev
Hi! > Okay. But does the patch look okay? Is it sufficient? How can I force a > rebuild of all files generated through re2c to remove the date from the > files? To which branches should the patch be applied? Thanks! I think 5.5, since we're not touching 5.4 that much anymore, especially not in

Re: [PHP-DEV] re2c --no-generation-date

2012-12-06 Thread Sebastian Bergmann
Am 06.12.2012 08:58, schrieb Stas Malyshev: > I think 5.5, since we're not touching 5.4 that much anymore, especially > not in the parser department. I committed the patch to PHP-5.5 and merged it to master from there. -- Sebastian BergmannCo-Founder and Principal Consultant