[GitHub] [commons-collections] Claudenw commented on issue #83: WIP: Initial bloom filter code contribution

Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-531325622 Thank you for the guidance. I am traveling for the next few days but will clean up and correct code ASAP Claude

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312183=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312183 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes

garydgregory commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457#issuecomment-531318800 Let me take a closer look this weekend. In the meantime, I would also like to work on a patch that defines as

[jira] [Updated] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas BARTHE-DEJEAN updated LANG-1490: Description: Currently, a DiffResult and a Diff can only handle the differences of

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312132=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312132 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[GitHub] [commons-lang] nicolasbd edited a comment on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes

nicolasbd edited a comment on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457#issuecomment-531279488 @garydgregory ok I'll add it, but what do you think about the idea itself ? I'll add proper headers

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312126=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312126 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312127=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312127 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[GitHub] [commons-lang] nicolasbd commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes

nicolasbd commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457#issuecomment-531279488 @garydgregory ok, but what do you think about the idea itself ? I'll add proper headers and tests once we

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312125=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312125 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[GitHub] [commons-lang] garydgregory edited a comment on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes

garydgregory edited a comment on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457#issuecomment-531278986 Hi @nicolasbd , Both files are missing the Apache license header causing CI build failures:

[GitHub] [commons-lang] garydgregory commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes

garydgregory commented on issue #457: WIP [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457#issuecomment-531278986 Hi @nicolasbd , Both files are missing the Apache license header. Gary

[jira] [Updated] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas BARTHE-DEJEAN updated LANG-1490: Description: Currently, a DiffResult and a Diff can only handle the differences of

[jira] [Work logged] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

[ https://issues.apache.org/jira/browse/LANG-1490?focusedWorklogId=312108=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-312108 ] ASF GitHub Bot logged work on LANG-1490: Author: ASF GitHub Bot

[GitHub] [commons-lang] nicolasbd opened a new pull request #457: [LANG-1490] - Creates DiffResultView and DiffView classes

nicolasbd opened a new pull request #457: [LANG-1490] - Creates DiffResultView and DiffView classes URL: https://github.com/apache/commons-lang/pull/457 Currently, a DiffResult and a Diff can only handle the differences of two objects of the same type A, and we cannot set custom

[jira] [Created] (LANG-1490) Create a more generic/string representation of a DiffResult and a Diff

Nicolas BARTHE-DEJEAN created LANG-1490: --- Summary: Create a more generic/string representation of a DiffResult and a Diff Key: LANG-1490 URL: https://issues.apache.org/jira/browse/LANG-1490

[jira] [Comment Edited] (JEXL-314) Comparison NULL values of variables NAME1.NAME2

[ https://issues.apache.org/jira/browse/JEXL-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929252#comment-16929252 ] Osy edited comment on JEXL-314 at 9/13/19 2:39 PM: --- I have an error trying to set engine

[jira] [Commented] (JEXL-314) Comparison NULL values of variables NAME1.NAME2

[ https://issues.apache.org/jira/browse/JEXL-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929252#comment-16929252 ] Osy commented on JEXL-314: -- I have an error trying to set engine to safe JexlEngine jexl = new

[jira] [Commented] (IO-554) FileUtils.copyToFile(InputStream source, File destination) should not close input stream

[ https://issues.apache.org/jira/browse/IO-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929114#comment-16929114 ] Václav Haisman commented on IO-554: --- Can we get a release of Commons IO with this fix? I have just hit it

[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES

[ https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929087#comment-16929087 ] Paul Dennis commented on NET-408: - [~mperktold] the long term solution might be

[jira] [Commented] (JEXL-314) Comparison NULL values of variables NAME1.NAME2

[ https://issues.apache.org/jira/browse/JEXL-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929039#comment-16929039 ] Henri Biestro commented on JEXL-314: Seems like the antish variable case is not handled correctly. As a

[jira] [Work logged] (LANG-1484) NumberUtils.isParsable returns false for strings ending with .

[ https://issues.apache.org/jira/browse/LANG-1484?focusedWorklogId=311897=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-311897 ] ASF GitHub Bot logged work on LANG-1484: Author: ASF GitHub Bot

[GitHub] [commons-lang] nicolasbd commented on issue #455: LANG-1484: Allow decimal point at the end of the String

nicolasbd commented on issue #455: LANG-1484: Allow decimal point at the end of the String URL: https://github.com/apache/commons-lang/pull/455#issuecomment-531125751 @saksham93 ah sorry I didn't know about those, but looking at them I see this : `assertFalse(

[GitHub] [commons-collections] aherbert commented on issue #83: WIP: Initial bloom filter code contribution

aherbert commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-531125377 When you are working on a single test you can run that on its own (or use a regex) and regenerate the test coverage report. For

[jira] [Commented] (NET-408) problem connecting to ProFTPD with FTPES

[ https://issues.apache.org/jira/browse/NET-408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929015#comment-16929015 ] Matthias Perktold commented on NET-408: --- Is there any progress on this? I am currently using a