[jira] [Commented] (LANG-1726) ExceptionUtils.asRuntimeException is not a good replacement for deprecated ExceptionUtils.rethrow

2024-01-04 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/LANG-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803352#comment-17803352 ] Niall Pemberton commented on LANG-1726: --- Václav has identified the main issue. It lo

[jira] [Commented] (IO-337) ByteOrderMark can be refactored as an enum

2023-12-25 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800316#comment-17800316 ] Niall Pemberton commented on IO-337: I will -1 this change if it is ever committed since

[jira] [Commented] (POOL-372) CallStackUtils mishandles security manager check part 2

2022-12-30 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/POOL-372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653233#comment-17653233 ] Niall Pemberton commented on POOL-372: -- The Security Manager was deprecated in *Java 1

[jira] [Commented] (POOL-264) NullPointerException in GKOP.borrowObject()

2022-12-24 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/POOL-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651820#comment-17651820 ] Niall Pemberton commented on POOL-264: -- The synchronization was removed in May 2011 wh

[jira] [Commented] (POOL-393) BaseGenericObjectPool.jmxRegister may cost too much time

2022-12-22 Thread Niall Pemberton (Jira)
[ https://issues.apache.org/jira/browse/POOL-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651437#comment-17651437 ] Niall Pemberton commented on POOL-393: -- I created the following PR: * [https://github

[jira] [Commented] (VALIDATOR-394) General Modulus Ten Check Digit Implementation

2016-06-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15326580#comment-15326580 ] Niall Pemberton commented on VALIDATOR-394: --- @Sebb - good point, I've cloned

[jira] [Updated] (VALIDATOR-394) General Modulus Ten Check Digit Implementation

2016-05-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated VALIDATOR-394: -- Description: Discussion on the commons dev mailing list about a CheckDigit implementa

[jira] [Updated] (VALIDATOR-394) General Modulus Ten Check Digit Implementation

2016-05-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated VALIDATOR-394: -- Attachment: VALIDATOR-394-Tests.patch VALIDATOR-394-ModulusTenCheckDig

[jira] [Created] (VALIDATOR-394) General Modulus Ten Check Digit Implementation

2016-05-07 Thread Niall Pemberton (JIRA)
Niall Pemberton created VALIDATOR-394: - Summary: General Modulus Ten Check Digit Implementation Key: VALIDATOR-394 URL: https://issues.apache.org/jira/browse/VALIDATOR-394 Project: Commons Validato

[jira] [Resolved] (IO-494) Mismatch return type in api docs of class DirectoryWalker.

2016-01-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-494. Resolution: Fixed Assignee: Niall Pemberton Thanks, I've fixed this > Mismatch return type in api

[jira] [Commented] (IO-487) ValidatingObjectInputStream contribution - restrict which classes can be deserialized

2015-11-18 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012207#comment-15012207 ] Niall Pemberton commented on IO-487: Go for it - looks good to me, the only minor comment

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-487: --- Attachment: IO-487-2.patch Attaching IO-487-2.patch which includes the following: * Change the ClassAccep

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005666#comment-15005666 ] Niall Pemberton commented on IO-487: Last comment! I think the ClassAcceptor's accept() me

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005663#comment-15005663 ] Niall Pemberton commented on IO-487: OK, makes sense. > SafeObjectInputStream contributio

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005662#comment-15005662 ] Niall Pemberton commented on IO-487: No, thats not true - IntersectionClassAcceptor is so

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005566#comment-15005566 ] Niall Pemberton commented on IO-487: Also an alternative to throwing UnsupportedOperationE

[jira] [Updated] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-487: --- Attachment: IO-487-name-regex-acceptor.patch An alternative would be for single RegexClassAcceptor & NameC

[jira] [Commented] (IO-487) SafeObjectInputStream contribution - restrict which classes can be deserialized

2015-11-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005423#comment-15005423 ] Niall Pemberton commented on IO-487: Personally I prefer SafeObjectInputStream over Valida

[jira] [Commented] (IO-337) ByteOrderMark can be refactored as an enum

2015-06-01 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14567831#comment-14567831 ] Niall Pemberton commented on IO-337: There are more byte order marks than the five defined

[jira] [Commented] (IO-478) Rename org.apache.commons.io.output.ByteArrayOutputStream

2015-05-24 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557833#comment-14557833 ] Niall Pemberton commented on IO-478: This was the case when it was added in 2003 and I don

[jira] [Commented] (LANG-992) NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

2014-03-27 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950314#comment-13950314 ] Niall Pemberton commented on LANG-992: -- I have checked in the change in revision 158258

[jira] [Updated] (LANG-992) NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

2014-03-26 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-992: - Attachment: (was: LANG-992.patch) > NumberUtils#isNumber() returns false for "0.0", "0.4790", e

[jira] [Updated] (LANG-992) NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

2014-03-26 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-992: - Attachment: LANG-992-v2.patch Attaching second version of patch > NumberUtils#isNumber() returns f

[jira] [Updated] (LANG-992) NumberUtils#isNumber() returns false for "0.0", "0.4790", et al

2014-03-26 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-992: - Attachment: LANG-992.patch Yes, this was caused by the second commit for LANG-972 in revision 1566

[jira] [Commented] (LANG-967) Code should never catch and ignore all Throwables

2014-03-25 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947347#comment-13947347 ] Niall Pemberton commented on LANG-967: -- Providing a utility class encourages it IMO and

[jira] [Commented] (LANG-967) Code should never catch and ignore all Throwables

2014-03-25 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947229#comment-13947229 ] Niall Pemberton commented on LANG-967: -- This seems like a bad idea to me - what circums

[jira] [Commented] (VALIDATOR-325) IBAN validation not calculated correctly

2013-12-04 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13838960#comment-13838960 ] Niall Pemberton commented on VALIDATOR-325: --- Its a good point, and it would p

[jira] [Updated] (VALIDATOR-325) IBAN validation not calculated correctly

2013-12-03 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated VALIDATOR-325: -- Attachment: IBANValidator.java It is pretty straight forward to combine the regular

[jira] [Commented] (VALIDATOR-325) IBAN validation not calculated correctly

2013-12-02 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/VALIDATOR-325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837299#comment-13837299 ] Niall Pemberton commented on VALIDATOR-325: --- Its been quite a while since I w

[jira] [Commented] (BEANUTILS-454) copyProperties() throws conversion exception for null Date

2013-11-25 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13832261#comment-13832261 ] Niall Pemberton commented on BEANUTILS-454: --- So this was a mistake when addin

[jira] [Updated] (IO-406) Move StringBufferOutputStream class to apache commons io project.

2013-11-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-406: --- Attachment: IO-406-AppendableOutputStream.patch Commons IO already has StringBuilderWriter (but not a Str

[jira] [Updated] (LANG-344) CollatorUtils - equivalent of StringUtils, but using Collators

2013-10-27 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-344: - Attachment: CollatorUtilsTest.java CollatorUtils.java > CollatorUtils - equivalent

[jira] [Resolved] (COMMONSSITE-30) Add Module profiles to parent poms

2013-10-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-30?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved COMMONSSITE-30. Resolution: Fixed Profiles to build proper & sandbox were added > Add Module p

[jira] [Resolved] (COMMONSSITE-22) Maven2 Plugin to generate custom component pages

2013-10-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved COMMONSSITE-22. Resolution: Fixed This is the commons-build-plugin - closing > Maven2 Plugin t

[jira] [Resolved] (COMMONSSITE-57) Fix broken link on http://commons.apache.org/mail-lists.html

2013-10-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved COMMONSSITE-57. Resolution: Fixed This was complted with release 1.4 of build plugin - closing

[jira] [Resolved] (COMMONSSITE-38) Upgrade to maven-javadoc-plugin 2.5 / *-javadoc.jar Manifest entries

2013-10-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-38?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved COMMONSSITE-38. Resolution: Fixed This has been done - closing > Upgrade to maven-javadoc-plug

[jira] [Resolved] (COMMONSSITE-21) commons-parent-6 pom changes

2013-10-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved COMMONSSITE-21. Resolution: Fixed closing > commons-parent-6 pom changes > ---

[jira] [Updated] (BEANUTILS-409) BeanUtils - 'describe' method returning Incorrect array value

2013-03-02 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated BEANUTILS-409: -- Attachment: BEANUTILS-409-register.patch I was thinking more along the lines of a ne

[jira] [Commented] (BEANUTILS-409) BeanUtils - 'describe' method returning Incorrect array value

2013-02-28 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590068#comment-13590068 ] Niall Pemberton commented on BEANUTILS-409: --- The reason behind this type of b

[jira] [Updated] (MATH-876) In v3, Bundle-SymbolicName should be org.apache.commons.math3 (not org.apache.commons.math as currently)

2013-01-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/MATH-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated MATH-876: - Attachment: MATH876-bundle-name.patch It would be better to override the commons.osgi.symbolicName

[jira] [Updated] (DBUTILS-106) DBUtils can't build using JDK 1.7 - DriverProxy needs to implement getParentLogger()

2013-01-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/DBUTILS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated DBUTILS-106: Attachment: DBUTILS106-dynamic-invoke.patch Alternative patch which invokes method dynamic

[jira] [Commented] (DBUTILS-106) DBUtils can't build using JDK 1.7 - DriverProxy needs to implement getParentLogger()

2013-01-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/DBUTILS-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545422#comment-13545422 ] Niall Pemberton commented on DBUTILS-106: - I have added the method in r1429538 -

[jira] [Created] (DBUTILS-106) DBUtils can't build using JDK 1.7 - DriverProxy needs to implement getParentLogger()

2013-01-06 Thread Niall Pemberton (JIRA)
Niall Pemberton created DBUTILS-106: --- Summary: DBUtils can't build using JDK 1.7 - DriverProxy needs to implement getParentLogger() Key: DBUTILS-106 URL: https://issues.apache.org/jira/browse/DBUTILS-106

[jira] [Commented] (IO-279) Tailer erroneously considers file as new

2012-06-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291498#comment-13291498 ] Niall Pemberton commented on IO-279: Ooo, my bad - this is already fixed. Still same as my

[jira] [Updated] (IO-279) Tailer erroneously considers file as new

2012-06-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-279: --- Attachment: IO-279.patch Firstly I don't know why System.currentTimeMillis() is used. What matters is if

[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2012-06-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291490#comment-13291490 ] Niall Pemberton commented on IO-269: Do you have any benchmark to back up the less efficie

[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2012-06-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291452#comment-13291452 ] Niall Pemberton commented on IO-269: With NIO2 in JDK 7 I wouldn't hold out much hope for

[jira] [Updated] (IO-269) Tailer locks file from deletion/rename on Windows

2012-06-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated IO-269: --- Attachment: IO-269-v2.patch The original patch is now out-of-date. Attaching IO-269-v2.patch which is up

[jira] [Commented] (CHAIN-55) split the huge project in submodules

2011-09-05 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/CHAIN-55?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097642#comment-13097642 ] Niall Pemberton commented on CHAIN-55: -- I agree with splitting the modules, mainly beca

[jira] [Resolved] (IO-277) ReaderInputStream enters infinite loop when it encounters an unmappable character

2011-09-05 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-277. Resolution: Fixed Fix Version/s: 2.1 Assignee: Niall Pemberton I have implemented your

[jira] [Resolved] (IO-283) When using the 2.0 Commons IO, there is no sort method for LastModifiedFileComparator

2011-09-05 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-283. Resolution: Invalid I have checked Commons IO 2.0 and the sort() method is available. Note that prior

[jira] [Resolved] (IO-272) LineIterator could easily support Iterable

2011-05-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-272. Resolution: Duplicate > LineIterator could easily support Iterable > --

[jira] [Commented] (IO-269) Tailer locks file from deletion/rename on Windows

2011-04-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018287#comment-13018287 ] Niall Pemberton commented on IO-269: This was reported by Hemal Pandya in the following th

[jira] [Commented] (IO-266) FileUtils.copyFile() throws IOException when copying large files to a shared directory (on Windows)

2011-04-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018285#comment-13018285 ] Niall Pemberton commented on IO-266: I think we should just reduce the size to fix the pro

[jira] [Commented] (IO-250) Add FileUtils.pathTo(File aFile, File fromAnotherFile)

2011-04-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13018284#comment-13018284 ] Niall Pemberton commented on IO-250: I'd prefer to avoid the name PathUtils - NIO2 introdu

[jira] [Resolved] (IO-267) Implement Iterable versions of methods that currently provide an Iterator

2011-04-01 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-267. Resolution: Won't Fix You can use FileUtils.listFiles() - http://tinyurl.com/3bs9uya > Implement Itera

[jira] [Commented] (BEANUTILS-384) ConvertUtilsBean unable to process javassist classes

2011-03-22 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009616#comment-13009616 ] Niall Pemberton commented on BEANUTILS-384: --- Switching from a straight Map.ge

[jira] Issue Comment Edited: (IO-174) CharSequenceReader does not obey Reader contract and throw IOExceptions if read when closed

2011-03-13 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006289#comment-13006289 ] Niall Pemberton edited comment on IO-174 at 3/13/11 11:23 PM: -- Ye

[jira] Commented: (IO-174) CharSequenceReader does not obey Reader contract and throw IOExceptions if read when closed

2011-03-13 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006289#comment-13006289 ] Niall Pemberton commented on IO-174: Yes you're right and its a shame I didn't think of it

[jira] Commented: (IO-174) CharSequenceReader does not obey Reader contract and throw IOExceptions if read when closed

2011-03-13 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006277#comment-13006277 ] Niall Pemberton commented on IO-174: The main point was that it was designed that way - to

[jira] Resolved: (IO-261) getFile with varargs parameter

2011-03-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-261. Resolution: Fixed Fix Version/s: 2.1 Assignee: Niall Pemberton Fixed thanks http://svn

[jira] Resolved: (IO-174) CharSequenceReader does not obey Reader contract and throw IOExceptions if read when closed

2011-03-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-174. Resolution: Won't Fix Fix Version/s: (was: 3.x) > CharSequenceReader does not obey Reader co

[jira] Resolved: (IO-182) add new APPEND parameter for writing string into files

2011-03-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-182. Resolution: Fixed Fix Version/s: (was: 3.x) 2.1 Assignee: Niall P

[jira] Resolved: (IO-259) FileAlterationMonitor.stop(boolean allowIntervalToFinish)

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-259. Resolution: Fixed Fix Version/s: 2.1 Assignee: Niall Pemberton Good suggestions - I add

[jira] Resolved: (IO-260) ClassLoaderObjectInputStream does not handle Proxy classes

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-260. Resolution: Fixed Fix Version/s: 2.1 Assignee: Niall Pemberton Fixed, thanks http://sv

[jira] Resolved: (IO-265) vararg constructor in AndFileFilter and OrFileFilter is required

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-265. Resolution: Won't Fix > vararg constructor in AndFileFilter and OrFileFilter is required >

[jira] Resolved: (IO-264) FileUtils.moveFile() JavaDoc should specify FileExistsException thrown

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-264. Resolution: Fixed Fix Version/s: 2.1 Assignee: Niall Pemberton Thanks, I updated the ja

[jira] Resolved: (IO-262) FileAlterationObserver has no getter for FileFilter

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved IO-262. Resolution: Fixed Fix Version/s: 2.1 Fixed, thanks for the suggestion http://svn.apache.org/vie

[jira] Resolved: (BEANUTILS-390) BeanComparator throws exception for null property values

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved BEANUTILS-390. --- Resolution: Won't Fix There is no need for NullSafeBeanComparator - you can constr

[jira] Commented: (IO-265) vararg constructor in AndFileFilter and OrFileFilter is required

2011-03-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/IO-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13005910#comment-13005910 ] Niall Pemberton commented on IO-265: You can use: * FileFilterUtils.and(IOFileFilter.

[jira] Resolved: (LANG-679) StringUtils.startsWithIgnoreCase whrong documentation

2011-03-03 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-679. -- Resolution: Duplicate Duplicates LANG-460 fixed in Lang 2.5 > StringUtils.startsWithIgnoreCase w

[jira] Resolved: (BEANUTILS-388) WrapDynaBean should handle Boolean property with is...() getter

2011-02-24 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved BEANUTILS-388. --- Resolution: Duplicate Duplicates BEANUTILS-321, BEANUTILS-356, BEANUTILS-364 > Wr

[jira] Resolved: (BEANUTILS-387) [beanutils] copyProperties() throws a ConversionException : No value specified for 'Date' when the field is a java.util.Date with a null value

2011-01-26 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved BEANUTILS-387. --- Resolution: Won't Fix Prior to BeanUtils 1.8.0 there was no converter for java.uti

[jira] Commented: (CODEC-109) Allow the build to run with Maven 2 and Maven 3

2011-01-20 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/CODEC-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984202#action_12984202 ] Niall Pemberton commented on CODEC-109: --- You need to check the "Plugins Compatibility

[jira] Commented: (COMMONSSITE-57) Fix broken link on http://commons.apache.org/mail-lists.html

2011-01-18 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/COMMONSSITE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983226#action_12983226 ] Niall Pemberton commented on COMMONSSITE-57: I fixed this a while ago: htt

[jira] Resolved: (BEANUTILS-386) Maven - missing dependency on Commons Collections

2011-01-14 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/BEANUTILS-386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved BEANUTILS-386. --- Resolution: Invalid BeanUtils 1.8.3 specifies commons-collections in its pom as a

[jira] Commented: (LANG-671) Add indexOf() & lastIndexOf() methods for Whitespace and Non-whitespae to StringUtils

2011-01-13 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981513#action_12981513 ] Niall Pemberton commented on LANG-671: -- It is a more powerful facility than the StringUt

[jira] Updated: (LANG-671) Add indexOf() & lastIndexOf() methods for Whitespace and Non-whitespae to StringUtils

2011-01-12 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-671: - Attachment: LANG-671-StringUtils-whitespace.patch Attaching LANG-671-StringUtils-whitespace.patch

[jira] Created: (LANG-671) Add indexOf() & lastIndexOf() methods for Whitespace and Non-whitespae to StringUtils

2011-01-12 Thread Niall Pemberton (JIRA)
Add indexOf() & lastIndexOf() methods for Whitespace and Non-whitespae to StringUtils - Key: LANG-671 URL: https://issues.apache.org/jira/browse/LANG-671 Project: Com

[jira] Commented: (LANG-593) Testing with JDK 1.7

2011-01-11 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980472#action_12980472 ] Niall Pemberton commented on LANG-593: -- With b102 the same problem with FastDateFormatTe

[jira] Commented: (LANG-607) StringUtils methods do not handle Unicode 2.0+ supplementary characters correctly.

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979877#action_12979877 ] Niall Pemberton commented on LANG-607: -- Is the work thats been done so far OK to go into

[jira] Resolved: (LANG-636) text.ExtendedMessageFormat doesn't override java.text.MessageFormat.equals(Object)

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-636. -- Resolution: Fixed Fix Version/s: (was: 3.0) 2.6 Assignee: N

[jira] Resolved: (LANG-670) Add notEqual() method to ObjectUtils

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-670. -- Resolution: Fixed Fixed: http://svn.apache.org/viewvc?view=revision&revision=1057410 > Add notEq

[jira] Created: (LANG-670) Add notEqual() method to ObjectUtils

2011-01-10 Thread Niall Pemberton (JIRA)
Add notEqual() method to ObjectUtils Key: LANG-670 URL: https://issues.apache.org/jira/browse/LANG-670 Project: Commons Lang Issue Type: New Feature Components: lang.* Affects Versions: 2.5

[jira] Commented: (LANG-607) StringUtils methods do not handle Unicode 2.0+ supplementary characters correctly.

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979781#action_12979781 ] Niall Pemberton commented on LANG-607: -- Is the work complete on this? I have ported the

[jira] Resolved: (LANG-603) Removes "implement Cloneable" from StrBuilder

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-603. -- Resolution: Won't Fix The clone() method has been implemented in the 2.x branch (see LANG-302) >

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-10 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Fix Version/s: 2.6 Implemented clone() method in LANG 2.x branch: http://svn.apache.org/viewvc?

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Attachment: (was: LANG-302-clone-v2.patch) > StrBuilder does not implement clone() > --

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Attachment: LANG-302-clone-v3.patch v2 of patch attached > StrBuilder does not implement clone() >

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Attachment: (was: LANG-302-clone.patch) > StrBuilder does not implement clone() > -

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Attachment: LANG-302-clone-v2.patch v2 of patch attached > StrBuilder does not implement clone() >

[jira] Commented: (LANG-669) Use StrBuilder instead of StringBuffer to improve performance where sync. is not an issue (Lang 2.x branch)

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979455#action_12979455 ] Niall Pemberton commented on LANG-669: -- http://svn.apache.org/viewvc?view=revision&revis

[jira] Resolved: (LANG-669) Use StrBuilder instead of StringBuffer to improve performance where sync. is not an issue (Lang 2.x branch)

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-669. -- Resolution: Fixed > Use StrBuilder instead of StringBuffer to improve performance where sync. is

[jira] Created: (LANG-669) Use StrBuilder instead of StringBuffer to improve performance where sync. is not an issue (Lang 2.x branch)

2011-01-09 Thread Niall Pemberton (JIRA)
Use StrBuilder instead of StringBuffer to improve performance where sync. is not an issue (Lang 2.x branch) --- Key: LANG-669 URL: https://issues.apache.org/ji

[jira] Updated: (LANG-302) StrBuilder does not implement clone()

2011-01-09 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-302: - Attachment: LANG-302-clone.patch I know this is resolved for 3.0 - but Sebb raised this again conce

[jira] Commented: (LANG-594) DateUtils equal & compare functions up to most significant field

2011-01-08 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979171#action_12979171 ] Niall Pemberton commented on LANG-594: -- This could do with some unit tests > DateUtils

[jira] Commented: (LANG-667) Add a Null-safe compare() method to ObjectUtils

2011-01-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978972#action_12978972 ] Niall Pemberton commented on LANG-667: -- Simplified the code as per Julien's suggestion:

[jira] Commented: (LANG-667) Add a Null-safe compare() method to ObjectUtils

2011-01-07 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978707#action_12978707 ] Niall Pemberton commented on LANG-667: -- @Julien - thanks for the suggestion, I'll look a

[jira] Resolved: (LANG-668) Change ObjectUtils min() & max() functions to use varargs rather than just two parameters

2011-01-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton resolved LANG-668. -- Resolution: Fixed Fixed: http://svn.apache.org/viewvc?view=revision&revision=1056134 > Change Ob

[jira] Updated: (LANG-668) Change ObjectUtils min() & max() functions to use varargs rather than just two parameters

2011-01-06 Thread Niall Pemberton (JIRA)
[ https://issues.apache.org/jira/browse/LANG-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Niall Pemberton updated LANG-668: - Description: Currently ObjectUtils has min() and max() method with the following signatures: {code

  1   2   3   4   5   6   7   8   9   10   >