[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

2022-12-04 Thread GitBox
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1336519441 > > > @arturobernalg > > > Do you even run local builds before pushing out a PR? > > > Some of these tests will obviously fail, for example, see Exec65Test where the OS

[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

2022-12-04 Thread GitBox
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1336506234 > @arturobernalg > Do you even run local builds before pushing out a PR? > Some of these tests will obviously fail, for example, see Exec65Test where the OS checks were not

[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

2022-11-29 Thread GitBox
arturobernalg commented on PR #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-1331293219 > @arturobernalg > Hi, > This component is now on Java 8. Hey @garydgregory I think its already done. TY -- This is an automated message from the Apache

[GitHub] [commons-exec] arturobernalg commented on pull request #27: [EXEC-114] - Migrate to Junit 5

2020-12-16 Thread GitBox
arturobernalg commented on pull request #27: URL: https://github.com/apache/commons-exec/pull/27#issuecomment-746971803 Hi @garydgregory you're right, I didn't realize that it actually requires version 1.7. How can i start the process to migrate the libs to java 1.8?