[GitHub] [flink] flinkbot edited a comment on pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14963: URL: https://github.com/apache/flink/pull/14963#issuecomment-781452668 ## CI report: * 80874c3472c2d74de07c651d56c728e210e9db6d UNKNOWN * d6bbdeabce59f5556c0d1be6e88e098df84d7f98 Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578737299 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() { ret

[GitHub] [flink] sjwiesman opened a new pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
sjwiesman opened a new pull request #14964: URL: https://github.com/apache/flink/pull/14964 ## What is the purpose of the change Document the trade-offs of setting different checkpoint interval values and provide guidance on how to determine the appropriate interval for a given job.

[jira] [Updated] (FLINK-21410) Document checkpoint interval trade-offs

2021-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21410: --- Labels: pull-request-available (was: ) > Document checkpoint interval trade-offs >

[GitHub] [flink] flinkbot commented on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot commented on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781635100 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot commented on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14847: [FLINK-21030][runtime] Add global failover in case of a stop-with-savepoint failure

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14847: URL: https://github.com/apache/flink/pull/14847#issuecomment-772387941 ## CI report: * 9a2ea20ce0803e48edfc3ab7bcc02078b7410fbf UNKNOWN * 4aecfae5f4889de59c7f1d71d39647b6ee6f9ad8 UNKNOWN * 36b3d657e3fa3151aac181d709706dadf58c

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] dannycranmer commented on pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on pull request #14737: URL: https://github.com/apache/flink/pull/14737#issuecomment-781667422 As a follow up we should add support for SQL client and Table API by: - Adding a shaded module for SQL client, similar to [flink-sql-avro-confluent-registry](https://gith

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578786368 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() { ret

[GitHub] [flink] XComp commented on a change in pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
XComp commented on a change in pull request #14798: URL: https://github.com/apache/flink/pull/14798#discussion_r578787023 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java ## @@ -635,6 +641,33 @@ public void cancel() { ret

[GitHub] [flink] zentol commented on a change in pull request #14963: [FLINK-21362][coordination] Move State.onEnter() logic into constructor

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14963: URL: https://github.com/apache/flink/pull/14963#discussion_r578791931 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/RestartingTest.java ## @@ -209,6 +210,7 @@ public void close() th

[GitHub] [flink] zentol commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578794106 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/MockExecutionGraphBase.java ## @@ -0,0 +1,424 @@ +/* + * Licensed to the

[GitHub] [flink] dannycranmer commented on a change in pull request #14737: [FLINK-19667] Add AWS Glue Schema Registry integration

2021-02-18 Thread GitBox
dannycranmer commented on a change in pull request #14737: URL: https://github.com/apache/flink/pull/14737#discussion_r578805957 ## File path: flink-end-to-end-tests/test-scripts/test_glue_schema_registry.sh ## @@ -0,0 +1,72 @@ +#!/usr/bin/env bash Review comment: @Liny

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN * 8e732bfb2bddc38ec7422f482dcda4be3d29

[GitHub] [flink] flinkbot edited a comment on pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14928: URL: https://github.com/apache/flink/pull/14928#issuecomment-14828 ## CI report: * 20915f746d6fd359f00a6f7a77aa3b7c349a94fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN * 8e732bfb2bddc38ec7422f482dcda4be3d29

[GitHub] [flink] flinkbot edited a comment on pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14951: URL: https://github.com/apache/flink/pull/14951#issuecomment-780579743 ## CI report: * 75d0067ce378ce84d7e8edbe1810cf85bdcab9fb Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Comment Edited] (FLINK-21133) FLIP-27 Source does not work with synchronous savepoint

2021-02-18 Thread Jiangjie Qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286380#comment-17286380 ] Jiangjie Qin edited comment on FLINK-21133 at 2/19/21, 12:41 AM: -

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * ed1dc2c2399cd7a9a0e8c5c68f4b39470e7ec10e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] xintongsong closed pull request #14954: [FLINK-17061][runtime] Unset TM total process/flink memory size for fine-grained resource management

2021-02-18 Thread GitBox
xintongsong closed pull request #14954: URL: https://github.com/apache/flink/pull/14954 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-17061) Unset process/flink memory size from configuration once dynamic worker resource is activated.

2021-02-18 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-17061. Fix Version/s: 1.13.0 Resolution: Fixed Fixed via: * master (1.13): 082fcebc33383a21d6f88e4

[jira] [Created] (FLINK-21411) The components on which Flink depends may contain vulnerabilities. If yes, fix them.

2021-02-18 Thread dgbro (Jira)
dgbro created FLINK-21411: - Summary: The components on which Flink depends may contain vulnerabilities. If yes, fix them. Key: FLINK-21411 URL: https://issues.apache.org/jira/browse/FLINK-21411 Project: Flink

[GitHub] [flink] flinkbot edited a comment on pull request #14868: [FLINK-21326][runtime] Optimize building topology when initializing ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14868: URL: https://github.com/apache/flink/pull/14868#issuecomment-773192044 ## CI report: * 85af2bb6354ce46e90d607ee0f784a91266b80b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Commented] (FLINK-21319) hadoop-mapreduce jars are not loaded into classpath when submiting flink on yarn jobs.

2021-02-18 Thread Tang Yan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286807#comment-17286807 ] Tang Yan commented on FLINK-21319: -- Thanks for your reply. [~trohrmann] Could you check

[GitHub] [flink] flinkbot edited a comment on pull request #14868: [FLINK-21326][runtime] Optimize building topology when initializing ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14868: URL: https://github.com/apache/flink/pull/14868#issuecomment-773192044 ## CI report: * 85af2bb6354ce46e90d607ee0f784a91266b80b1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578870795 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DeclarativeSlotManager.java ## @@ -600,61 +603,69 @@ priv

[GitHub] [flink] gaoyunhaii commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578872539 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlanCalculator.java ## @@ -0,0 +1,329 @@ +/* + * Licens

[GitHub] [flink] KarmaGYZ commented on a change in pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on a change in pull request #14897: URL: https://github.com/apache/flink/pull/14897#discussion_r578874000 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/BiDirectionalResourceToRequirementMapping.java ## @@ -74,

[GitHub] [flink] KarmaGYZ commented on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
KarmaGYZ commented on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-781765733 Thanks for the new comments @tillrohrmann . PR updated according to it. This is an automated message from the A

[GitHub] [flink] gaoyunhaii commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578879271 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -651,39 +681,52 @@ private void startT

[GitHub] [flink] flinkbot edited a comment on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775050448 ## CI report: * 35644082e06622b2182b6fb68d9a30df167d5c11 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779315396 ## CI report: * 2ee9ac64332d3547bf934d7cd17f73ee5404c8b1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] gaoyunhaii commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578879271 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java ## @@ -651,39 +681,52 @@ private void startT

[jira] [Commented] (FLINK-20427) Remove CheckpointConfig.setPreferCheckpointForRecovery because it can lead to data loss

2021-02-18 Thread Rex Remind (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286823#comment-17286823 ] Rex Remind commented on FLINK-20427: Cool, thanks! > Remove CheckpointConfig.setPre

[GitHub] [flink] flinkbot edited a comment on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775050448 ## CI report: * 35644082e06622b2182b6fb68d9a30df167d5c11 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #14944: [FLINK-21297] Support 'LOAD/UNLOAD MODULE' syntax

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14944: URL: https://github.com/apache/flink/pull/14944#issuecomment-779315396 ## CI report: * 2ee9ac64332d3547bf934d7cd17f73ee5404c8b1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] anlen321 commented on a change in pull request #14684: [FLINK-20460][Connector-HBase] Support async lookup for HBase connector

2021-02-18 Thread GitBox
anlen321 commented on a change in pull request #14684: URL: https://github.com/apache/flink/pull/14684#discussion_r57288 ## File path: flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/options/HBaseOptions.java ## @@ -94,6 +94,33 @@

[jira] [Closed] (FLINK-21049) query_configuration.html content out date

2021-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-21049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 谢波 closed FLINK-21049. -- Fix Version/s: 1.13.0 Resolution: Fixed > query_configuration.html content out date > -

[jira] [Closed] (FLINK-21370) flink-1.12.1 - JDBCExecutionOptions defaults config JDBCDynamicTableFactory default config is not consistent

2021-02-18 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-21370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 谢波 closed FLINK-21370. -- Resolution: Not A Problem > flink-1.12.1 - JDBCExecutionOptions defaults config JDBCDynamicTableFactory > default con

[jira] [Created] (FLINK-21412) pyflink DataTypes.DECIMAL is not available

2021-02-18 Thread awayne (Jira)
awayne created FLINK-21412: -- Summary: pyflink DataTypes.DECIMAL is not available Key: FLINK-21412 URL: https://issues.apache.org/jira/browse/FLINK-21412 Project: Flink Issue Type: Bug Comp

[jira] [Created] (FLINK-21413) TtlMapState and TtlListState cannot be clean completely with Filesystem StateBackend

2021-02-18 Thread Jiayi Liao (Jira)
Jiayi Liao created FLINK-21413: -- Summary: TtlMapState and TtlListState cannot be clean completely with Filesystem StateBackend Key: FLINK-21413 URL: https://issues.apache.org/jira/browse/FLINK-21413 Proj

[jira] [Updated] (FLINK-21413) TtlMapState and TtlListState cannot be clean completely with Filesystem StateBackend

2021-02-18 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-21413: --- Description: Take the #TtlMapState as an example,   {code:java} public Map> getUnexpiredOrNull(@Non

[jira] [Updated] (FLINK-21413) TtlMapState and TtlListState cannot be clean completely with Filesystem StateBackend

2021-02-18 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiayi Liao updated FLINK-21413: --- Attachment: image-2021-02-19-11-13-58-672.png > TtlMapState and TtlListState cannot be clean complet

[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14891: URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149 ## CI report: * 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578903917 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageLoader.java ## @@ -162,14 +163,19 @@ public static CheckpointSto

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578904214 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java ## @@ -204,6 +222,11 @@ public static StateBackend fromA

[GitHub] [flink] flinkbot edited a comment on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-766340750 ## CI report: * c7e6b28b249f85cf52740d5201a769e0982a60aa UNKNOWN * bebd298009b12a9d5ac6518902f5534f8e00ff32 UNKNOWN * c69c79df69c5fa912b6d16e3cfa40edc3b9b

[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14891: URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149 ## CI report: * 1976f8fa0310d74fccbd2ccf0ccb6f7b904a60a6 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] gaoyunhaii commented on a change in pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on a change in pull request #14740: URL: https://github.com/apache/flink/pull/14740#discussion_r578907964 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/DefaultCheckpointPlanCalculator.java ## @@ -0,0 +1,329 @@ +/* + * Licens

[GitHub] [flink] gaoyunhaii commented on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
gaoyunhaii commented on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-781798040 Hi Roman @rkhachatryan very thanks for the review! I updated the PR according to the comments~ This is an au

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578909351 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegatedStateBackend.java ## @@ -0,0 +1,29 @@ +/* + * Licensed to the A

[GitHub] [flink] flinkbot edited a comment on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-766340750 ## CI report: * c7e6b28b249f85cf52740d5201a769e0982a60aa UNKNOWN * bebd298009b12a9d5ac6518902f5534f8e00ff32 UNKNOWN * c69c79df69c5fa912b6d16e3cfa40edc3b9b

[GitHub] [flink] flinkbot edited a comment on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-766340750 ## CI report: * c7e6b28b249f85cf52740d5201a769e0982a60aa UNKNOWN * bebd298009b12a9d5ac6518902f5534f8e00ff32 UNKNOWN * c69c79df69c5fa912b6d16e3cfa40edc3b9b

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578904214 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java ## @@ -204,6 +222,11 @@ public static StateBackend fromA

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578931575 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/delegate/DelegateStateBackend.java ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Ap

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578931859 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java ## @@ -242,6 +265,53 @@ public static StateBackend fromA

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578932063 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackendLoader.java ## @@ -242,6 +265,53 @@ public static StateBackend fromA

[GitHub] [flink] flinkbot edited a comment on pull request #14964: [FLINK-21410][docs] Document checkpoint interval trade-offs

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14964: URL: https://github.com/apache/flink/pull/14964#issuecomment-781637879 ## CI report: * 63cafd0fe1c8c1c43e69f5acf5faf1256073dcea Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] curcur commented on a change in pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on a change in pull request #14943: URL: https://github.com/apache/flink/pull/14943#discussion_r578936411 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/changelog/state/ChangelogAggregatingState.java ## @@ -0,0 +

[GitHub] [flink] curcur commented on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
curcur commented on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-781830344 rebase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * c9be932fec6390ffb103c000550cbc85747c266e Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * c9be932fec6390ffb103c000550cbc85747c266e Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #14943: [FLINK-21354] Implement a StateChangelogStateBackend to forward state changes to St…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14943: URL: https://github.com/apache/flink/pull/14943#issuecomment-779315285 ## CI report: * f80b97c479ec82663e971553c54c8a6cda3122ff UNKNOWN * c9be932fec6390ffb103c000550cbc85747c266e Azure: [SUCCESS](https://dev.azure.com/apache-fl

[GitHub] [flink] flinkbot edited a comment on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-769223911 ## CI report: * af8de65a4905ae47ab704a75acfcd1b2e897d915 UNKNOWN * 772e076ed9d773e16713236c942f4e30b659d6eb UNKNOWN * 854b645872b5596d2cc618c65dac0228c616

[GitHub] [flink] flinkbot edited a comment on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775050448 ## CI report: * 06c2bdca6652a653ece66c02c5a96d79326662e6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-21414) javax.net.ssl.SSLHandshakeException: Received fatal alert: certificate_unknown

2021-02-18 Thread Bhagi (Jira)
Bhagi created FLINK-21414: - Summary: javax.net.ssl.SSLHandshakeException: Received fatal alert: certificate_unknown Key: FLINK-21414 URL: https://issues.apache.org/jira/browse/FLINK-21414 Project: Flink

[GitHub] [flink] zentol merged pull request #14928: [FLINK-21360][coordination] Make resource timeout configurable

2021-02-18 Thread GitBox
zentol merged pull request #14928: URL: https://github.com/apache/flink/pull/14928 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Closed] (FLINK-21360) Add resourceTimeout configuration

2021-02-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-21360. Resolution: Fixed master: 3dbb18491aa81af29f0e3b3ee0b6dd58ce02ef76 > Add resourceTimeout

[GitHub] [flink] zentol merged pull request #14951: [FLINK-21380][coordination] Hide terminal ExecutionGraph in StateWithExecutionGraph

2021-02-18 Thread GitBox
zentol merged pull request #14951: URL: https://github.com/apache/flink/pull/14951 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Closed] (FLINK-21380) Restarting/Canceling/Failing expose globally-terminal EG

2021-02-18 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-21380. Resolution: Fixed master: 2a78440bd333a68c24acfeea016f35ec63bbe3f9 > Restarting/Canceling

[GitHub] [flink] flinkbot edited a comment on pull request #14868: [FLINK-21326][runtime] Optimize building topology when initializing ExecutionGraph

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #14868: URL: https://github.com/apache/flink/pull/14868#issuecomment-773192044 ## CI report: * 997d4dddfc4d6ae2f45d80102655d02f09168d1b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] zentol commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578975860 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ## @@ -0,0 +1,459 @@ +/* + *

[GitHub] [flink] zentol commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578976098 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ## @@ -0,0 +1,459 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #13384: [FLINK-19224][state-processor-api] Support reading window operator state

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13384: URL: https://github.com/apache/flink/pull/13384#issuecomment-692328370 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13418: [FLINK-FLINK][docs] Update the version in docs/_config.yml to be the latest released minor version

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13418: URL: https://github.com/apache/flink/pull/13418#issuecomment-694697519 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13396: [FLINK-19248] add missing lastJobExecutionResult assignment after job finished in ContexEnvironment

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13396: URL: https://github.com/apache/flink/pull/13396#issuecomment-693187999 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13417: [FLINK-FLINK][docs] Update the version in docs/_config.yml to be the latest released minor version

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13417: URL: https://github.com/apache/flink/pull/13417#issuecomment-694697532 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13275: [FLINK-19064][hbase] HBaseRowDataInputFormat is leaking resources

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13275: URL: https://github.com/apache/flink/pull/13275#issuecomment-682387017 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #12962: [FLINK-18694] Add unaligned checkpoint config to web ui

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #12962: URL: https://github.com/apache/flink/pull/12962#issuecomment-662518124 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13102: [FLINK-18515][Kinesis] Adding FanOutRecordPublisher for Kinesis EFO support

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13102: URL: https://github.com/apache/flink/pull/13102#issuecomment-671232457 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13189: [FLINK-18661][Kinesis] Stream consumer Registration/Deregistration

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13189: URL: https://github.com/apache/flink/pull/13189#issuecomment-675341370 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13432: [FLINK-19280][connectors] fix the bug of the option "sink.buffer-flush.max-rows" for JDBC can't be disabled by set to zero

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13432: URL: https://github.com/apache/flink/pull/13432#issuecomment-695807197 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13435: [FLINK-19299][tests] Fix that NettyShuffleEnvironmentBuilder#setBufferSize does not take effect

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13435: URL: https://github.com/apache/flink/pull/13435#issuecomment-695891985 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13433: [BP-1.11][FLINK-19280][jdbc] Fix option "sink.buffer-flush.max-rows" for JDBC can't be disabled by setting to zero

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13433: URL: https://github.com/apache/flink/pull/13433#issuecomment-695888255 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13401: [FLINK-19161][file connector] Add first version of the FLIP-27 File Source

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13401: URL: https://github.com/apache/flink/pull/13401#issuecomment-693272292 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13436: [FLINK-19301][python] Improve the package structure of Python DataStream API

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13436: URL: https://github.com/apache/flink/pull/13436#issuecomment-695928048 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13426: [FLINK-19244] CsvRowDataDeserializationSchema throws cast exception : Row length mismatch.

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13426: URL: https://github.com/apache/flink/pull/13426#issuecomment-695220756 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] zentol commented on a change in pull request #14950: [FLINK-21347][coordination] Extract interface from ExecutionGraph

2021-02-18 Thread GitBox
zentol commented on a change in pull request #14950: URL: https://github.com/apache/flink/pull/14950#discussion_r578976880 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/declarative/StateTrackingMockExecutionGraph.java ## @@ -0,0 +1,459 @@ +/* + *

[GitHub] [flink] flinkbot edited a comment on pull request #13444: [BP-1.11][FLINK-19244] CsvRowDataDeserializationSchema throws cast ex…

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13444: URL: https://github.com/apache/flink/pull/13444#issuecomment-696202108 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13392: [FLINK-18713][table-planner-blink] Change duration configOption to duration type

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13392: URL: https://github.com/apache/flink/pull/13392#issuecomment-692536820 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13427: [FLINK-17767][table-planner-blink]Tumbling/Sliding window aggregate support window start offset in batch and streaming mode

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13427: URL: https://github.com/apache/flink/pull/13427#issuecomment-695763230 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #13442: [FLINK-19321][Table SQL / Runtime]CollectSinkFunction does not define serialVersionUID

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #13442: URL: https://github.com/apache/flink/pull/13442#issuecomment-696189196 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track

[GitHub] [flink] flinkbot edited a comment on pull request #8142: [FLINK-12148][clients] Give precedence to specified local jar

2021-02-18 Thread GitBox
flinkbot edited a comment on pull request #8142: URL: https://github.com/apache/flink/pull/8142#issuecomment-481692125 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track th

<    1   2   3   4   5   >